Eslint-plugin-import: "import type" from TypeScript 3.8 not recognized

[juergenzimmermann]

After upgrading to TypeScript 3.8.2 I also use the new "import type" feature https://www.typescriptlang.org/docs/handbook/modules.html#importing-types. Now I'm getting a warning from _import/no-duplicates_.

My affected code is e.g.:

import type { Options } from 'express-rate-limit';
import rateLimit from 'express-rate-limit';

[ljharb]

3.8 is brand new, so we definitely need updates to work with it, probably on many rules.

[kmui2]

I think this PR may fix this specific issue with type imports: #1666

[noahbrenner]

Just so we're all on the same page, I thought I'd confirm where we're all coming from. If I understand correctly:

• The PR @kmui2' referred to (#1666) includes a fixer that can combine a default export and a named export into one line.
• @juergenzimmermann's issue is that that import type and import lines should be separate since they behave differently -- they shouldn't be combined and they shouldn't be reported as an error for the import/no-duplicates rule.

Please correct me if I misunderstood either of you.

[kmui2]

Just so we're all on the same page, I thought I'd confirm where we're all coming from. If I understand correctly:

• The PR @kmui2' referred to (#1666) includes a fixer that can combine a default export and a named export into one line.
• @juergenzimmermann's issue is that that import type and import lines _should_ be separate since they behave differently -- they shouldn't be combined and they shouldn't be reported as an error for the import/no-duplicates rule.

Please correct me if I misunderstood either of you.

Sorry, I was only speculating because I saw the plugin had support for import type coming from Flow types and thought it was something related to a generic default and named export problem.

[noahbrenner]

No worries! I'm not seeing the string "type" anywhere in that particular PR, could that have just been a typo in the issue number, and there's another PR you found that does cover this? It would be great to see it if so!

[kmui2]

No worries! I'm not seeing the string "type" anywhere in that particular PR, could that have just been a typo in the issue number, and there's another PR you found that _does_ cover this? It would be great to see it if so!

I was actually looking into this myself for a bit, but I don't see any other related PR.

[ljharb]

https://github.com/benmosher/eslint-plugin-import/issues/1667#issuecomment-594243654 matches my understanding.

a PR to do that, with tests, would be appreciated.

[kmui2]

Seems TypeScript ESLint currently (v2.22.0) does not have support for TypeScript 3.8 yet (>=3.2.1 <3.8.0, https://github.com/typescript-eslint/typescript-eslint/issues/1436). Because of this, it's not currently possible to write a test for the import type syntax. So I'm afraid we need to wait for the TypeScript 3.8 support for ESLint.

For future reference, here's the test I was writing:

context('TypeScript', function() {
  getNonDefaultParsers().forEach((parser) => {
    const parserConfig = {
      parser: parser,
      settings: {
        'import/parsers': { [parser]: ['.ts'] },
        'import/resolver': { 'eslint-import-resolver-typescript': true },
      },
    }

    ruleTester.run('no-duplicates', rule, {
      valid: [
        // #1667: ignore duplicate if is a typescript type import
        test(
          {
            code: "import type { x } from './foo'; import y from './foo'",
            parser,
          },
          parserConfig,
        ),
      ],
      invalid: [],
    })
  })
})

    "@typescript-eslint/parser": "^2.22.0",
    "eslint-import-resolver-typescript": "^2.0.0",
    "typescript": "^3.8.3",

As of these TypeScript ESLint package versions, it will produce the error:

AssertionError [ERR_ASSERTION] [ERR_ASSERTION]: A fatal parsing error occurred in autofix: Parsing error: '{' expected.

[ljharb]

Thanks, that makes sense. If you want to open a PR (which would fail until the new version is released) that'd still be appreciated.

[xiaoxiangmoe]

rule import/order also needs to consider import type and import