Eslint-plugin-import: no-cycle: consider deep require calls
Just making a note to come back to no-cycle and capture require calls in ExportMap to check for cycles in addition to exploring import statements.
benmosher
All 6 comments
I'd appreciate this a lot; just fiddled with the no-cycle rule for a while, only to realize that it just doesn't work for good old regular Node.js projects (it does say so in the docs, but it's not quite obvious).
Just had a quick look at ExportMap myself, but this doesn't strike me as an easy first contribution :)
yelworc
on 23 Aug 2019
There's eslint-plugin-dependencies that used to work with require, but it seems abandoned.
Perhaps it can be scavenged?
soryy708
on 23 Oct 2019
soryy708
on 23 Oct 2019
I'm writing some tests for this. How do you expect this to work with regards to the commonjs option? Should it look for dependency cycles in requires only if commonjs: true?
soryy708
on 24 Oct 2019
So this is sort-of a revert of https://github.com/benmosher/eslint-plugin-import/pull/797 ?
soryy708
on 24 Oct 2019
sort of, just reverted behind the option :-) (and avoiding the crash)
ljharb
on 25 Oct 2019
Related issues
AndrewLeedham
路
3Comments
benmosher
路
3Comments
vkrol
路
3Comments
nikopavlica
路
3Comments
sveyret
路
3Comments
Most helpful comment
I'd appreciate this a lot; just fiddled with the
no-cyclerule for a while, only to realize that it just doesn't work for good old regular Node.js projects (it does say so in the docs, but it's not quite obvious).Just had a quick look at
ExportMapmyself, but this doesn't strike me as an easy first contribution :)