Eslint-plugin-import: import/order fails after updating a dependency (redux-saga)

[mastilver]

When using [email protected] everything is fine
But fails when using [email protected]

I think the reason for this to fails is this PR: https://github.com/redux-saga/redux-saga/pull/895

---

Error message:

./userSaga import should occur before import of redux-saga/effects import/order

Code:

import { fork } from 'redux-saga/effects';

import connectionFlow from './userSaga';

[vadimdemedes]

I can confirm this issue is happening to me as well. redux-saga removed the redux-saga/effects.js file, so it freaks out eslint-plugin-import.

[Ephys]

It's probably due to the fact that redux-saga/effects.js was replaced with a package.json file with a relative path as a main field ? (naive guess, currently looking into it).

Edit:
It's because importType.isExternalPath is trying to find
node_modules/redux-saga/effects
Inside the resolved path which actually is
<project_path>/node_modules/redux-saga/es/effects.js
to correctly mark is as an external module

Working on a fix.

[jch254]

Any update on this one? Cheers

[lourd]

Also facing this issue. To add, it's peculiar that the linter reports this as a warning from the import/order plugin, but my editor integration reports it (more appropriately?) as "Unable to resolve path to module 'redux-saga/effects'. (import/no-unresolved). This appears to compound the original issue because it's not possible to workaround the warning while the fix is resolved by simply disabling eslint on the line of the redux-saga/effects import

import { put, call, takeEvery } from 'redux-saga/effects'; // eslint-disable-line  <- doesn't help

It still causes warnings for other imports in the file, namely from import/order.

[artsafin]

As a temporary workaround, one can add redux-saga/effects to import/core-modules.
That will make it at least higher that internal modules in the imports list.

Example:

    settings: {
        'import/core-modules': [
            'redux-saga/effects',
        ]
    },