Erpnext: Uploading different file with same name replaces the file

[djpalshikar]

Steps to reproduce:

• Attach a File with name "file.pdf " to an Item.
• To another item attach a different file with the same name "file.pdf".
• The new file.pdf replaces the old file everywhere

[tundebabzy]

This is expected since the files are being uploaded to the same location. At the same time, each document with an attachment just contains a reference to the location of the file.

However, I think it's a good idea that each document should have its own folder.

[djpalshikar]

Ideally if a same name exists, the system should create a new name for the file. e.g. file-1.pdf

[saurabh6790]

@djpalshikar If file hash is different then the system creates two different records. As per me, if file hash is same then no need to keep separate versions.

[djpalshikar]

@saurabh6790 this is expected behaviour. But it is not what is happening. The system is replacing the files even they have different content.

[djpalshikar]

@saurabh6790 I think I now see why this is happening. Strangely in case of some files the, I have found empty ContentHash, after upload.

[saurabh6790]

Seems an issue! Will check this.

[realvinay]

We are facing the same issue.

We should atleast raise and exception when content hash is empty or file size is 0 and abort the file upload. @shridarpatil can you please send a patch for this.

[realvinay]

We have been able to pin this down to socket io, this issue happens when files are uploaded through socket io, if socket io fails and falls back to http POST hashes and file sizes are always recorded, and this issue never happens.

If we stop socket IO service, this issue doesn't occur.

[shridarpatil]

@realvinay I am working on this will send a PR.