Enzyme: run tests in phantomjs or IE11 (eg browserstack)

[graingert]

To support IE11 and phantomjs I had to add:

        {
          test: /\.(js)$/,
          include: [
            require.resolve('rst-selector-parser/dist/createGenerator'),
            require.resolve('rst-selector-parser/dist/createParser'),
          ],
          loader: 'babel-loader',
          query: JSON.stringify({
            babelrc: false,
            cacheDirectory: true,
            presets: [
              ['env', { targets: { ie: 11 } }],
            ],
            plugins: ['transform-runtime'],
          }),
        },

It would be good to use automated testing to generate and add a list of supported browsers to the enzyme docs

[graingert]

@aweary I'm not saying that rst-selector-parser should transpile for phantom/IE11, just that it should be made obvious somewhere, eg the Karma/Webpack/browserify guides.

[ljharb]

Good catch; in fact it definitely should transpile, and be published as ES5 CJS.

Can this issue be filed on https://github.com/aweary/rst-selector-parser instead?

[graingert]

@ljharb would be good to have Phantom/BrowerStack IE11 run the test suite here to verify that all deps are ES5 CJS.

[graingert]

@ljharb I've added the issue to rst-selector-parser and changed this issue into one about making sure it doesn't happen again.

[aweary]

@ljharb I've published this as 2.2.2, @graingert could you verify the patch release fixes your issue?

[graingert]

@aweary yes, that fixed it.

[lelandrichardson]

actually, i guess w/ the changed title, this should be labeled differently...