Envoy: Formalize policy and removal of exclusionary language from Envoy

Created on 15 Jun 2020  路  2Comments  路  Source: envoyproxy/envoy

We should formalize our policy around exclusionary language in Envoy in the contributor guide. In recent times these have all been commented on in code review in an ad-hoc way, but we should make it explicit in the contributor/review guide. This includes not allowing the following phrases:

  • master/slave (use primary/replica instead)
  • blacklist (use deny list instead)
  • whitelist (use allow list instead)

There are some usages of the above terms in the repo that can be easily cleaned and we can use this as a tracking issue for that. The only API usages that I know of is in the client_ssl_auth filter (white_list) and in the redis filter (master/replica). This can be fixed in the next major version.

We should also decide on whether we want to rename the master branch in the repository to something else like main or trunk. I am in favor of doing this but there will be some temporary churn due to broken links, etc.

I will leave this issue open for community comment to see if there is other language that we should not allow. After that I can update the contribution guide and then we can create tracking issues for cleanup of various existing instances in the project.

cc @envoyproxy/maintainers

arecommunity help wanted

Most helpful comment

Regarding the branch rename I discussed with @caniszczyk and we are going to wait until GitHub/git decide on what the new default is going to be. Then we can align with that. I will get started on the rest of it.

All 2 comments

RocketMQ network filter needs replica change too.

The Kubernetes community are proposing a Naming working group (WG) to address this. See Google Groups post.

Regarding the branch rename I discussed with @caniszczyk and we are going to wait until GitHub/git decide on what the new default is going to be. Then we can align with that. I will get started on the rest of it.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

vpiduri picture vpiduri  路  3Comments

dstrelau picture dstrelau  路  3Comments

jmillikin-stripe picture jmillikin-stripe  路  3Comments

justConfused picture justConfused  路  3Comments

zanes2016 picture zanes2016  路  3Comments