Envoy: tooling: should not need to include from source/

[jmarantz]

Issue Template

Title: One line description

Description:

In the comments in #2921 @mattklein123 noted that it was surprising we were including from "source/". There are two files that do that

./source/common/ratelimit/ratelimit_impl.h:#include "source/common/ratelimit/ratelimit.pb.h"
./test/integration/ratelimit_integration_test.cc:#include "source/common/ratelimit/ratelimit.pb.h"

The latter can just have the reference removed, but ratelimit_impl.h picks up a generated protobuf header from source/ the proto header is definitely needed, and the build system does not pick it up without the source/ prefix. Lots of other protobuf headers are picked up in Envoy without the source/ prefix so we just need to figure out what's different about this one.

[jmarantz]

once this is resolved, source/ can be removed from tools/common.py as a legal header prefix.

[taion809]

It appears that ratelimit.proto exists in source/common/ratelimit instead of the api/ directory. I checked the source/ directory and it is the only protobuf file left which is why you'd notice the discrepancy with other profobuf files.

➜ find ./source -name '*.proto'
./source/common/ratelimit/ratelimit.proto

It looks quite similar to api/envoy/service/ratelimit/v2/rls.proto

[mattklein123]

@taion809 see https://github.com/envoyproxy/envoy/issues/1034

[mk46]

/assign mk46

[repokitteh[bot]]

mk46 is not allowed to assign users.

:cat:

Caused by: a https://github.com/envoyproxy/envoy/issues/3270#issuecomment-734767775 was created by @mk46.

see: more, trace.