Entitas-csharp: [CodeGenerator:] Cache static component index lookup into local var

[sschmid]

Example:

// Before
public void AddPosition(IntVector2 newValue) {
    var component = CreateComponent<PositionComponent>(CoreComponentsLookup.Position);
    component.value = newValue;
    AddComponent(CoreComponentsLookup.Position, component);
}

// After
public void AddPosition(IntVector2 newValue) {
    var index = CoreComponentsLookup.Position;
    var component = CreateComponent<PositionComponent>(index);
    component.value = newValue;
    AddComponent(index, component);
}

[sschmid]

Welcome to the world of micro-optimizations

[T2RKUS]

Is that not the same thing? How is that faster?

[bddckr]

The difference is that the new variable index is used twice. The compiler won't reuse the same variable for that as it doesn't know what CoreComponentsLookup.Position does. It could have side effects for example.

[T2RKUS]

Ooh. Yes I know that. I overlooked the second use of the lookup variable lol. faster by 1 statement. 👍

[WoLfulus]

It'd be cool to see a benchmark and how those changes impact the performance :D

[sschmid]

Feel free to do one :)

[sschmid]

I don't expect any real life gains unless you call those methods reeeeeaaaly often. I'd call it code maintenance...