Enterprise: Locale: it-IT, he-IL and zh-TW datetime doesn't match the short date format

[SofiK]

Describe the bug
We have issues with Italian, Hebrew and Chinese (T) and using datepicker (with time) (We are also using the datetimeformat) and gets getTimeZoneOffset errors when using the datepickers in these languages. I believe the datetime format should match the short date format with both separators and the order.

I do not know if the same issue appear in other locale files.

To Reproduce
Steps to reproduce the behavior:
-

Expected behavior
I think that atleast the datetime should be updated to match the short date format and probably timezone and timezoneLong as well.

I believe that the it-IT locale file should be updated like:
datetime: 'dd/MM/yyyy HH:mm', timezone: 'dd/MM/yyyy HH:mm zz', timezoneLong: 'dd/MM/yyyy HH:mm zzzz'

I believe that the he-IL locale file should be updated like:
datetime: 'd.M.yyyy H:mm', timezone: 'd.M.yyyy H:mm zz', timezoneLong: 'd.M.yyyy H:mm zzzz'

I believe that the zh-TW locale file should be updated like:
datetime: 'yyyy/M/d ah:mm', timezone: 'yyyy/M/d ah:mm zz', timezoneLong: 'yyyy/M/d ah:mm zzzz'

Version

• ids-enterprise: 4.31.1

Screenshots
-

Platform

• Infor Application/Team Name: Homepages
• OS Version: Windows 10
• Browser Name: Chrome
• Browser Version: Version 84.0.4147.135 (Official Build) (64-bit)

Additional context
-

[SofiK]

I noticed that the hr-HR file also looks a bit strange, but its the short date that looks a bit strange.

[CindyMercadoReyes]

This issue is now resolved. Moving this ticket to Done column.

[jonathanamiran]

Hi all,
I'm sorry but the date format for he-IL is incorrect.
It should be similar to European formats, i.e. dd/MM/yyyy and not d.MM.yyyy.

I couldn't find an "official" standard in Israel for Gregorian data format, but Israeli Passport, for instance, is using DD/MM/YYYY format as most Israelis do.

The format was ok in ids-enterprise: v4.31.1, but in v4.33 it's incorrect.
Should I open a new ticket?

Thanks,
Jonathan

[tmcconechy]

@SofiK ok if i change this back as to @jonathanamiran suggestion? I'd take it on his word as someone from that area. For what it is worth though i see this in toLocaleDateString:

var date = new Date().toLocaleDateString('he-IL');
console.log(date);

CLDR has it as https://github.com/unicode-cldr/cldr-dates-full/blob/master/main/he/ca-gregorian.json#L319 as well. But i would definitely take it on your word @jonathanamiran if you are saying thats correct?

[SofiK]

Hi! yes, definetely. But please update the short format, datetime and timezone then so that they are matching (Cause I assume that they should be and we will get issues if they are not).

[tmcconechy]

ok done. can you double check this @jonathanamiran @SofiK

https://github.com/infor-design/enterprise/commit/7615fa3b11dfa1fb274091924ab672f9b14a36f5

[SofiK]

I think it looks correct and after a quick test it seems to be working in Homepages