Enterprise: Multiselect: Select All checkbox should only select visible (filtered) items

[hohnzy]

Is your feature request related to a problem or use case? Please describe.
selectAll option in dropdown component should select only what is currently in the list when filter is applied

Describe the solution you'd like
An option for selectAll to select everything or filtered list.

Describe alternatives you've considered
adding new parameter 'selectFiltered'

Additional context

[EdwardCoyle]

@tmcconechy is this a different feature you think? Should we make this configurable and leave the current behavior as the other option?

[tmcconechy]

I feel like this should be the correct behavior but open to debate. So thinking make an option selectAllFilterOnly or whatever and set it to true by default

[thomas-blackwell]

Any progress on this issue?

[EdwardCoyle]

@thomas-blackwell we have this issue scheduled for our June sprint, starting June 1

[jbrcna]

QA Passed
v4.30.0-dev
https://master-enterprise.demo.design.infor.com/components/multiselect/test-select-all-tags.html

[jbrcna]

just some observation in Uplift Theme

[EdwardCoyle]

@jbrcna Looks like @janahintal raised #4055 for this. I'm addressing in #4056, should be fixed after we merge that

[AsafMeirBarziv]

Can this fix be applied on datagrid too?

[tmcconechy]

I dont think this issue has anything to do with datagrid specifically as it is around the lookup components functionality?

[AsafMeirBarziv]

Yes it does :-(

Please try it yourself in order to be fully convinced

Thanks

Cheers

//Asaf

On Tue, Mar 30, 2021 at 4:33 PM Tim McConechy @.*>
wrote:

I dont think this issue has anything to do with datagrid specifically as
it is around the lookup components functionality?

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/infor-design/enterprise/issues/3845#issuecomment-810248287,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AS5C6WDSJO56YCOWDZZ4XNLTGHHLDANCNFSM4MVPPZIA
.

[tmcconechy]

OK, that would be a separate issue... But i don't get it so maybe need some steps, closest I can think of is:

https://master-enterprise.demo.design.infor.com/components/datagrid/example-multiselect.html

• apply a filter
• select all
• revert the filter
• only what was filtered is selected

This issue relates to lookup and no further work will be done on it here.

[AsafMeirBarziv]

Found it - the bug is related to the fact that the selectCount: true was
not present in the toolbar attribute on the Script, but I had the class="datagrid-result-count">(N Results) explictly included in the
HTML

Do you want me to open a new issue on that?

On Tue, Mar 30, 2021 at 4:41 PM Tim McConechy @.*>
wrote:

OK, that would be a separate issue... But i don't get it so maybe need
some steps, closest I can think of is:

https://master-enterprise.demo.design.infor.com/components/datagrid/example-multiselect.html

• apply a filter
• select all
• revert the filter
• only what was filtered is selected

This issue relates to lookup and no further work will be done on it here.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/infor-design/enterprise/issues/3845#issuecomment-810257416,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AS5C6WBMF7FCPGWTAC4Y6STTGHIKLANCNFSM4MVPPZIA
.

[tmcconechy]

Yes, if you have an issue - this is closed nothing further is being done here.