Enterprise: Hyperlink: Forward/Back Caret looks funny after icon changes

Created on 22 May 2019  路  5Comments  路  Source: infor-design/enterprise

Describe the bug
Should improve this example http://latest-enterprise.demo.design.infor.com/components/hyperlinks/example-index.html

To Reproduce
Steps to reproduce the behavior:

  1. Go to http://latest-enterprise.demo.design.infor.com/components/hyperlinks/example-index.html
  2. Look at the front and back caret icons

Expected behavior
Make them less big and with nicer padding.

Version

  • ids-enterprise: v4.19

Screenshots
Screen Shot 2019-05-22 at 4 11 32 PM

Additional context
https://github.com/infor-design/enterprise-ng/issues/440
Perhaps add the launch icon in as another example and make sure that is styled and can be styled in its own or same link.

[2] type

Most helpful comment

Sounds about right for icon scheme changes which was what I suspected.

All 5 comments

Kind of an older/minor regression? (But added a minor feature to the example). Probably from the icon changes. So not sure priority.

For some timing context:

  • Seems OK in v4.15.0
  • Not totally sure about v4.16.0 (at the time of this posting, the link is down)
  • Seems broken in v4.17.0

Sounds about right for icon scheme changes which was what I suspected.

Here is some markup for the test page for the outcome of this issue i'd like to see


<div class="row">
  <div class="one-half column">
    <a class="hyperlink hide-focus" href="#">Normal Hyperlink</a><p>&nbsp;</p>
    <a class="hyperlink hide-focus" disabled tabindex="-1" href="#">Disabled Hyperlink</a><p>&nbsp;</p>
    <a class="hyperlink show-visited force-visited" href="#">Visited Hyperlink (Forced)</a><p>&nbsp;</p>
    <a class="hyperlink directional hide-focus" href="#">
      <span>Forward Link with Caret</span>
      <svg role="presentation" aria-hidden="true" focusable="false" class="icon">
        <use xlink:href="#icon-caret-right"/>
      </svg>
    </a><p>&nbsp;</p>
    <a href="#" class="hyperlink hide-focus">
      <svg role="presentation" aria-hidden="true" focusable="false" class="icon">
        <use xlink:href="#icon-caret-left"/>
      </svg>
      <span>Forward Link with Caret</span>
    </a><p>&nbsp;</p>
    <a href="#" class="hyperlink hide-focus">
      <span>Launch</span>
      <svg role="presentation" aria-hidden="true" focusable="false" class="icon">
        <use xlink:href="#icon-launch"/>
      </svg>
    </a><p>&nbsp;</p>
    <a href="#" class="hyperlink hide-focus">
      <svg role="presentation" aria-hidden="true" focusable="false" class="icon">
        <use xlink:href="#icon-launch"/>
      </svg>
    </a>
  </div>
</div>

This was fixed.

Was this page helpful?
0 / 5 - 0 ratings