Enhancements: Ability to list/watch for concrete resource assignments via PodResource API

[swatisehgal]

Enhancement Description

• One-line enhancement description (can be used as a release note):
  PodResource API enhancements to add support for cpuid and device topology; additional endpoints to enable watch support and obtain allocatable resource information.

• Kubernetes Enhancement Proposal:

  • https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/2043-pod-resource-concrete-assigments

  • https://github.com/kubernetes/enhancements/pull/2125

• Discussion Links:

1. SIG Node Meeting 20200811: Recording, Slides

2. Slack thread for introducing GetAllocatableResources() endpoint (previously called GetAvailableResources) in podresource API

3. Primary contacts (assignee):
   Alexey Perevalov (@AlexeyPerevalov)
   Francesco Romani (@fromanirh)
4. Responsible SIGs: sig-node
5. Enhancement target (which target equals to which milestone):
   
   
   
   • Alpha release target (x.y)
   
   
   • Beta release target (1.20)
   
   
   • Stable release target (1.20)
   
   

PRs:

1. https://github.com/kubernetes/website/pull/24641

2. https://github.com/kubernetes/kubernetes/pull/93243

3. https://github.com/kubernetes/kubernetes/pull/95734

[swatisehgal]

/sig node

[derekwaynecarr]

thanks @swatisehgal !

I found the original feature tracking issue for this enhancement here https://github.com/kubernetes/enhancements/issues/727

I am going to close this issue, and continue to track the evolution of the feature on this original issue.

Let's update the feature to follow the current KEP process as we meet evolving requirements on its path to GA.

[derekwaynecarr]

temporarily re-opening as I was mistaken on what #727 had actually tracked.

[derekwaynecarr]

I propose we do the following:

• the original issue that tracked the pod resource API was https://github.com/kubernetes/enhancements/issues/606
• we should graduate that issue to stable so we can meet the original goal of disabling accelerator metrics (woot!)
• we should use _this issue_ to handle additive backward compatible changes to the PodResource API
  -- support watch
  -- expose additional resources beyond devices (i.e. cpu, memory, etc.)

I am renaming this issue to the following:

"Ability to list/watch for concrete resource assignments via PodResource API"

Please create a new KEP that references the past work from #606 that enumerates the specific changes for this feature and tracks this issue.

[fromanirh]

I propose we do the following:

* the original issue that tracked the pod resource API was #606

* we should graduate that issue to stable so we can meet the original goal of disabling accelerator metrics (woot!)

* we should use _this issue_ to handle additive backward compatible changes to the PodResource API
  -- support watch
  -- expose additional resources beyond devices (i.e. cpu, memory, etc.)

I am renaming this issue to the following:

"Ability to list/watch for concrete resource assignments via PodResource API"

Please create a new KEP that references the past work from #606 that enumerates the specific changes for this feature and tracks this issue.

We decided to rebase https://github.com/kubernetes/enhancements/pull/1884 and we believe that now PR 1884 fulfills the requirements above.

[kikisdeliveryservice]

Are we all good on the currentl structure of this Issue now? Lmk when it's all set so I can track it, thanks!!

-Kirsten

[derekwaynecarr]

@kikisdeliveryservice the issue is good, we need to update the enhancement slightly.

[kikisdeliveryservice]

@derekwaynecarr This is stable correct? Bc the kep.yaml says so along with the finished graduation criteria? Does the description above just need to be altered?

[swatisehgal]

Does the description above just need to be altered?

Updated the description with 1.20 as the stable release.

[kikisdeliveryservice]

@swatisehgal as a reminder your PR (#1884 ) needs to merge by EOD PST tomorrow October 6th to be included in the 1.20 Release. After that time you will need to request an exception.

[kikisdeliveryservice]

PR merged!! Updating tracking sheet now. :smile:

[kikisdeliveryservice]

Hi @swatisehgal !!

Since your Enhancement is scheduled to be in 1.20, please keep in mind the important upcoming dates:
Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline
Thursday, Nov 12th: Week 9 - Code Freeze

As a reminder, please link all of your k/k PR as well as docs PR to this issue so we can track them.

Thanks and if you need anything, lmk!
Kirsten

[reylejano-rxm]

Hello @AlexeyPerevalov , 1.20 Docs shadow here.

Does this enhancement work planned for 1.20 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against the dev-1.20 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Nov 6th.

Also take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

[AlexeyPerevalov]

Hello, thank you for informing us!

This enhancement requires document changes, I prepared PR
https://github.com/kubernetes/website/pull/24641 with a patch and it's
ready now for review.
Unfortunately I can't set a milestone for PR.

пн, 19 окт. 2020 г. в 18:15, reylejano-rxm [e-mail]:

Hello @AlexeyPerevalov https://github.com/AlexeyPerevalov , 1.20 Docs
shadow here.

Does this enhancement work planned for 1.20 require any new docs or
modification to existing docs?

If so, please follows the steps here
https://kubernetes.io/docs/contribute/new-content/new-features/#open-a-placeholder-pr
to open a PR against the dev-1.20 branch in the k/website repo. This PR
can be just a placeholder at this time and must be created before Nov
6th.

Also take a look at Documenting for a release
https://kubernetes.io/docs/contribute/new-content/new-features/#for-developers-or-other-sig-members
to get yourself familiarize with the docs requirement for the release.

Thank you!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/enhancements/issues/2043#issuecomment-712236005,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAI3VNFJWIPZ6AJPBAM76RTSLRJXJANCNFSM4SAH3B5Q
.

[reylejano-rxm]

@AlexeyPerevalov Thank you and I added milestone 1.20 to PR 24641

[annajung]

Hi @AlexeyPerevalov

Thanks for creating the docs PR!

Please keep in mind the important upcoming dates:

• ~Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline~ DONE!
• Thursday, Nov 12th: Week 9 - Code Freeze
• Monday, Nov 23rd: Week 11 - Docs PR Ready for Review

As a reminder, please link all of your k/k PR as well as docs PR to this issue for the release team to track.

[AlexeyPerevalov]

PR of k/k implementation:

• https://github.com/kubernetes/kubernetes/pull/93243
• https://github.com/kubernetes/kubernetes/pull/95734

PR for documentation:

• https://github.com/kubernetes/website/pull/24641

[kikisdeliveryservice]

Hey @swatisehgal @AlexeyPerevalov

I see that kubernetes/kubernetes#93243 & kubernetes/kubernetes#95734 are still open

Just a reminder that Code Freeze is coming up in 2 days on Thursday, November 12th. All PRs must be merged by that date, otherwise an Exception is required.

Thanks!
Kirsten

[kikisdeliveryservice]

Code freeze is today and while https://github.com/kubernetes/kubernetes/pull/93243 has merged, we're still waiting for final approvals on https://github.com/kubernetes/kubernetes/pull/95734 Spoke to @swatisehgal earlier and she's hoping to secure them, so will check back in later.

[kikisdeliveryservice]

Hi @swatisehgal

Code Freeze is now in effect. You still have 1 unmerged & unapproved PR. If you believe this should be in the 1.20 Release, please file an Exception.

Best,
Kirsten

[swatisehgal]

@kikisdeliveryservice Exception request has been filed, we are now waiting for that to be reviewed :)