Enhancements: Kubelet Feature: Disable AcceleratorUsage Metrics

[RenaudWasTaken]

Enhancement Description

• One-line enhancement description (can be used as a release note): Deprecate the AcceleratorUsageMetrics that kubelet provides
• Kubernetes Enhancement Proposal: (link to kubernetes/enhancements file, if none yet, link to PR): https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/1867-disable-accelerator-usage-metrics
• Primary contact (assignee): @RenaudWasTaken @dashpole
• Responsible SIGs: sig-node
• Enhancement target (which target equals to which milestone):
  
  
  
  • Alpha release target (x.y): 1.19
  
  
  • Beta release target (x.y): 1.20
  
  
  • Stable release target (x.y): 1.22
  
  

/kind feature
/sig node
/stage alpha

[palnabarun]

Hi @RenaudWasTaken :wave: -- the exception request was approved. :100:

I have added the enhancement to the tracking sheet. It is marked At Risk because the implementation PR is yet to be milestoned to v1.19. Please ensure that the PR is appropriately milestoned and gets merged.

Please let us know if you need any help. Thanks! :slightly_smiling_face:

[palnabarun]

/milestone v1.19

[palnabarun]

/stage alpha

[palnabarun]

PS: Updated the issue comment with a link to the KEP.

[savitharaghunathan]

Hi @RenaudWasTaken 👋 , 1.19 Docs Lead here. Do this feature require any new documentation or changes to existing ones?

[RenaudWasTaken]

Hello @savitharaghunathan!

It does require a small paragraph to be added, I'll have a PR ready in an hour!

[RenaudWasTaken]

Done! https://github.com/kubernetes/website/pull/22628

[kikisdeliveryservice]

Hi @RenaudWasTaken

Enhancements Lead here. Just confirming you are intending to work on beta for 1.21 and that no work for 1.20 is planned?

Thanks!
Kirsten

[RenaudWasTaken]

Hello!

After feedback from sig-node during the kep process, we were planning to graduate this feature to beta during the 1.20 release.

I'll be putting up another docs PR as well as a PR to mark this feature beta. No further work should be needed.

Thanks for following up on this!

[kikisdeliveryservice]

Hi @RenaudWasTaken !!

Thanks for the update! Could you please update your kep to reflect beta for 1.20 as well as the description in this issue?

Thanks!
Kirsten

Update: just realized that you already said you'll PR to mark as beta :laughing: sorry!!

[kikisdeliveryservice]

/milestone v1.20

[kikisdeliveryservice]

Hi @RenaudWasTaken

Gentle ping: your kep.yaml should be updated to reflect beta for 1.20. Note: Enhancements Freeze is October 6th.

Thanks,
Kirsten

[RenaudWasTaken]

KEP updated PR is here: https://github.com/kubernetes/enhancements/pull/2036

[RenaudWasTaken]

Thanks for the ping by the way!

[kikisdeliveryservice]

Looks great! Thanks @RenaudWasTaken !

[kikisdeliveryservice]

Hi @RenaudWasTaken

Since your Enhancement is scheduled to be in 1.20, please keep in mind the important upcoming dates:
Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline
Thursday, Nov 12th: Week 9 - Code Freeze

As a reminder, please link all of your k/k PR as well as docs PR to this issue so we can track them.

Thanks! :smile:
Kirsten

[annajung]

Hello @RenaudWasTaken 👋 , 1.20 Docs lead here.

Does this enhancement work planned for 1.20 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.20 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Nov 6th

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

[RenaudWasTaken]

Sorry for the delay!

Does this enhancement work planned for 1.20 require any new docs or modification to existing docs?

No updates to the docs.

PR graduating the feature to beta was merged and no further work is expected in 1.20

[annajung]

Hi @RenaudWasTaken, I believe https://github.com/kubernetes/website/blob/master/content/en/docs/reference/command-line-tools-reference/feature-gates.md needs to be changed to reflect graduation to beta. Could you confirm?

[RenaudWasTaken]

Ah thanks for noticing this, will make the change shortly

[RenaudWasTaken]

Addressed here: https://github.com/kubernetes/website/pull/24755

[kikisdeliveryservice]

Hey @RenaudWasTaken

Work on this for 1.20 is already finished but if that's not the case: Code Freeze is coming up in 2 days on Thursday, November 12th. All PRs must be merged by that date, otherwise an Exception is required.

Thanks
Kirsten

[RenaudWasTaken]

Prs were merged yesterday and today!