Enhancements: Allow users to set a pod’s hostname to its Fully Qualified Domain Name (FQDN)

[javidiaz]

Enhancement Description

• One-line enhancement description (can be used as a release note): Allow users to set a pod’s hostname to its Fully Qualified Domain Name (FQDN)
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/1797-configure-fqdn-as-hostname-for-pods
• Primary contact (assignee): @javidiaz
• Responsible SIGs: sig-node
• Enhancement target (which target equals to which milestone):
  
  
  
  • Alpha release target (x.y): 1.19
  
  
  • Beta release target (x.y): 1.20
  
  
  • Stable release target (x.y): 1.22
  
  
• Docs PR: https://github.com/kubernetes/website/pull/24350
  _Please to keep this description up to date. This will help the Enhancement Team track efficiently the evolution of the enhancement_

[javidiaz]

/sig network
/sig node

[javidiaz]

/sig node

[javidiaz]

/sig network

[javidiaz]

/milestone v1.19

[k8s-ci-robot]

@javidiaz: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[palnabarun]

@javidiaz -- Your exception request was approved. I have updated the tracking sheet accordingly.

[palnabarun]

/milestone v1.19

[palnabarun]

/stage alpha

[palnabarun]

@javidiaz -- Can you please link to all the implementation PR's here - k/k or otherwise? :slightly_smiling_face:

---

The current release schedule is:

• ~Monday, April 13: Week 1 - Release cycle begins~
• ~Tuesday, May 19: Week 6 - Enhancements Freeze~
• Thursday, June 25: Week 11 - Code Freeze
• Thursday, July 9: Week 14 - Docs must be completed and reviewed
• Tuesday, August 4: Week 17 - Kubernetes v1.19.0 released

[zestrells]

Hi @javidiaz - My name is Zachary, 1.19 Docs shadow. Is this enhancement work planned for 1.19 and does it require any new docs (or modifications to existing docs)? If not, can you please update the 1.19 Enhancement Tracker Sheet, or let me know, I can do it for you :)
If docs are required, just a friendly reminder that we are looking for a PR against k/website (branch dev-1.19) due by Friday, June 12, it can just be a placeholder PR at this time. Let me know if you have any questions!

[javidiaz]

@javidiaz -- Can you please link to all the implementation PR's here - k/k or otherwise? 🙂

Thanks @palnabarun, I will put them in here. So far I have one https://github.com/kubernetes/kubernetes/pull/91035

[javidiaz]

Hi @javidiaz - My name is Zachary, 1.19 Docs shadow. Is this enhancement work planned for 1.19 and does it require any new docs (or modifications to existing docs)? If not, can you please update the 1.19 Enhancement Tracker Sheet, or let me know, I can do it for you :)
If docs are required, just a friendly reminder that we are looking for a PR against k/website (branch dev-1.19) due by Friday, June 12, it can just be a placeholder PR at this time. Let me know if you have any questions!

Thanks @zestrells for info. I will need to add some docs.

[javidiaz]

@zestrells I created a PR for docs, how do I update the 1.19 Enhancement Tracker Sheet?

[zestrells]

@javidiaz I can update the tracker sheet. Thank you for the docs :)

[palnabarun]

Thanks @javidiaz for the update on the implementation PR. :+1:

I have updated the update the tracking sheet.

[javidiaz]

@palnabarun I created two new PRs to split logic of original PR, can you please make sure they are tracked and/or marked for the 1.19 milestone. Thanks!
https://github.com/kubernetes/kubernetes/pull/91697 and https://github.com/kubernetes/kubernetes/pull/91699 Actually, just keeping https://github.com/kubernetes/kubernetes/pull/91699

[palnabarun]

Hi @javidiaz -- just wanted to check in about the progress of the enhancement. I have updated the tracking sheet with a link to https://github.com/kubernetes/kubernetes/pull/91699. :+1:

The release timeline has been revised recently, more details of which can be found here.

Please let me know if you have any questions. :slightly_smiling_face:

---

The revised release schedule is:

• Thursday, July 9th: Week 13 - Code Freeze
• Thursday, July 16th: Week 14 - Docs must be completed and reviewed
• Tuesday, August 25th: Week 20 - Kubernetes v1.19.0 released

[palnabarun]

Hi @javidiaz :wave:, I noticed that https://github.com/kubernetes/kubernetes/pull/91699 has been merged. Is there any other PR we should track or is the feature complete?

Thank you. :slightly_smiling_face:

[javidiaz]

Hi @palnabarun , in terms of code that has all needed changes for the feature. We are still working to get the documentation merged. The PR for that is https://github.com/kubernetes/website/pull/21210

[palnabarun]

@javidiaz -- Thank you for the updates. :+1:

[javidiaz]

@palnabarun the docs (kubernetes/website#21210) merged as well, anything else we need to do so our feature makes the 1.19 release? thanks

[palnabarun]

@javidiaz -- Looks like everything is complete to me. :+1: I can confirm for the code changes.

I will defer to @savitharaghunathan @zestrells for the docs. :slightly_smiling_face:

[kikisdeliveryservice]

Hi @javidiaz

Enhancements Lead here. Any plans for this in 1.20?

Thanks!
Kirsten

[javidiaz]

Hi @javidiaz

Enhancements Lead here. Any plans for this in 1.20?

Thanks!
Kirsten

Hi @kikisdeliveryservice , yes, I would like to make it beta and enable it by default. I created PR to promote the feature to beta https://github.com/kubernetes/enhancements/pull/1962.

Thanks,
Javier

[kikisdeliveryservice]

Thanks Javier! I've also updated the description to link directly to the merged KEP. Please keep us posted and link any k/k PRs to this issue as they arise.

Best,
Kirsten

[kikisdeliveryservice]

@javidiaz

As a gentle reminder ~Code Freeze~ Enhancements Freeze is next week October 6th and your outstanding PR https://github.com/kubernetes/enhancements/pull/1962 will need to merge for this to make it in (adding the required graduation criteria). There are some outstanding comments, will you be able to finish in time?

Thanks
Kirsten

[javidiaz]

@javidiaz

As a gentle reminder Code Freeze is next week October 6th and your outstanding PR #1962 will need to merge for this to make it in (adding the required graduation criteria). There are some outstanding comments, will you be able to finish in time?

Thanks
Kirsten

@kikisdeliveryservice Thanks for the reminder! I hope I can make it, I think I just need to add one integration test.

[kikisdeliveryservice]

Oh gosh sorry @javidiaz I meant Enhancements Freeze! And that you need to just update your KEP via #1962

Apologies!

Best,
Kirsten

[javidiaz]

Related PRs
https://github.com/kubernetes/enhancements/pull/2057
https://github.com/kubernetes/kubernetes/pull/95187

[javidiaz]

Two more PR to track:

• https://github.com/kubernetes/kubernetes/pull/95267
• https://github.com/kubernetes/website/pull/24350

[kikisdeliveryservice]

Hi @javidiaz

Since your Enhancement is scheduled to be in 1.20, please keep in mind the important upcoming dates:
Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline <- DONE.
Thursday, Nov 12th: Week 9 - Code Freeze

Also, thank you for linking all of your PRs to this issue!!!!! :smiley_cat:

Thanks!
Kirsten

[javidiaz]

Another PR that removes Alpha from e2e tests' tag. https://github.com/kubernetes/kubernetes/pull/96173

[javidiaz]

Hi @kikisdeliveryservice, I think I have done all work to make this feature Beta in v1.20. Do you know if there is anything else I need to do that I might be missing? Thanks!

[kikisdeliveryservice]

@javidiaz looks like all your related PRs (implementation & docs) have merged

can you confirm that you met the criteria you laid out here:
https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/1797-configure-fqdn-as-hostname-for-pods#alpha---beta-graduation

• Gather feedback from users
• Ensure e2e tests are running in Testgrid and they are stable

[javidiaz]

@javidiaz looks like all your related PRs (implementation & docs) have merged

can you confirm that you met the criteria you laid out here:
https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/1797-configure-fqdn-as-hostname-for-pods#alpha---beta-graduation

* Gather feedback from users

* Ensure e2e tests are running in Testgrid and they are stable

Yes, I think the criteria is met. I also added the additional e2e test requested by the PRR and they show green in test grid (I introduced a small bug in the e2e test, but it got fixed yesterday after my PR got merged)

[kikisdeliveryservice]

Thanks for the update, I saw: https://github.com/kubernetes/kubernetes/pull/96305 which was merged, updating the sheet and you're good to go.

Note: Code Freeze is coming up in 2 days on Thursday, November 12th. All PRs must be merged by that date, otherwise an Exception is required.

Thanks!!
Kirsten