Enhancements: Allow CSI drivers to opt-in to volume ownership change

[gnufied]

Enhancement Description

• One-line enhancement description (can be used as a release note): Allow CSI drivers to opt-in to volume ownership and permission change.
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/1682-csi-driver-skip-permission
• Primary contact (assignee): @huffmanca
• Responsible SIGs: sig-storage
• Enhancement target (which target equals to which milestone):
  
  
  
  • Alpha release target (x.y): 1.19
  
  
  • Beta release target (x.y): 1.20
  
  
  • Stable release target (x.y)
  
  

[gnufied]

/sig storage

[huffmanca]

/assign

[harshanarayana]

Hey there @huffmanca / @gnufied -- 1.19 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating in 1.19?

In order to have this part of the release:

1. The KEP PR must be merged in an implementable state
2. The KEP must have test plans
3. The KEP must have graduation criteria.

The current release schedule is:

• Monday, April 13: Week 1 - Release cycle begins
• Tuesday, May 19: Week 6 - Enhancements Freeze
• Thursday, June 25: Week 11 - Code Freeze
• Thursday, July 9: Week 14 - Docs must be completed and reviewed
• Tuesday, August 4: Week 17 - Kubernetes v1.19.0 released

If you do, I'll add it to the 1.19 tracking sheet (http://bit.ly/k8s-1-19-enhancements). Once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!

[huffmanca]

@harshanarayana ,

It is expected for this enhancement to be included in the 1.19 release. Please go ahead and add it to the tracking sheet, or let me know if there are any issues.

Thank you!

[harshanarayana]

Hey @huffmanca, thanks for following up on this with an update. I have update the tracking sheet accordingly. 🖖

Thanks

[palnabarun]

/stage alpha
/milestone v1.19

[harshanarayana]

Hey @huffmanca , Enhancements shadow for the v1.19 here. Thanks for including the PRR criteria in the KEP 🖖

[harshanarayana]

Hey @huffmanca / @gnufied, Enhancement shadow for the v1.19 release cycle here. Just following up on my earlier update to inform you of the upcoming Enhancement Freeze scheduled on Tuesday, May 19.

I noticed that the KEP is still in flight. As per the requirements, the KEP should be merged and implementable for it to be considered for the release v1.19.

Please feel free to reach out in case if you need any more information.

Thanks, Harsha

[zestrells]

Hi @gnufied - My name is Zachary, 1.19 Docs shadow. Is this enhancement work planned for 1.19 and does it require any new docs (or modifications to existing docs)? If not, can you please update the 1.19 Enhancement Tracker Sheet, or let me know, I can do it for you :)
If docs are required, just a friendly reminder that we are looking for a PR against k/website (branch dev-1.19) due by Friday, June 12, it can just be a placeholder PR at this time. Let me know if you have any questions!

[harshanarayana]

Hey @gnufied, I am with the enhancements team for the v1.19 release cycle as a shadow.

The code freeze deadline for the Enhancement is Thursday, June 25. I am checking in to see if there is any k/k PR that you have already opened for this enhancement and if so, would you be able to point me in the direction of the PR so that the same can be updated in the tracking sheet

Have a wonderful day. 🖖

[zestrells]

Hi @gnufied - Just a reminder that docs placeholder PR against dev-1.19 is due by June 12th. Does this enhancement require any changes to docs? If so, can you update here with a link to the PR once you have it in place? If not, please update the same, so that the tracking sheet can be updated accordingly. Thanks!

[huffmanca]

@zestrells ,

I'll ensure to have a placeholder PR submitted for the documentation changes by the deadline. Thank you for the reminder!

[huffmanca]

@harshanarayana ,

The code change PR is now linked to this issue, and can be accessed at https://github.com/kubernetes/kubernetes/pull/92001 .

[harshanarayana]

@harshanarayana ,

The code change PR is now linked to this issue, and can be accessed at https://github.com/kubernetes/kubernetes/pull/92001 .

Hey @huffmanca, thanks the update. I will update the tracker sheet to indicate the k/k PR.

🖖

[huffmanca]

@zestrells ,

Two PRs have been opened for documentation:

• https://github.com/kubernetes/website/pull/21671 - this includes the feature gate details in the main kubernetes docs
• https://github.com/kubernetes-csi/docs/pull/337 - this includes the actual documentation for the field in the CSI docs

[harshanarayana]

Hi, @huffmanca

This is a follow-up to the communication that went out to k-dev today. There has been a revision to the release schedule of v1.19 as follows.

Thursday, July 9th: Week 13 - Code Freeze
Thursday, July 16th: Week 14 - Docs must be completed and reviewed
Tuesday, August 25th: Week 20 - Kubernetes v1.19.0 released
Thursday, August 27th: Week 20 - Release Retrospective

You can find the revised Schedule in the sig-release Repo

Please let me know if you have any questions. 🖖

[harshanarayana]

Hi @huffmanca,

This is just a follow up to my earlier messages on the upcoming deadlines. The code freeze deadline is Thursday, July 9th EOD PST and I noticed that the k/k PR kubernetes/kubernetes/pull/92001 is still in flight.

For the enhancement to be included into v1.19 this PR needs to be merged before the code freeze deadline.

Please refer to the Exception Process documentation in case if there is a need for one.

[gnufied]

/reopen

[k8s-ci-robot]

@gnufied: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kikisdeliveryservice]

/milestone clear

(removing this enhancement issue from the v1.19 milestone as the milestone is complete)

[kikisdeliveryservice]

Hi @gnufied

Enhancements Lead here. Any plans for this in 1.20?

Thanks!
Kirsten

[gnufied]

This should remain in beta in 1.20, we will try and move this GA in 1.21

[msau42]

@gnufied this feature is currently alpha. Do we want to move it to beta in 1.20?

[gnufied]

@kikisdeliveryservice @msau42 apologies. When I commented I forgot that feature was in alpha.. :( . So yes, we would like to move this to beta in 1.20 and hence this feature should be tracked.

[kikisdeliveryservice]

No problem, thanks for the update!

Enhancements Freeze is October 6th, but everything looks in order for beta in 1.20 for this KEP :smile:

Also updated the description to fix links and add enhancement target

[kikisdeliveryservice]

Hey there @gnufied :wave:

Since your Enhancement is scheduled to be in 1.20, please keep in mind the important upcoming dates:
Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline
Thursday, Nov 12th: Week 9 - Code Freeze

As a reminder, please link all of your k/k PR as well as docs PR to this issue so we can track them.

Thanks!
Kirsten

[eagleusb]

Hello @huffmanca @gnufied :wave:, 1.20 Docs shadow here.

Does this enhancement work planned for 1.20 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.20 branch in the k/website repo.

This PR can be just a placeholder at this time and must be created before Nov 6th

Also take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

[eagleusb]

Hi @huffmanca :wave:

The docs placeholder deadline is almost here.

Please make sure to create a placeholder PR against the dev-1.20 branch in the k/website before the deadline.

Also, please keep in mind the important upcoming dates:

• Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline
• Thursday, Nov 12th: Week 9 - Code Freeze
• Monday, Nov 23rd: Week 11 - Docs PR Ready for Review

As a reminder, please link all of your k/k PR as well as docs PR to this issue for the release team to track.

Thanks !

[huffmanca]

@eagleusb,

https://github.com/kubernetes/website/pull/24916 has been created as the docs placeholder PR.

Let me know if there are any issues!

[kikisdeliveryservice]

Hi @gnufied @huffmanca

Just a reminder that Code Freeze is coming up in 2 days on Thursday, November 12th. All PRs must be merged by that date, otherwise an Exception is required.

I see that kubernetes/kubernetes#95739 is still open. That PR seems to contain the all the requirements laid out in your graduation criteria here: https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/1682-csi-driver-skip-permission#graduation-criteria

Please ensure it's merged by the deadline! :smile:

Best,
Kirsten

[kikisdeliveryservice]

Hi @gnufied & @huffmanca

kubernetes/kubernetes#95739 is still open and has no approvals. Code Freeze is today - do you still intend on getting this into 1.20? Or will you be pushing to 1.21?

Thanks,
Kirsten

[huffmanca]

@kikisdeliveryservice ,

The target is still today. It has been lgtm'd previously, and an api-reviewer is aware of it. Apologies for the tardiness, but we continue to hope that this will be merged today.

[huffmanca]

@kikisdeliveryservice ,

This has been lgtm'd and approved. It should be merged once it passes the tests.

[kikisdeliveryservice]

Thanks for the update!

~Looks like it needs a rebase (and will need another lgtm :frowning_face: )~

This merged :smile: