Enhancements: NetworkPolicies: Introduce a comprehensive CNI validation framework to replace existing network_policy.go validations

[jayunit100]

Enhancement Description

• One-line enhancement description (can be used as a release note):

Introduce a CNI validation framework as a replacement for the network_policy.go E2E suite, and use it to curate easy to understand, high performance, comprehensive NetworkPolicy validations for CNI providers.

• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/blob/master/keps/sig-network/20200204-NetworkPolicy-verification-rearchitecture.md

• Primary contact (assignee):

@jayunit100

• Responsible SIGs:

@kubernetes/sig-network-misc

• Enhancement target (which target equals to which milestone):

[jayunit100]

I think i mislabelled the issue, not an api-change. Updated to sig-network-misc.

[harshanarayana]

Hey there @jayunit100 -- 1.19 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating in 1.19?

In order to have this part of the release:

1. The KEP PR must be merged in an implementable state
2. The KEP must have test plans
3. The KEP must have graduation criteria.

The current release schedule is:

• Monday, April 13: Week 1 - Release cycle begins
• Tuesday, May 19: Week 6 - Enhancements Freeze
• Thursday, June 25: Week 11 - Code Freeze
• Thursday, July 9: Week 14 - Docs must be completed and reviewed
• Tuesday, August 4: Week 17 - Kubernetes v1.19.0 released

If you do, I'll add it to the 1.19 tracking sheet (http://bit.ly/k8s-1-19-enhancements). Once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!

[harshanarayana]

Hey @jayunit100, I'm following up on my previous update on this Enhancement being part of the v1.19 release.

Do you happen to have any update on the possiblity of this being included in the release v1.19?

Thanks again for your time and contributions. 🖖

[jayunit100]

Hi ! Yes wouldlike to have this in 1.19. Thanks @harshanarayana

[harshanarayana]

Hey @jayunit100 Thanks very much for confirming the status. I've updated the tracker accordingly and marking this with proper milestones.

/milestone v1.19

[harshanarayana]

Hey @jayunit100 I was wondering if you can help me with a clarification regarding the graduation criteria with regards to the KEP?

Since the KEP is missing information specific to the k8s versions and this is a test architecting redesign, will the entire specification of the KEP be implemented in v1.19 or part of will be carried over to the coming releases? This will help me mark the stage for the Enhancement accordingly in the tracker.

Regards, Harsha

[harshanarayana]

/stage stable

[jayunit100]

thanks harsha, yup, per our conv yesterday, we'll be able to get this to 1.19, and the current WIP implementation is here https://github.com/vmware-tanzu/antrea/blob/master/hack/netpol/pkg/main/main.go

[zestrells]

Hi @jayunit100 - My name is Zachary, 1.19 Docs shadow. Is this enhancement work planned for 1.19 and does it require any new docs (or modifications to existing docs)? If not, can you please update the 1.19 Enhancement Tracker Sheet, or let me know, I can do it for you :)
If docs are required, just a friendly reminder that we are looking for a PR against k/website (branch dev-1.19) due by Friday, June 12, it can just be a placeholder PR at this time. Let me know if you have any questions!

[harshanarayana]

Hey @jayunit100, I am with the enhancements team for the v1.19 release cycle as a shadow.

The code freeze deadline for the Enhancement is Thursday, June 25. I am checking in to see if there is any k/k PR that you have already opened for this enhancement and if so, would you be able to point me in the direction of the PR so that the same can be updated in the tracking sheet

Have a wonderful day. 🖖

[wojtek-t]

@jayunit100 - can you please

1. transform the KEP to the new format (should be simple, just extracting metadata to kep.yaml: see template: https://github.com/kubernetes/enhancements/tree/master/keps/NNNN-kep-template )
2. fill in PRR questionaire and assign me as PRR approver (I'm taking all network PRRs this cycle)

[zestrells]

Hi @jayunit100 - Just a reminder that docs placeholder PR against dev-1.19 is due by June 12th. Does this enhancement require any changes to docs? If so, can you update here with a link to the PR once you have it in place? If not, please update the same, so that the tracking sheet can be updated accordingly. Thanks!

[harshanarayana]

Hey @jayunit100, Hope things are good.

The code freeze deadline for the Enhancement is Thursday, June 25. So, I am following up on my previous updates about the k/k that needs to be tracked. Can you please point me in the direction of any PR against that which needs to be tracked for this enhancement?

Have a wonderful day. 🖖

[harshanarayana]

Hi, @jayunit100

This is a follow-up to the communication that went out to k-dev today. There has been a revision to the release schedule of v1.19 as follows.

Thursday, July 9th: Week 13 - Code Freeze
Thursday, July 16th: Week 14 - Docs must be completed and reviewed
Tuesday, August 25th: Week 20 - Kubernetes v1.19.0 released
Thursday, August 27th: Week 20 - Release Retrospective

You can find the revised Schedule in the sig-release Repo

Please let me know if you have any questions. 🖖

[jayunit100]

hi folks, i somehow missed this. reading up now.

[jayunit100]

So, the PR is here , it has not been rebased yet https://github.com/kubernetes/kubernetes/pull/91592/files . Im going to sync with a few folks today to see if we will be able to get it in as planned. will sync with jerickar tomorrow as well to confirm all this.

The basic functionality is all set, but want to confirm we can make the timeeline.

[jayunit100]

@wojtek-t , so, with the kep-nnnn thing, are you saying i should file a PR to fix the original kep to match the new format?

[savitharaghunathan]

Hi @jayunit100, 1.19 Docs lead here. Today June 19 is the deadline for docs placeholder PR. Can you provide an update on docs status, please? Thanks!

[jayunit100]

Hi ! It wont need a docs placeholder, from conversation i just hadd with @mrbobbytables ... but i think we will slip this to 1.20 anyways.

[palnabarun]

@jayunit100 -- Thank you for the update. :+1:

Deferring this enhancement to 1.20 and updating the tracking sheet.

/milestone v1.20

[jayunit100]

thanks !

[kikisdeliveryservice]

Hi @jayunit100

Enhancements Lead here, do you still intend to target this for GA in 1.20?

Thanks!
Kirsten

[kikisdeliveryservice]

Hi again @jayunit100

Do you intend for this to make it into 1.20? Enhancements Freeze is October 6th.

Thanks,
Kirsten

[kikisdeliveryservice]

As per: https://github.com/kubernetes/enhancements/pull/1568#pullrequestreview-408261839

Marking this a fully tracked since it's straight to GA, implementable and the KEP is literally about tests.

[jayunit100]

@eth0xFEED ... can follow up in here,

add a goals-2 section

https://github.com/kubernetes/enhancements/blob/master/keps/sig-network/20200204-NetworkPolicy-verification-rearchitecture.md#goals-1

[kikisdeliveryservice]

Hi @jayunit100

Since your Enhancement is scheduled to be in 1.20, please keep in mind the important upcoming dates:
Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline
Thursday, Nov 12th: Week 9 - Code Freeze

As a reminder, please link all of your k/k PRs (which you've been doing, thank you!) as well as docs PRs to this issue so we can track them.

Thanks!
Kirsten

[kcmartin]

Hello @jayunit100 , 1.20 Docs shadow here.

Does this enhancement work planned for 1.20 require any new docs or modification to existing docs?

It looked as if it did not require docs, based on the comments above, but if I'm mistaken, please follow the steps here to open a PR against dev-1.20 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Nov 6th

Also take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

[kikisdeliveryservice]

Hey @jayunit100

I see that kubernetes/kubernetes#91592 is still open but looks like it's almost finished. Just a reminder that Code Freeze is coming up in 2 days on Thursday, November 12th. All PRs must be merged by that date, otherwise an Exception is required.

Thanks,
Kirsten

[jayunit100]

yeah, it appears that its done, and we just need to get the final lgtm on it.

[kikisdeliveryservice]

Hi @jayunit100

I see that your PR has no approvals yet, do you still plan on getting this in today?

Thanks
Kirsten

[jayunit100]

ahhhh, probably not... cc unless @bowei has a block of time to look at it :)

[kikisdeliveryservice]

Hi @jayunit100

Code Freeze is now in effect and your PR does not have sufficient approvals and has not yet merged. If you believe this should be in the 1.20 Release, please file an Exception.

Best,
Kirsten