Enhancements: Streaming Proxy Redirects [DEPRECATED]

[tallclair]

Enhancement Description

• One-line enhancement description (can be used as a release note): Deprecate & remove StreamingProxyRedirects and redirect-container-streaming
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/20191205-container-streaming-requests.md
• Primary contact (assignee): @tallclair
• Responsible SIGs: node, api-machinery
• Enhancement target (which target equals to which milestone):
  
  
  
  • See https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/20191205-container-streaming-requests.md#rollout-plan
  
  

Deprecation plan:

• [x] release 1.18
  
  
  
  1. Mark the --redirect-container-streaming flag as deprecated. Log a warning on use.
  
  
  2. Mark the StreamingProxyRedirects feature as deprecated. Log a warning on use.
  
  
• [x] release 1.19 - no changes
• [x] release 1.20
  
  
  
  1. --redirect-container-streaming can no longer be enabled. If the flag is set, log an error
     
     and continue as though it is unset.
  
  
• [ ] release 1.22 _(previously: 1.21)_
  
  
  
  1. Default StreamingProxyRedirects to disabled. If there is a >= 2 version skew between master
     
     and nodes, and the old nodes were enabling --redirect-container-streaming, this will break
     
     them. In this case, the StreamingProxyRedirects can still be manually enabled.
  
  
• [ ] release 1.24 _(previously: 1.22)_
  
  
  
  1. Remove the --redirect-container-streaming flag.
  
  
  2. Remove the StreamingProxyRedirects feature.
  
  

[tallclair]

/sig node

[palnabarun]

Hi @tallclair, -- 1.19 Enhancements Lead here. I see from the KEP that no work is planned for 1.19. I just wanted to confirm if that is still the case?

Thank you!

[tallclair]

Yep, confirmed. I'll paste the rollout plan here to make raise the visibility. We do have an action coming up in
/milestone v1.20

1. [DONE] release 1.18
   
   
   
   1. Mark the --redirect-container-streaming flag as deprecated. Log a warning on use.
   
   
   2. Mark the StreamingProxyRedirects feature as deprecated. Log a warning on use.
   
   
2. release 1.19 - no changes
3. release 1.20
   
   
   
   1. --redirect-container-streaming can no longer be enabled. If the flag is set, log an error
      
      and continue as though it is unset.
   
   
4. release 1.21 _(extra safe alternative: 1.22)_
   
   
   
   1. Default StreamingProxyRedirects to disabled. If there is a >= 2 version skew between master
      
      and nodes, and the old nodes were enabling --redirect-container-streaming, this will break
      
      them. In this case, the StreamingProxyRedirects can still be manually enabled.
   
   
5. release 1.22 _(extra safe alternative: 1.24)_
   
   
   
   1. Remove the --redirect-container-streaming flag.
   
   
   2. Remove the StreamingProxyRedirects feature.
   
   

[palnabarun]

@tallclair Thank you for the update. Also, a big shoutout for putting put all future plans in the issue as a comment. :heavy_plus_sign:

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[palnabarun]

/remove-lifecycle stale

[kikisdeliveryservice]

Hi @tallclair

Enhancements Lead here, can you confirm whether this will have work in 1.20? (alpha/beta/GA?)

Thanks!
Kirsten

[tallclair]

Yes, this has some work targeting v1.20. I hoisted the rollout plan to the issue description.

[kikisdeliveryservice]

So I noticed that this is a Deprecation rollout, so I'm wondering how to track this against alpha/beta/stable.. Maybe this could be beta? But I feel like I'm forcing it :thinking:

WDYT @tallclair @palnabarun ?

[tallclair]

Yeah, I don't think alpha/beta/ga makes sense here. I don't know enough about the feature tracking process to know what the alternatives are.

[kikisdeliveryservice]

@tallclair let me check on this and i'll report back!

[kikisdeliveryservice]

After discussing, we agree it's important to track & publicize, so we made a new status so that we can track this as a _drumroll_ deprecation! :smile:

[kikisdeliveryservice]

Hey @tallclair !

Since your Enhancement is scheduled to be in 1.20, please keep in mind the important upcoming dates:
Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline <--- Pretty sure you'll want to do this one for the deprecation
Thursday, Nov 12th: Week 9 - Code Freeze

As a reminder, please link all of your k/k PR as well as docs PRs to this issue so we can track them.

Thanks!
Kirsten :smiley:

[reylejano-rxm]

Hello @tallclair , 1.20 Docs shadow here.

Does this enhancement work planned for 1.20 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against the dev-1.20 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Nov 6th.

Also take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

[tallclair]

No docs changes needed for this one.

[annajung]

Hi @tallclair

Please keep in mind the important upcoming dates:

• ~Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline~ Docs Not Required
• Thursday, Nov 12th: Week 9 - Code Freeze
• ~Monday, Nov 23rd: Week 11 - Docs PR Ready for Review~ Docs Not Required

As a reminder, please link all of your k/k PR as well as docs PR to this issue for the release team to track.

[kikisdeliveryservice]

Hi @tallclair

Looks like kubernetes/kubernetes#95935 is merged and that was the only PR for 1.20 - correct?

As a note: Code Freeze is coming up in 2 days on Thursday, November 12th. All PRs must be merged by that date, otherwise an Exception is required.

Thanks!
Kirsten

[tallclair]

Correct.