Enhancements: Adding AppProtocol to Services and Endpoints

[robscott]

Enhancement Description

• AppProtocol is a new optional field on ports in Endpoints and Services
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/tree/master/keps/sig-network/1507-app-protocol
• Primary contact (assignee): @robscott
• Responsible SIGs: network
• Enhancement target (which target equals to which milestone):
  
  
  
  • Alpha release target (1.18)
  
  
  • Beta release target (1.19)
  
  
  • GA release target (1.20)
  
  

[robscott]

/sig network

[jeremyrickard]

Hey @robscott I'm adding this to the v1.18 milestone per the issue description up above. Let me know if this is not correct.

[jeremyrickard]

/milestone v1.18

[jeremyrickard]

/stage stable

[jeremyrickard]

@robscott sorry for not catching this earlier, but the KEP for adding this field doesn't include any test plans. Could you please update the KEP and submit an Exception Request

[jeremyrickard]

Exception request was approved.

/milestone v1.18

[VineethReddy02]

Hello, @robscott, I'm 1.18 docs lead.
Does this enhancement work planned for 1.18 require any new docs (or modifications to existing docs)? If not, can you please update the 1.18 Enhancement Tracker Sheet (or let me know and I'll do so)
If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.18) due by Friday, Feb 28th, it can just be a placeholder PR at this time. Let me know if you have any questions!

[robscott]

Hey @VineethReddy02, this will require some small additions to the Service and Endpoints docs. I'll have placeholder docs PR in place by Feb 28.

[kikisdeliveryservice]

Hi @robscott !

As a reminder that the Code Freeze is Thursday 5th March. Can you please link all the k/k PRs or any other PRs that should be tracked for this enhancement?

Thanks!
The 1.18 Enhancements Team

[robscott]

Hey @kikisdeliveryservice thanks for checking in! I'm hoping to have a PR ready in the next week or so, I'll make sure it's linked when I create it.

[VineethReddy02]

Hello @robscott
We are close to the docs placeholder PR deadline against the dev-1.18 branch. Having a placeholder PR in place will definitely help us in tracking enhancements much better.

Thanks! :)

[robscott]

Hey @VineethReddy02, thanks for the reminder! I'll work on getting that in soon.

[jeremyrickard]

Hey @robscott,

How are you doing on this enhancement? Have you opened a PR for this yet?

[robscott]

Hey @jeremyrickard, I've got a branch that's ~90% there, hope to have a PR in shortly.

[robscott]

@jeremyrickard I have a docs PR ready for review now: https://github.com/kubernetes/website/pull/19317

[kikisdeliveryservice]

Hi @robscott !

As a reminder, please open a PR to update your KEP status to implemented.

Thanks

The 1.18 Enhancements Team

[palnabarun]

@robscott Ping. Can you please mark the KEP status as implemented? :slightly_smiling_face:

[robscott]

@palnabarun @kikisdeliveryservice Sorry for the delay here! I've added a PR that will update the KEP to reflect the additional steps required for this field to reach GA: https://github.com/kubernetes/enhancements/pull/1676. For now I've left the KEP in an implementable state, is that the right state for a KEP that is partially implemented/in progress?

[palnabarun]

@robscott Sorry for the confusion here. KEP's in-progress should remain in implementable state.

This enhancement issue was mistakenly attributed as stage/stable.

/remove-stage stable

On an added note, do you plan to graduate this to beta in 1.19?

[robscott]

No worries, initial I'd thought this could be done in a single release but I've learned that adding fields to stable APIs still takes the full alpha-beta-GA processes. Beta graduation for 1.19 is complete here: https://github.com/kubernetes/kubernetes/pull/90023

[palnabarun]

@robscott That is awesome news. Is that the only PR planning for this release? Will this also require docs?

[robscott]

Yep, that's the only implementation PR needed, will need a tiny update to docs as well.

[palnabarun]

Cool! The 1.19 docs team will ping here whenever docs are due.

For now, tracking this enhancement

/stage beta

[palnabarun]

/milestone v1.19

[savitharaghunathan]

Hi @robscott - I am Savitha, 1.19 Docs lead. I see that you have mentioned about minor changes needed for docs.
Just a friendly reminder we're looking for a PR against k/website (branch dev-1.19) due by Friday, June 12, it can just be a placeholder PR at this time. Let me know if you have any questions!

[robscott]

Hey @savitharaghunathan, thanks for checking in! This feature will need some small docs updates. I'll make sure we get a placeholder PR in place by June 12.

[msedzins]

Hi @robscott, enhancement shadow here -- Do you have any working PR other than https://github.com/kubernetes/kubernetes/pull/90023 ? If yes, can you please link them here? :slightly_smiling_face:

---

The current release schedule is:

• ~Monday, April 13: Week 1 - Release cycle begins~
• ~Tuesday, May 19: Week 6 - Enhancements Freeze~
• Thursday, June 25: Week 11 - Code Freeze
• Thursday, July 9: Week 14 - Docs must be completed and reviewed
• Tuesday, August 4: Week 17 - Kubernetes v1.19.0 released

[robscott]

Hey @msedzins, thanks for checking in! This feature is code complete for 1.19, just needs docs updates.

[wojtek-t]

@robscott - can you please

1. transform the KEP to the new format (should be simple, just extracting metadata to kep.yaml: see template: https://github.com/kubernetes/enhancements/tree/master/keps/NNNN-kep-template )
2. fill in PRR questionaire and assign me as PRR approver (I'm taking all network PRRs this cycle)

[msedzins]

Thanks @robscott!

[savitharaghunathan]

Hi @robscott, just a reminder that placeholder PR is due by June 12th. Once you have it in place, please provide a link to the PR. If you already have one against dev-1.19 branch, can you link the PR here?

[robscott]

Hey @savitharaghunathan, thanks for checking in! I've created a docs PR for this feature now: https://github.com/kubernetes/website/pull/21588

/assign

[msedzins]

Hi, @robscott

This is a follow-up to the communication that went out to k-dev today. There has been a revision to the release schedule of v1.19 as follows.

Thursday, July 9th: Week 13 - Code Freeze
Thursday, July 16th: Week 14 - Docs must be completed and reviewed
Tuesday, August 25th: Week 20 - Kubernetes v1.19.0 released
Thursday, August 27th: Week 20 - Release Retrospective

You can find the revised Schedule in the sig-release Repo

Please let me know if you have any questions. 🖖

[msedzins]

Hi @robscott , from what I can see this enhancement is Code complete so it's ready for Code freeze deadline which happens July 9th.
Please let me know if you think otherwise and there are any risks for that enhancement to be included in v.1.19.

[kikisdeliveryservice]

/milestone clear

(removing this enhancement issue from the v1.19 milestone as the milestone is complete)

[kikisdeliveryservice]

Hi @robscott

Enhancements Lead here. Any plans for this in 1.20?

Thanks!
Kirsten

[kikisdeliveryservice]

H there @robscott

Just circling back around on this, I see that it went beta in 1.19. Are you planning to go stable in 1.20?

If so, Enhancements Freeze is on October 6th and the KEP would need to be updated to include Test Plans & Graduation Criteria for GA. This KEP is also using the older format that is missing the Production Readiness Review Questionnaire, etc... so if you could please update that would be awesome (see for ref https://github.com/kubernetes/enhancements/tree/master/keps/NNNN-kep-template)

Thanks!
Kirsten

[robscott]

Sorry I missed the initial ping! This is a super tiny KEP - just adding an API field that can be set and consumed by others, no associated logic. I think all that's involved in 1.20 is graduating to GA. I'll update the KEP to include test plans & graduation criteria though I don't think there will be much for either.

[kikisdeliveryservice]

I'll update the KEP to include test plans & graduation criteria though I don't think there will be much for either.

@robscott Gentle ping that this needs to be done and merged by Enhancements Freeze, October 6th.

Also if you could update to the new format, that would be great.

[robscott]

Hey @kikisdeliveryservice, I've created a PR to update the KEP structure and add graduation criteria for GA: https://github.com/kubernetes/enhancements/pull/2034.

[kikisdeliveryservice]

Awesome PR #2034 looks good now (has the test plans and graduation criteria). Just needs to merge by October 6th :+1:

[kikisdeliveryservice]

Hi @robscott as a reminder your PR (#2034 ) needs to merge by EOD PST tomorrow October 6th to be included in the 1.20 Release. After that time you will need to request an exception.

[kikisdeliveryservice]

2034 merged!

[kikisdeliveryservice]

Since your Enhancement is scheduled to be in 1.20, please keep in mind the important upcoming dates:
Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline
Thursday, Nov 12th: Week 9 - Code Freeze

As a reminder, please link all of your k/k PR as well as docs PR (you already did this :smile: ) to this issue so we can track them.

Thanks!
Kirsten

[kcmartin]

Hello @robscott , 1.20 Docs shadow here.

Does this enhancement work planned for 1.20 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.20 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Nov 6th

Also take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

[kcmartin]

Hi @robscott

Docs shadow here -- we are not tracking any docs for this enhancement -- do you plan any docs for the 1.20 release? All I see is the docs PR for the 1.19 release --(Updating AppProtocol docs for 1.19 release kubernetes/website#21588).

Please let us know your plans as soon as possilble, thanks!

[robscott]

@kcmartin Just created a docs PR here: https://github.com/kubernetes/website/pull/24933

[kikisdeliveryservice]

Hey @robscott :smile:

kubernetes/kubernetes#96327 is actively being worked on so just a reminder that Code Freeze is coming up in 2 days on Thursday, November 12th. All PRs must be merged by that date, otherwise an Exception is required.

Thanks,
Kirsten

[robscott]

@kikisdeliveryservice Thanks for the reminder. I just need one final LGTM on that PR (just had to fix a failing test after the first LGTM + approval). I think this is still on track for getting in on Thursday.

[kikisdeliveryservice]

@robscott It looks like https://github.com/kubernetes/kubernetes/pull/96327 needs a final review on the last push for days now. Do you plan on getting this in today still?

[kikisdeliveryservice]

As an update: https://github.com/kubernetes/kubernetes/pull/96327 is fully approved now & waiting to merge :smile:

[kikisdeliveryservice]

Hey @robscott looks like the above merged!

Just to close it out can you confirm this meeting the grad criteria: "ServiceAppProtocol has been enabled by default for at least 1 minor release."

And also meets the test plan: https://github.com/kubernetes/enhancements/tree/master/keps/sig-network/1507-app-protocol#test-plan

It looks like test plan was implemented earlier, right?: https://github.com/kubernetes/kubernetes/pull/88503/files

[robscott]

@kikisdeliveryservice Thanks for checking in! You're right that the test plan was implemented earlier and the feature gate was graduated to beta (and on by default) in 1.19. Tests were previously added to the EndpointSlice controller as well as the Endpoints controller.

[kikisdeliveryservice]

Thanks for answering my questions. Updating sheet now. Congrats! :fireworks: