Enhancements: Graduate Ingress to V1

[robscott]

• One-line enhancement description: Graduate Ingress to V1
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/blob/master/keps/sig-network/20190125-ingress-api-group.md
• Primary contact: @robscott
• Responsible SIGs: sig-network
• Enhancement target:
  
  
  
  • Beta updates target (1.18)
  
  
  • Stable release target (1.19)
  
  

/sig network
/assign

[robscott]

/cc @bowei

[kikisdeliveryservice]

/milestone v1.18

[cmluciano]

/assign

[VineethReddy02]

Hello, @robscott, I'm 1.18 docs lead.
Does this enhancement work planned for 1.18 require any new docs (or modifications to existing docs)? If not, can you please update the 1.18 Enhancement Tracker Sheet (or let me know and I'll do so)
If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.18) due by Friday, Feb 28th, it can just be a placeholder PR at this time. Let me know if you have any questions!

[robscott]

Hey @VineethReddy02, this will require some additions to the Ingress docs. I'll have placeholder docs PR in place by Feb 28.

[kikisdeliveryservice]

Hi @robscott @cmluciano !

As a reminder that the Code Freeze is Thursday 5th March. Can you please link all the k/k PRs or any other PRs that should be tracked for this enhancement?

Thanks!
The 1.18 Enhancements Team

[cmluciano]

Hi we have a few that are being reviewed in a different branch that will be combined into a large PR on k/k.

• [x] [defaultBackend](https://github.com/kubernetes/kubernetes/pull/80179)
• [x] [pathType](https://github.com/cmluciano/kubernetes/pull/2)
• [x] [IngressClass](https://github.com/cmluciano/kubernetes/pull/3)
• [x] HostnameWildcard - pending

Rollup PR https://github.com/kubernetes/kubernetes/pull/88041

[VineethReddy02]

Hello @robscott
We are close to the docs placeholder PR deadline against the dev-1.18 branch. Having a placeholder PR in place will definitely help us in tracking enhancements much better.

Thanks! :)

[cmluciano]

@VineethReddy02 I'll be starting the docs today and will link the placeholder PR here.

[jeremyrickard]

@cmluciano @robscott

Reminder, we are getting close to code freeze on 05 March 2020. It looks like you still have some open PRs fort his. Are you confident these will get merged by code freeze?

[robscott]

Hey @jeremyrickard, we are limiting the scope of what we'll be part of 1.18 (staying at v1beta1 until 1.19), but we are confident that we'll get what we've committed to in.

[kikisdeliveryservice]

Hi @robscott can you update the first message of this enhancement to indicate that 1.18 is beta and 1.19 is the intended stable?

[robscott]

@kikisdeliveryservice Just updated, thanks for catching that!

[kikisdeliveryservice]

Thank you, @robscott ! :)

[palnabarun]

/milestone clear

(removing this from the v1.18 milestone as that is complete)

[cmluciano]

@palnabarun Please add this to tracked/yes for 1.19

[palnabarun]

@cmluciano Just confirming, is this enhancement graduating to Beta or Stable in 1.19?

[cmluciano]

Stable for 1.19

[kikisdeliveryservice]

/milestone v1.19

[savitharaghunathan]

Hi @robscott @cmluciano - I am Savitha, 1.19 Docs lead. Does this enhancement work planned for 1.19 require any new docs (or modifications to existing docs)? If not, can you please update the 1.19 Enhancement Tracker Sheet, or let me know, I can do it for you :)
If docs are required, just a friendly reminder we're looking for a PR against k/website (branch dev-1.19) due by Friday, June 12, it can just be a placeholder PR at this time. Let me know if you have any questions!

[robscott]

Hey @savitharaghunathan, thanks for checking in! This feature will need some docs updates. I'll make sure we get a placeholder PR in place by June 12.

[savitharaghunathan]

Thank you for the update, @robscott :)

[wojtek-t]

@robscott @bowei - can you please

1. transform the KEP to the new format (should be simple, just extracting metadata to kep.yaml: see template: https://github.com/kubernetes/enhancements/tree/master/keps/NNNN-kep-template )
2. fill in PRR questionaire and assign me as PRR approver (I'm taking all network PRRs this cycle)

[cmluciano]

@robscott I can work on this today and carry over the timeline updates from a WIP PR.

[kikisdeliveryservice]

Hi @robscott

As a reminder that the Code Freeze is June 25th. Can you please link all the k/k PRs or any other PRs that should be tracked for this enhancement? I see that 88587 merged in March, do you anticipate needing other PRs to finish this enhancement?

Thanks!
The 1.19 Enhancements Team

[cmluciano]

@kikisdeliveryservice Yes we still need the following PRs merged:

• [x] API changes kubernetes/kubernetes#89778
• [x] kubectl changes kubernetes/kubernetes#91268
• [x] CRUD e2e tests for Ingress suitable for conformance promotion (WIP)
• [x] CRUD e2e tests for IngressClass suitable for conformance promotion (WIP)

we also have graduation criteria updated in #1826

[savitharaghunathan]

Hi @robscott, just a reminder that placeholder PR is due by June 12th. Once you have it in place, please provide a link to the PR. If you already have one against dev-1.19 branch, can you link the PR here?

[robscott]

Hey @savitharaghunathan, thanks for the reminder! I've added a docs PR for this feature here: https://github.com/kubernetes/website/pull/21590

[kikisdeliveryservice]

Hi @robscott !

To follow-up on the email sent to k-dev today, I wanted to let you know that Code Freeze has been extended to Thursday, July 9th. You can see the revised schedule here: https://github.com/kubernetes/sig-release/tree/master/releases/release-1.19

We expect all PRs to be merged by that time. Please let me know if you have any questions. 😄

Best,
Kirsten

[kikisdeliveryservice]

@kikisdeliveryservice Yes we still need the following PRs merged:

* [x]  API changes [kubernetes/kubernetes#89778](https://github.com/kubernetes/kubernetes/pull/89778)

* [x]  kubectl changes [kubernetes/kubernetes#91268](https://github.com/kubernetes/kubernetes/pull/91268)

* [x]  CRUD e2e tests for Ingress suitable for conformance promotion (WIP)

* [x]  CRUD e2e tests for IngressClass suitable for conformance promotion (WIP)

we also have graduation criteria updated in #1826

Looks like this is now code complete - all 4 PRs have merged.
Awesome work @cmluciano !

[cmluciano]

Thanks @kikisdeliveryservice . Yes we are code complete, the only thing left to merge are the docs under kubernetes/website#21590 .

[kikisdeliveryservice]

Hi @robscott @cmluciano !

Enhancements lead here. Everything was completed for stable in 1.19. One last thing can you please update the KEP and mark it as implemented?

After that's merged and done we can close this issue.

Thanks and congrats!!
Kirsten

[robscott]

Hey @kikisdeliveryservice, sorry we missed this! It looks like this KEP already has the status set to implemented, do we need to update anything else? https://github.com/kubernetes/enhancements/blob/master/keps/sig-network/1453-ingress-api/kep.yaml#L9

[kikisdeliveryservice]

Nope! Feel free to close this issue!