Enhancements: PV Health Monitor

[xing-yang]

Enhancement Description

• One-line enhancement description (can be used as a release note):

Provide a PV health monitor to watch the health status of volumes and mark it if a PV becomes unhealthy.

• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/pull/1077
• Primary contact (assignee): @xing-yang @NickrenREN
• Responsible SIGs: sig-storage
• Reviewers:
  
  
  
  • @msau42
  
  
  • @saad-ali
  
  
• Approvers:
  
  
  
  • @msau42
  
  
  • @saad-ali
  
  
• Enhancement target (which target equals to which milestone):
  
  
  
  • Alpha release target (1.19)
  
  
  • Beta release target (1.20)
  
  
  • Stable release target (1.21)
  
  

[xing-yang]

/sig storage

[xing-yang]

/kind feature

[xing-yang]

/assign @xing-yang

[xing-yang]

/assign @NickrenREN

[xing-yang]

/milestone v1.18

[k8s-ci-robot]

@xing-yang: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[xing-yang]

/stage alpha

[xing-yang]

Hi @jeremyrickard, can you help add this feature to the milestone? We are targeting Alpha in 1.18. Thanks!

[jeremyrickard]

Hey there @xing-yang,

Checking in to see if you're still on track for 1.18? It looks like the KEP still hasn't been merged. As a reminder, that will need to occur before the Enhancement Freeze (end of day, Pacific Time, on January 28th).

Thanks!!

[xing-yang]

@jeremyrickard Yes, we are still trying to get it merged by 1/28. Thanks!

[jeremyrickard]

@xing-yang congrats on getting the KEP merged! Updated you to tracked in the sheet!

[xing-yang]

Thanks @jeremyrickard !

[kikisdeliveryservice]

/milestone v1.18

[VineethReddy02]

Hello, @xing-yang, I'm 1.18 docs lead.
Does this enhancement work planned for 1.18 require any new docs (or modifications to existing docs)? If not, can you please update the 1.18 Enhancement Tracker Sheet (or let me know and I'll do so)
If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.18) due by Friday, Feb 28th, it can just be a placeholder PR at this time. Let me know if you have any questions!

[xing-yang]

Hi @VineethReddy02, I'll submit a doc PR placeholder soon. Thanks!

[kikisdeliveryservice]

Hi @xing-yang !

As a reminder that the Code Freeze is Thursday 5th March. Can you please link all the k/k PRs or any other PRs that should be tracked for this enhancement when available?

Thanks!
The 1.18 Enhancements Team

[NickrenREN]

Hi, @kikisdeliveryservice ,
We have started coding for this, but this is mostly out of tree(out of k8s core repo). So we probably do not need to follow the release timeline strictly.
But of course, if we send out the PRs, we will link them here.
Thanks

[xing-yang]

CSI Spec PR is submitted here: https://github.com/container-storage-interface/spec/pull/415

[xing-yang]

Hi @VineethReddy02, I think the doc for this feature will be in kubernetes-csi/docs repo, not in kubernetes website repo. Can you please remove the doc requirement for this feature from the tracking sheet? Thanks!

[kikisdeliveryservice]

/milestone clear

[kikisdeliveryservice]

/tracked no

[xing-yang]

Hi @kikisdeliveryservice, why did you remove this feature from the tracking sheet? I was only asking to remove the "doc requirement". Thanks.

[kikisdeliveryservice]

/milestone v1.18

[kikisdeliveryservice]

As a reminder code freeze is tomorrow for 1.18 and all PRs should be merged by then.

-Enhancements Team

[xing-yang]

@kikisdeliveryservice The CSI spec PR is not merged yet, but since it is out-of-tree, we will continue to work on it. You can go ahead and remove this feature from 1.18 milestone tracker. Thanks!

[kikisdeliveryservice]

/milestone clear

[xing-yang]

WIP PR: https://github.com/kubernetes-csi/external-health-monitor/pull/3

[xing-yang]

CSI spec PR is merged. We are targeting this for 1.19.

Can someone from the release team add this to v1.19 milestone?
@kikisdeliveryservice @jeremyrickard

[xing-yang]

/tracked yes

[msedzins]

Hey there @xing-yang , @NickrenREN -- 1.19 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating in 1.19?

In order to have this part of the release:

1. The KEP PR must be merged in an implementable state
2. The KEP must have test plans
3. The KEP must have graduation criteria.

The current release schedule is:

• Monday, April 13: Week 1 - Release cycle begins
• Tuesday, May 19: Week 6 - Enhancements Freeze
• Thursday, June 25: Week 11 - Code Freeze
• Thursday, July 9: Week 14 - Docs must be completed and reviewed
• Tuesday, August 4: Week 17 - Kubernetes v1.19.0 released

If you do, I'll add it to the 1.19 tracking sheet (http://bit.ly/k8s-1-19-enhancements). Once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!

[xing-yang]

Hi @msedzins, we are targeting alpha in 1.19. Thanks!

[msedzins]

Awesome, thank you! I'll go ahead and add it to the tracking sheet :)

[msedzins]

@xing-yang please make sure you have graduation criteria in KEP for Alpha.

Regards,
Mirek

[xing-yang]

@msedzins, will do. Thanks!

[msedzins]

/milestone v1.19

[msedzins]

Hi @xing-yang ,

Note that recently the KEP format has changed.

1620 merged recently, adding production readiness review questions to the KEP template. Please take this opportunity to reformat your KEP and also answer the questions add to the template in that PR.

Also please remember about graduation criteria. I still can't see the criteria for zero state to alfa.

Thanks!

[xing-yang]

Hi @msedzins, thanks for the reminder! Yes, I have an PR opened for this: https://github.com/kubernetes/enhancements/pull/1740/files

[xing-yang]

Hi @msedzins, the updated KEP is merged. Can you check it? https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/1432-volume-health-monitor

[palnabarun]

@xing-yang -- The KEP looks perfect. :slightly_smiling_face:

We really appreciate the effort taken to update the KEP to the new format and answering the PRR questions. :+1:

[xing-yang]

Thanks @palnabarun! :)

[mikejoh]

Hello, @xing-yang ! :wave: I'm one of the v1.19 Docs shadows. Does this enhancement work planned for v1.19 require any new docs (or modifications to existing docs)?

This is a friendly reminder that we're looking for a PR against kubernetes/website (branch dev-1.19) due by Friday, June 12, it can just be a placeholder PR at this time. Let me know if you have any questions!

Regards,
Mikael.

[msedzins]

Hi @xing-yang, @NickrenREN enhancement shadow here -- Can you please link to all the implementation PR's here - k/k or otherwise? :slightly_smiling_face:

---

The current release schedule is:

• ~Monday, April 13: Week 1 - Release cycle begins~
• ~Tuesday, May 19: Week 6 - Enhancements Freeze~
• Thursday, June 25: Week 11 - Code Freeze
• Thursday, July 9: Week 14 - Docs must be completed and reviewed
• Tuesday, August 4: Week 17 - Kubernetes v1.19.0 released

[xing-yang]

PR is submitted here: https://github.com/kubernetes-csi/external-health-monitor/pull/3

[msedzins]

Thank you very much @xing-yang

[xing-yang]

Hi @mikejoh, this does not need a doc change. Thanks.

[msedzins]

Hi, @xing-yang

This is a follow-up to the communication that went out to k-dev today. There has been a revision to the release schedule of v1.19 as follows.

Thursday, July 9th: Week 13 - Code Freeze
Thursday, July 16th: Week 14 - Docs must be completed and reviewed
Tuesday, August 25th: Week 20 - Kubernetes v1.19.0 released
Thursday, August 27th: Week 20 - Release Retrospective

You can find the revised Schedule in the sig-release Repo

Please let me know if you have any questions. 🖖

[xing-yang]

Thanks @msedzins for the updated schedule!

[msedzins]

Hi @xing-yang , I've noticed that PR for that enhancement is still open .

Code freeze deadline is Thursday, July 9th: Week 13

Please let me know if for any reason you can see the risk of not including this enhancement as part of v.1.19 release.

Thank you and keep my fingers crossed!

[xing-yang]

Thanks @msedzins for the reminder! That PR is out-of-tree so we can get it merged after the 7/9 deadline. We are getting very close for it to be merged.

[msedzins]

Thank you @xing-yang for letting me know. I will tag this enhancement as "out-of-tree" and drop it from the tracking spreadsheet (as no code is landing in k/k)

[xing-yang]

@msedzins PR is still in a kubernetes csi repo though. We still want to track this with 1.19 release as the feature will become available before 1.19 release.

[msedzins]

just for the record: there was a discussion about this on sig-release channel:
https://kubernetes.slack.com/archives/C2C40FMNF/p1593710853239400

There's no need to track this kind of enhancements by the Release Team.

[kikisdeliveryservice]

/milestone clear

(removing this enhancement issue from the v1.19 milestone as the milestone is complete)

[kikisdeliveryservice]

Hi @xing-yang

Enhancements Lead here. Any plans for in-tree work on this in 1.20?

Thanks!
Kirsten

[xing-yang]

Hi @kikisdeliveryservice,

I think we'll keep it in Alpha in 1.20 while working on some improvements.

Thanks!
Xing