Enhancements: Implement RuntimeClass on Windows

[PatrickLang]

Enhancement Description

• One-line enhancement description (can be used as a release note): Use RuntimeClass and labels to support multiple Windows versions in the same cluster, and same node with Hyper-V isolation
• Kubernetes Enhancement Proposal:https://github.com/kubernetes/enhancements/blob/master/keps/sig-windows/windows-runtimeclass-support.md
• Primary contact (assignee): @PatrickLang
• Responsible SIGs: SIG-Windows, SIG-Node
• Enhancement target (which target equals to which milestone):
  
  
  
  • Alpha release target (1.19)
  
  
  • Beta release target (TBD)
  
  
  • Stable release target (TBD)
  
  

This is closely related to https://github.com/kubernetes/enhancements/issues/1001 but covers some much more specific use cases.

PRs

• [ ] https://github.com/kubernetes/kubernetes/pull/84486
• [x] https://github.com/kubernetes/website/pull/16697
• [x] https://github.com/kubernetes/kubernetes/pull/84472
• [x] https://github.com/kubernetes/kubernetes/pull/90061

/sig windows
/sig node

[mrbobbytables]

Thanks @PatrickLang I'll add it to the Enhancement tracking sheet. Just a reminder, the KEP must be merged, in an implementable state with a test plan and graduation criteria defined by EoD tomorrow at 5pm PT.

[PatrickLang]

/milestone v1.17

[mrbobbytables]

@PatrickLang Thanks for going ahead and filing an exception request, we'll follow up there for review 👍

For now it's being removed from the milestone and flagged as tracked/no. If approved it'll be added back in.

[jeremyrickard]

@guineveresaenger approved the exception, so I am adding this back to the 1.17 milestone.

[jeremyrickard]

/milestone v1.17

[daminisatya]

Hello, @PatrickLang I'm 1.17 docs lead.

Does this enhancement (or the work planned for v1.17) require any new docs (or modifications to existing docs)? If not, can you please update the 1.17 Enhancement Tracker Sheet (or let me know and I'll do so)

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.17) due by Friday, November 8th, it can just be a placeholder PR at this time. Let me know if you have any questions!

[daminisatya]

Hello, @PatrickLang

Please let us know if this enhancement requires docs. If so, We're hoping to have a placeholder Docs PR against k/website (branch dev-1.17) by Friday, Nov 8th. (4 more days left)

[palnabarun]

Hi @PatrickLang

I am one of the Enhancements Shadow for the 1.17 Release Team. We are very near to the Code Freeze (Nov 14th) for this release cycle. Just checking in about the progress of this enhancement. Can you please link the PR's related to this enhancement here?

Thank you in advance :smile:

[daminisatya]

Hello @PatrickLang

Just a friendly reminder, We're hoping to have a placeholder Docs PR against k/website (branch dev-1.17) by Friday, Nov 8th. (2 more days left)

[PatrickLang]

@palnabarun @daminisatya @jeremyrickard - PRs attached. There may be additional code PRs as the current one is a WIP and under active discussion and review with SIG-Node before proceeding with the next steps.

[palnabarun]

@PatrickLang Thank you for the updates 😀

[palnabarun]

Hi @PatrickLang , tomorrow is code freeze for the 1.17 release cycle. It looks like the k/k PRs have not yet been merged. We're flagging as the enhancement as At Risk in the 1.17 Enhancement Tracking Sheet.

Do you think they will be merged by the EoD of the 14th (Thursday)? After that point, only release-blocking issues and PRs will be allowed in the milestone with an exception.

[palnabarun]

/assign @PatrickLang

[PatrickLang]

This has one of the use cases complete and merged. I will update the doc bug tomorrow for that. The other use case related to multiple OS versions on the same node will be moved out.

How do you want to track this? Keep this open and move to 1.18?

[palnabarun]

How do you want to track this? Keep this open and move to 1.18?

We generally keep enhancement issues open until the Stable milestone is complete. So, yes this will remain open for the time being.

Regarding the pending PR and the use case yet to be implemented, I think that you should probably push it to 1.18 and fully graduate to Alpha in 1.18, making it feature complete.

Please let us know what are your thoughts about this.

[mrbobbytables]

/milestone v1.18

[jeremyrickard]

Hey @PatrickLang

1.18 enhancements team reaching out 👋 How is this looking for 1.18? Do you plan on going to Alpha in the 1.18 release? Code freeze will be on March 5th

[jeremyrickard]

Confirmed with @PatrickLang this should be tracked for 1.18

[iheanyi1]

Hello @PatrickLang ,

I'm 1.18 docs shadow.

Just want to know if this enhancement work planned for 1.18 require any new docs (or modifications to existing docs)? If not, can you please update the 1.18 Enhancement Tracker Sheet (or let me know and I'll do so)

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.18) due by Friday, Feb 28th, it can just be a placeholder PR at this time.
Warm regards,

chima

[jeremyrickard]

Hey @PatrickLang

Just a friendly reminder that code freeze for 1.18 is March 05, 2020.

As we track toward code freeze, please list out/link to any PRs you are working on toward graduating this enhancement!

[iheanyi1]

Hello @PatrickLang ,

I'm 1.18 docs shadow.

Just want to know if this enhancement work planned for 1.18 require any new docs (or modifications to existing docs)? If not, can you please update the 1.18 Enhancement Tracker Sheet (or let me know and I'll do so)

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.18) due by Friday, Feb 28th, it can just be a placeholder PR at this time.

[PatrickLang]

The user-facing change (node labels) was completed in 1.17 - PRs above.

What we're doing for 1.18 is a change to CRI. It won't be user-visible in 1.18 immediately as we need to make some updates to ContainerD. The end goal is to have different RuntimeClasses supported so that someone can run containers for multiple versions on the same node, instead of requiring different nodes per Windows version

[VineethReddy02]

@PatrickLang So can I update the docs tracking sheet that we don't need any docs under k8s/website repo for this enhancement for release 1.18?

[PatrickLang]

Yes, no docs needed for 1.18. thanks for checking

[marosset]

/milestone 1.19

[k8s-ci-robot]

@marosset: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone 1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[palnabarun]

/milestone clear

(removing this from the v1.18 milestone since that cycle is complete)

[palnabarun]

Hi @PatrickLang @marosset, -- 1.19 Enhancements Lead here. I just wanted to confirm if this Enhancement will be graduating to Beta in 1.19?

If you do, I'll add it to the 1.19 tracking sheet (http://bit.ly/k8s-1-19-enhancements). Once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

---

The current release schedule is:

• Monday, April 13: Week 1 - Release cycle begins
• Tuesday, May 19: Week 6 - Enhancements Freeze
• Thursday, June 25: Week 11 - Code Freeze
• Thursday, July 9: Week 14 - Docs must be completed and reviewed
• Tuesday, August 4: Week 17 - Kubernetes v1.19.0 released

[marosset]

Hi @palnabarun - This work is not yet in an alpha state yet.

We are working towards implementing the 'fallback' described under https://github.com/kubernetes/enhancements/blob/master/keps/sig-windows/windows-runtimeclass-support.md#proposal by implementing the feature with annotations in 1.19.

[palnabarun]

/stage alpha

[palnabarun]

/milestone v1.19

[mikejoh]

Hello, @PatrickLang ! :wave: I'm one of the v1.19 Docs shadows. Does this enhancement work planned for v1.19 require any new docs (or modifications to existing docs)?

I saw that this docs PR was merged https://github.com/kubernetes/website/pull/16697 a couple of months ago.

Regards,
Mikael.

[palnabarun]

@marosset -- As per our conversation on Slack, I have updated the tracking sheet. Thanks for the pro-active ping. :+1:

/milestone clear

[marosset]

Thanks @palnabarun!
Unfortunately I don't think we'll be finished with the work for this to go to alpha for 1.19.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[kikisdeliveryservice]

Hi @PatrickLang @marosset

Enhancements Lead here, do you still intend to go alpha in 1.20?

Thanks!
Kirsten

[marosset]

@kikisdeliveryservice I'm starting a discussion with SIG-Windows leads about this now.

[kikisdeliveryservice]

Sounds good, please keep us updated!

[marosset]

Hi @kikisdeliveryservice - I spoke with sig-windows leads and since we don't foresee needing any implementation PRs in k/k we didn't think tracking this as an enhancement makes sense.
Pretty much all of the remaining work here is making sure there is adequate test coverage in periodic jobs on testgrid as well as documentation.
Should I close this issue for now and re-open if the situation changes?

[kikisdeliveryservice]

@marosset that sounds good to me!

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten