Enhancements: Advanced configurations with kubeadm (using Kustomize).

[neolit123]

Enhancement Description

• One-line enhancement description (can be used as a release note):
  Add a new kubeadm feature that will allow users to apply kustomize patches to static pod manifests generated by kubeadm during kubeadm init, join and kubeadm upgrade.
• Kubernetes Enhancement Proposal: (link to kubernetes/enhancements file, if none yet, link to PR) https://github.com/kubernetes/enhancements/blob/master/keps/sig-cluster-lifecycle/kubeadm/20190722-Advanced-configurations-with-kubeadm-(Kustomize).md
• Primary contact (assignee): @fabriziopandini
• Responsible SIGs: Cluster Lifecycle
• Enhancement target (which target equals to which milestone):
  
  
  
  • Alpha release target 1.16
  
  
  • Beta release target TODO
  
  
  • Stable release target TODO
  
  

_Please to keep this description up to date. This will help the Enhancement Team track efficiently the evolution of the enhancement_

k/kubeadm tracking issue:
https://github.com/kubernetes/kubeadm/issues/1379

2019-07-29:

• KEP merged
• POC PR is up in k/k https://github.com/kubernetes/kubernetes/pull/80580

2019-08-22:

• PRs for the alpha:
  
  
  
  • https://github.com/kubernetes/kubernetes/pull/80905
  
  
  • https://github.com/kubernetes/kubernetes/pull/81458
  
  

[neolit123]

@kacole2 hi, i've just added this issue / feature to tracked/yes. please update if needed.
the KEP just merged https://github.com/kubernetes/enhancements/pull/1159

[kacole2]

@neolit123 I got you. thanks!

[fabriziopandini]

@neolit123 thanks for taking care of creating this issue!

[sethmccombs]

Hey @neolit123 @fabriziopandini

I'm one of the v1.16 docs shadows.
Does this enhancement (or the work planned for v1.16) require any new docs (or modifications to existing docs)? If not, can you please update the 1.16 Enhancement Tracker Sheet (or let me know and I’ll do so)

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.16) due by Friday, August 23rd, it can just be a placeholder PR at this time. Let me know if you have any questions!

[neolit123]

hi @sethmccombs

I'm one of the v1.16 docs shadows.
Does this enhancement (or the work planned for v1.16) require any new docs (or modifications to existing docs)? If not, can you please update the 1.16 Enhancement Tracker Sheet (or let me know and I’ll do so)

yes, it does require docs.

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.16) due by Friday, August 23rd, it can just be a placeholder PR at this time. Let me know if you have any questions!

i've added a placeholder docs PRs: TODO note in the OP.
we will definitely create place holder PRs before the 23rd.

thanks for the heads up!

[neolit123]

@sethmccombs

hi, we spoke about whether this requires docs again during the office hours of kubeadm (Wed 21Aug) and decided to not add any documentation for this feature's Alpha stage.

i will defer to @fabriziopandini if we decide to change our mind later down the line.

i've also updated the OP with some WIP/merged PRs.
thanks

[simplytunde]

@neolit123 I am the 1.16 Docs Lead. I will go ahead and put this down as docs-not-required. @fabriziopandini Please let me change of this changes before the end of Aug 23.

[kacole2]

@neolit123 code freeze for 1.16 is on Thursday 8/29. Looks like all PRs here have been merged. If that's the case, congrats on getting this in for Alpha!

[mrbobbytables]

Hey there @neolit @fabianofranz -- 1.17 Enhancements lead here. I wanted to check in and see if you think this Enhancement will be graduating to alpha/beta/stable in 1.17?

The current release schedule is:

• Monday, September 23 - Release Cycle Begins
• Tuesday, October 15, EOD PST - Enhancements Freeze
• Thursday, November 14, EOD PST - Code Freeze
• Tuesday, November 19 - Docs must be completed and reviewed
• Monday, December 9 - Kubernetes 1.17.0 Released

If you do, please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!

/milestone clear

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[neolit123]

/lifecycle frozen

[fejta-bot]

Enhancement issues opened in kubernetes/enhancements should never be marked as frozen.
Enhancement Owners can ensure that enhancements stay fresh by consistently updating their states across release cycles.

/remove-lifecycle frozen

[fabriziopandini]

@neolit123 what about moving to beta in 1.18?

[neolit123]

@fabriziopandini from the KEP:

This proposal in its initial version covers only the creation of a new alpha feature. Graduation criteria will be defined in the following iterations on this proposal and consider user feedback as well.

do you think it would be best to present the changes you wish to make in the kubeadm office hours and update the KEP if people agree?

[palnabarun]

Hey there @neolit123 @fabriziopandini -- 1.18 Enhancements shadow here. I see that there has been traction on this enhancement. Let us know about the consensus from the kubeadm office hours whether this will go to beta.

The current release schedule is:

• Monday, January 6th - Release Cycle Begins
• Tuesday, January 28th EOD PST - Enhancements Freeze
• Thursday, March 5th, EOD PST - Code Freeze
• Monday, March 16th - Docs must be completed and reviewed
• Tuesday, March 24th - Kubernetes 1.18.0 Released

If you would like to include this enhancement, once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

We'll be tracking enhancements here: http://bit.ly/k8s-1-18-enhancements

Thanks! :)

[fabriziopandini]

@neolit123 I'm +1 for moving to beta in 1.18. Opinions?

[neolit123]

@fabriziopandini
as commented here:
https://github.com/kubernetes/enhancements/issues/1177#issuecomment-572592278

i think, it would be best to talk about this in the office hours this week and decide if we want to target the enhancement freeze of 28th.

[fabriziopandini]

@palnabarun
As discussed in the kubeadm office hours today, we decided to keep this feature in alpha for some more time. no changes planned for the v1.18 cycle

[palnabarun]

Thank you @fabriziopandini for the updates. I will remove this enhancement from the tracking sheet,

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[neolit123]

/remove-lifecycle stale

[msedzins]

Hey there @fabriziopandini -- 1.19 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating in 1.19?

In order to have this part of the release:

1. The KEP PR must be merged in an implementable state
2. The KEP must have test plans
3. The KEP must have graduation criteria.

The current release schedule is:

• Monday, April 13: Week 1 - Release cycle begins
• Tuesday, May 19: Week 6 - Enhancements Freeze
• Thursday, June 25: Week 11 - Code Freeze
• Thursday, July 9: Week 14 - Docs must be completed and reviewed
• Tuesday, August 4: Week 17 - Kubernetes v1.19.0 released

If you do, I'll add it to the 1.19 tracking sheet (http://bit.ly/k8s-1-19-enhancements). Once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!

[neolit123]

@msedzins hi, we are not going to make changes related to this in 1.19.

[msedzins]

Thank you @neolit123 for letting me know.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[neolit123]

/remove-lifecycle stale

[palnabarun]

/remove-lifecycle stale

(trying again)

[kikisdeliveryservice]

Hi @neolit123

Enhancements Lead here. Any plans for this in 1.20?

Thanks!
Kirsten

[neolit123]

Hi. We have plans to close this issue as the feature is going to be removed
in 1.20. Was deprecated since 1.19 and replaced by --experimenal-patches.

[kikisdeliveryservice]

Hi @neolit123

Any update on closing this issue?

[fabriziopandini]

+1 to close this, the code was removed by https://github.com/kubernetes/kubernetes/pull/94871

[neolit123]

/close

[k8s-ci-robot]

@neolit123: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.