Enhancements: Clarify use of node-role labels within Kubernetes and migrate old components

[smarterclayton]

Enhancement Description

• One-line enhancement description (can be used as a release note):

Clarify that the node-role.kubernetes.io/* label is for use only by users and external projects and may not be used to vary Kubernetes behavior. Define migration process for all internal consumers of these labels.

• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/blob/master/keps/sig-architecture/2019-07-16-node-role-label-use.md
• Primary contact (assignee): @smarterclayton
• Responsible SIGs: @kubernetes/sig-architecture-api-reviews, @kubernetes/sig-node-api-reviews, @kubernetes/sig-testing, @kubernetes/sig-network-api-reviews
• Enhancement target (which target equals to which milestone):
  
  
  
  • Alpha release target (x.y) 1.17
  
  
  • Beta release target (x.y) 1.18
  
  
  • Stable release target (x.y) 1.19
  
  

[smarterclayton]

/sig architecture
/sig testing
/sig network
/sig node

[timothysc]

@kubernetes/sig-cluster-lifecycle
cc @luxas @justinsb @neolit123 @fabriziopandini

[smarterclayton]

Would like to get an exception for 1.16, trying to get approval on the KEP (Jordan and Justin were primary reviewers, Derek helped take a look from sig-node). Will follow up early next week.

[palnabarun]

Hey there @smarterclayton , 1.17 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating to alpha in 1.17?

The current release schedule is:

• Monday, September 23 - Release Cycle Begins
• Tuesday, October 15, EOD PST - Enhancements Freeze
• Thursday, November 14, EOD PST - Code Freeze
• Tuesday, November 19 - Docs must be completed and reviewed
• Monday, December 9 - Kubernetes 1.17.0 Released

If you do, I'll add it to the 1.17 tracking sheet (https://bit.ly/k8s117-enhancement-tracking). Once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!

[smarterclayton]

Yes, this will be alpha in 1.17.

[smarterclayton]

KEP is updated with plan starting as alpha in 1.17

[palnabarun]

Thank you for the swift response. :)

Added this to 1.17 release.

/stage alpha
/milestone v1.17

[palnabarun]

Just FYI, all enhancements should have a KEP, the KEP PR should be merged, the KEP should be in an implementable state, have a testing plan and graduation criteria.

I see that you have updated your KEP with #1268. Please make sure that it is merged before the Enhancements Freeze.

[daminisatya]

Hello, @smarterclayton I'm 1.17 docs lead.

Does this enhancement (or the work planned for v1.17) require any new docs (or modifications to existing docs)? If not, can you please update the 1.17 Enhancement Tracker Sheet (or let me know and I'll do so)

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.17) due by Friday, November 8th, it can just be a placeholder PR at this time. Let me know if you have any questions!

[daminisatya]

Hello @smarterclayton,

Please let us know if this enhancement requires docs. If so, We're hoping to have a placeholder Docs PR against k/website (branch dev-1.17) by Friday, Nov 8th. (4 more days left)

[smarterclayton]

The docs have already been merged in 1.16.

On Mon, Nov 4, 2019 at 12:46 PM Damini Satya [e-mail]
wrote:

Hello @smarterclayton https://github.com/smarterclayton,

Please let us know if this enhancement requires docs. If so, We're hoping
to have a placeholder Docs PR against k/website (branch dev-1.17) by
Friday, Nov 8th. (4 more days left)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/enhancements/issues/1143?email_source=notifications&email_token=AAI37J4QNP24WNQZ7KZC2NTQSBNWZA5CNFSM4IEJLH5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDADQWA#issuecomment-549468248,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAI37J5NXIXIMWNDA5JCCMTQSBNWZANCNFSM4IEJLH5A
.

[palnabarun]

Hi @smarterclayton

I am one of the Enhancements Shadow for the 1.17 Release Team. We are very near to the Code Freeze (Nov 14th) for this release cycle. Just checking in about the progress of this enhancement. I see that https://github.com/kubernetes/kubernetes/pull/80238 was filed in relation to this. Is there any other PR related to this enhancement? If yes, can you please link them here?

Thank you in advance :smile:

[smarterclayton]

This required no changes in 1.17 to go to alpha. It is ready.

On Tue, Nov 5, 2019 at 2:13 PM Nabarun Pal [e-mail] wrote:

Hi @smarterclayton https://github.com/smarterclayton

I am one of the Enhancements Shadow for the 1.17 Release Team. We are very
near to the Code Freeze (Nov 14th) for this release cycle. Just checking in
about the progress of this enhancement. I see that
kubernetes/kubernetes#80238
https://github.com/kubernetes/kubernetes/pull/80238 was filed in
relation to this. Is there any other PR related to this enhancement? If
yes, can you please link them here?

Thank you in advance 😄

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/enhancements/issues/1143?email_source=notifications&email_token=AAI37JYD7C73UIWMWSTJNVLQSHAT5A5CNFSM4IEJLH5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDD7EKY#issuecomment-549974571,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAI37J5DNQNVUZFJCB2SNZLQSHAT5ANCNFSM4IEJLH5A
.

[palnabarun]

@smarterclayton Thank you for the updates. :)

[jeremyrickard]

Hey there @smarterclayton , 1.18 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating to beta in 1.18?

The current release schedule is:

Monday, January 6 - Release Cycle Began
Tuesday, January 28, EOD PST - Enhancements Freeze
Thursday, March 5, EOD PST - Code Freeze
Monday, March 16- Docs must be completed and reviewed
Tuesday, March 24 - Kubernetes 1.18.0 Released

If you do, I'll add it to the 1.17 tracking sheet (http://bit.ly/k8s-1-18-enhancements). Once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!

[kikisdeliveryservice]

As a reminder @smarterclayton :

Tuesday, January 28th EOD PST - Enhancements Freeze

Enhancements Freeze is in 7 days. If you seek inclusion in 1.18 please update as requested above.

Thanks!

[smarterclayton]

This issue will graduate to beta in 1.19.

[palnabarun]

/remove-milestone v1.17

[spiffxp]

/milestone v1.19

[harshanarayana]

Hey there @smarterclayton, 1.19 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating in 1.19?

In order to have this part of the release:

1. The KEP PR must be merged in an implementable state
2. The KEP must have test plans
3. The KEP must have graduation criteria.

The current release schedule is:

• Monday, April 13: Week 1 - Release cycle begins
• Tuesday, May 19: Week 6 - Enhancements Freeze
• Thursday, June 25: Week 11 - Code Freeze
• Thursday, July 9: Week 14 - Docs must be completed and reviewed
• Tuesday, August 4: Week 17 - Kubernetes v1.19.0 released

If you do, I'll add it to the 1.19 tracking sheet (http://bit.ly/k8s-1-19-enhancements). Once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!

[harshanarayana]

Hey @smarterclayton, I'm following up on my previous update on this Enhancement being part of the v1.19 release.

Do you happen to have any update on the possiblity of this being included in the release v1.19?

Thanks again for your time and contributions. 🖖

[harshanarayana]

Hey @smarterclayton, I'm following up on my previous update on this Enhancement being part of the v1.19 release.

Do you happen to have any update on the possiblity of this being included in the release v1.19?

Thanks again for your time and contributions. 🖖

[harshanarayana]

Hey @smarterclayton, any plans for the Enhancements to be included in v1.19? Please let me know so that I can update the tracking sheet to show the inclusion state.

_Enhancements freeze is on May 19_

Note that recently the KEP format has changed. Additionally, #1620 merged recently, adding production readiness review questions to the KEP template.
Please take this opportunity to reformat your KEP and also answer the questions added to the template in that PR.

Thanks,
🖖

[harshanarayana]

Hey @smarterclayton , Unfortunately the deadline for the 1.19 Enhancement freeze has passed. For now this is being removed from the milestone and 1.19 tracking sheet. If there is a need to get this in, please file an enhancement exception.

[palnabarun]

/milestone clear

[smarterclayton]

This was part of the existing release, is already merged, and has not
significantly changed.

On Wed, May 20, 2020 at 12:55 AM Nabarun Pal [e-mail]
wrote:

/milestone clear

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/enhancements/issues/1143#issuecomment-631235977,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAI37JZ2R4P3EI6SFR55VCDRSNPE7ANCNFSM4IEJLH5A
.

[smarterclayton]

I don't understand what you are asking above and beyond what was in this issue already and what is in the merged kep? A human has to respond to a question on an issue to clarify a statement already made? Maybe I missed something...

[BenTheElder]

IIRC the KEP state should be updated to "implemented" and possibly an update to e.g. the implementation history section https://github.com/kubernetes/enhancements/blob/master/keps/sig-architecture/2019-07-16-node-role-label-use.md still shows "implementable"

[harshanarayana]

@smarterclayton @BenTheElder Sorry for the confusion.

https://github.com/kubernetes/enhancements/issues/1143#issuecomment-631218555 is missing a key details that caused the confusion. The KEP is still missing details with regards to the v1.19 under the Graduation Criteria. I missed indicating this while updating the last comment indicating the miss of Enhancement Freeze deadline.

@smarterclayton Would you be interested in updating the Graduation Criteria to indicate the state as of v1.19 and raise an enhancement exception ?

Regards, Harsha

[smarterclayton]

I think I have the correct updates in https://github.com/kubernetes/enhancements/pull/1806 now, please review.

[palnabarun]

@smarterclayton -- The exception request was approved. :+1:

I've flipped the status of this enhancement back to tracked.

[palnabarun]

/stage beta
/milestone v1.19

[annajung]

Hi @smarterclayton 👋 1.19 docs shadow here! Does this enhancement work planned for 1.19 require new or modification to docs?

Friendly reminder that if new/modification to docs are required, a placeholder PR against k/website (branch dev-1.19) are needed by Friday, June 12.

[annajung]

Hi @smarterclayton 👋 Checking in again. Please note if new or modification to current doc is required, then a placeholder PR against k/website (branch dev-1.19) is needed by Friday, June 12.

[annajung]

Hi @smarterclayton just adding on the comment above. If you're waiting to see if this will make it into 1.19 or be pushed to future release, Docs team still highly recommend getting the draft PR in before the due date as it's easier to clean up a draft PR then not having the draft in place to move this enhancement forward :)

[harshanarayana]

Hey @smarterclayton, I am with the enhancements team for the v1.19 release cycle as a shadow.

The code freeze deadline for the Enhancement is Thursday, June 25. I am checking in to see if there is any k/k PR that you have already opened for this enhancement and if so, would you be able to point me in the direction of the PR so that the same can be updated in the tracking sheet

Have a wonderful day. 🖖

[smarterclayton]

The docs for this should already have been merged in 1.16. I will check to
see whether we need to update the docs for the current status.

On Fri, Jun 12, 2020 at 10:45 AM Harsha Narayana [e-mail]
wrote:

Hey @smarterclayton https://github.com/smarterclayton, I am with the
enhancements team for the v1.19 release cycle as a shadow.

The code freeze deadline for the Enhancement is Thursday, June 25. I am
checking in to see if there is any k/k PR that you have already opened
for this enhancement and if so, would you be able to point me in the
direction of the PR so that the same can be updated in the tracking sheet

Have a wonderful day. 🖖

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/enhancements/issues/1143#issuecomment-643310028,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAI37J3D634W2AO4B3CPPZTRWI5PVANCNFSM4IEJLH5A
.

[annajung]

Great, Thank you for checking! If any modifications to the existing doc is required for this release, please make sure to create a placeholder PR against k/website (branch dev-1.19).

If no update is required, just let me know so that I can update the tracking sheet accordingly.

[harshanarayana]

Hi, @smarterclayton

This is a follow-up to the communication that went out to k-dev today. There has been a revision to the release schedule of v1.19 as follows.

Thursday, July 9th: Week 13 - Code Freeze
Thursday, July 16th: Week 14 - Docs must be completed and reviewed
Tuesday, August 25th: Week 20 - Kubernetes v1.19.0 released
Thursday, August 27th: Week 20 - Release Retrospective

You can find the revised Schedule in the sig-release Repo

Please let me know if you have any questions. 🖖

[annajung]

Hi @smarterclayton, checking in again to see if you could confirm if an update to docs is needed or not.

There has been a revision to the release schedule as mentioned above, and a placeholder PR against the k/website repo is due by June 19th (in 2 days!). If you're unsure, I still highly recommend creating one before the due date so that you have all the requirements ready to move this enhancement forward.

Thank you!

[annajung]

Hi @smarterclayton, just a friendly reminder that tomorrow is the due date for placeholder PR. Please take a note of previous messages on action required. Thank you!

[smarterclayton]

Docs PR is up in https://github.com/kubernetes/website/pull/21921

[annajung]

Thank you! Tracking sheet has been updated accordingly

[sftim]

In terms of documentation, I logged https://github.com/kubernetes/website/pull/21921#pullrequestreview-434439126 with some queries.

@smarterclayton do you think there is a need for additional documentation? If there are existing announcements etc do these need highlighting as part of the v1.19 release?

[harshanarayana]

Hi @smarterclayton, I noticed that there are no PRs against k/k for this yet. Is there a PR required against the k/k for this ? In case if it is required, please let me know the placeholder PR so that it can be updated to reflect in the tracking sheets.

Code freeze deadline is Thursday, July 9th: Week 13

Thanks in advance for your help.

[kikisdeliveryservice]

/milestone clear

(removing this enhancement issue from the v1.19 milestone as the milestone is complete)

[kikisdeliveryservice]

Hi @smarterclayton

Enhancements Lead here. Any plans for this in 1.20?

Thanks!
Kirsten

[kikisdeliveryservice]

Hi @smarterclayton

Any plans for this in 1.20? Enhancements Freeze is October 6th

Thanks!