Enhancements: Graduate NodeLocal DNSCache to GA

[prameshj]

Enhancement Description

• One-line enhancement description (can be used as a release note):
  Graduate NodeLocal DNSCache to beta

• Kubernetes Enhancement Proposal: 20190424-NodeLocalDNS-beta-proposal.md

  • PR to update the KEP: https://github.com/kubernetes/enhancements/pull/1351

• Primary contact (assignee): @prameshj

• Responsible SIGs: sig-network
• Enhancement target (which target equals to which milestone):
  
  
  
  • Alpha release target (x.y) 1.13
  
  
  • Beta release target (x.y) 1.15
  
  
  • Stable release target (x.y) 1.18
  
  

[prameshj]

/sig network

[prameshj]

/assign prameshj

[prameshj]

/milestone v1.15
/stage beta

[k8s-ci-robot]

@prameshj: You must be a member of the kubernetes/kubernetes-milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.15
/stage beta

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[makoscafee]

Hey, @prameshj 👋 I'm the v1.15 docs Lead.
Does this enhancement require any new docs (or modifications)?

Just a friendly reminder we're looking for a PR against k/website (branch dev-1.15) due by Thursday, May 30th. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions!

[prameshj]

Thanks, @MAKOSCAFEE , I will open a PR and update the docs. Most of the code changes for this will be in the kubernetes/dns repo. I will update the docs and the image version in k/k. I'll open a placeholder PR in a day.

[prameshj]

Pleaceholder PR : https://github.com/kubernetes/kubernetes/pull/77887

[makoscafee]

Hi @prameshj above is not docs placeholder PR, right?

[kacole2]

Hi @prameshj . Code Freeze is Thursday, May 30th 2019 @ EOD PST. All enhancements going into the release must be code-complete, including tests, and have docs PRs open.

Please list all current k/k PRs so they can be tracked going into freeze. If the PRs aren't merged by freeze, this feature will slip for the 1.15 release cycle. Only release-blocking issues and PRs will be allowed in the milestone.

If you know this will slip, please reply back and let us know. Thanks!

[prameshj]

Thanks for the reminder, @kacole2

We need the following PRs merged:
kubernetes/kubernetes#78417
kubernetes/kubernetes#77887
Also, https://github.com/kubernetes/dns/pull/302 and the new image to be used in the k/k yaml. I am planning to complete these by the code freeze deadline.

[makoscafee]

Hi @prameshj sorry! will this enhancement need user documentation in k/website apart from k/dns ? if yes can you open Placeholder PR before 30th which is the deadline for that. Thanks

[prameshj]

Hi @prameshj sorry! will this enhancement need user documentation in k/website apart from k/dns ? if yes can you open Placeholder PR before 30th which is the deadline for that. Thanks

created https://github.com/kubernetes/website/pull/14625

[prameshj]

Forgot to mention, this PR needs to be in the 1.15 milestone as well.
https://github.com/kubernetes/kubernetes/pull/78546

[kacole2]

Hi @prameshj , I'm the 1.16 Enhancement Lead. Is this feature going to be graduating alpha/beta/stable stages in 1.16? Please let me know so it can be added to the 1.6 Tracking Spreadsheet. If not's graduating, I will remove it from the milestone and change the tracked label.

Once coding begins or if it already has, please list all relevant k/k PRs in this issue so they can be tracked properly.

Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thank you.

[prameshj]

Sorry for the delayed response, we are not graduating to stable in 1.16. Will try to target the next release.

[jeremyrickard]

Hey there @prameshj -- 1.17 Enhancements shadow here 👋 . I wanted to check in and see if you think this Enhancement will be graduating to beta in 1.17?

The current release schedule is:

• Monday, September 23 - Release Cycle Begins
• Tuesday, October 15, EOD PST - Enhancements Freeze
• Thursday, November 14, EOD PST - Code Freeze
• Tuesday, November 19 - Docs must be completed and reviewed
• Monday, December 9 - Kubernetes 1.17.0 Released

If you do, I'll add it to the 1.17 tracking sheet (https://bit.ly/k8s117-enhancements). Once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!!

[prameshj]

Hi @jeremyrickard , This has already graduated to beta in 1.15. We will target Stable in 1.18.

[jeremyrickard]

@prameshj oops I removed the wrong stages when I was dropping the template in here! Thanks, I'll have this marked for 1.18!

[jeremyrickard]

/milestone v1.18

[prameshj]

/stage stable

Thanks @jeremyrickard ! Could you update the stage to stable and mark this as tracked? I tried changing the labels, but maybe I don't have access?

[mrbobbytables]

@prameshj just to confirm -- you're aiming for 1.18 and not 1.17 right? It should only be marked tracked at this time if its going into the 1.17 milestone.

[prameshj]

Correct, this is for 1.18.

[jeremyrickard]

Hey @prameshj,

1.18 enhancements team reaching out 👋

Are you still planning on graduating this to stable in the 1.18 release? Enchancement Freeze will be on January 28th, it looks like you have a PR open to add graduation criteria to the KEP at #1351
That will need to get merged prior to the enhancement freeze in order to be included in the release.

Thanks!

[prameshj]

Thanks for the reminder, @jeremyrickard. The plan is to graduate this feature to stable in 1.18 release. I will work on getting the PR merged by 28th.

[palnabarun]

Cross-posting from Slack.

I am going ahead and updating the Issue comment with the KEP PR.

[jeremyrickard]

Hey @prameshj how are you feeling about geting the KEP merged by Enhancement Freeze? We're about a week away!

[prameshj]

I am hopeful about merging the KEP before Jan 28th. I got an LGTM, will get it approved in the next few days, thanks for the reminder.

[palnabarun]

Thank you @prameshj in being proactive for getting this through the requirements for Enhancements Freeze. Appreciate the efforts. :)

Please link the k/k or any other PR's here whenever there are are raised.

[iheanyi1]

Hello @prameshj ,

I'm 1.18 docs shadow.

Just want to know if this enhancement work planned for 1.18 require any new docs (or modifications to existing docs)? If not, can you please update the 1.18 Enhancement Tracker Sheet (or let me know and I'll do so)

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.18) due by Friday, Feb 28th, it can just be a placeholder PR at this time. Let me know if you have any questions!

Warm regards,

chima

[prameshj]

There is an update to the website docs , this is the PR - https://github.com/kubernetes/website/pull/18716
We are close to merging this, there is just one open comment.

[sftim]

BTW @prameshj the ~PR~ issue _description_ says:

Graduate NodeLocal DNSCache to beta

(ie, beta not GA)

[prameshj]

BTW @prameshj the ~PR~ issue _description_ says:

Graduate NodeLocal DNSCache to beta

(ie, beta not GA)

hmm.. where do you see this? I had renamed this issue title few months ago.

[sftim]

[jeremyrickard]

Hey @prameshj,

Just a friendly reminder that code freeze for 1.18 is March 05, 2020.

As we track toward code freeze, please list out/link to any PRs you are working on toward graduating this enhancement!

[jeremyrickard]

Hey @prameshj,

Just another friendly reminder that code freeze for 1.18 is March 05, 2020.
As a reminder, please link any k/k PRs here so we can better track this issue.

[prameshj]

The code-freeze is for k/k PRs correct?
I have the docs update PR that has lgtm, waiting for an approval - https://github.com/kubernetes/website/pull/18716
The rest of the changes will be in kubernetes/dns and kubernetes/perf-tests repos. Do those need to be linked and completed by March 5 as well?

[jeremyrickard]

@prameshj yeah, all of those should be completed by March 5th as well. If you can link them, that would be most helpful.

[prameshj]

https://github.com/kubernetes/kubernetes/pull/88877
https://github.com/kubernetes/perf-tests/pull/1108

[jeremyrickard]

Hey @prameshj thanks for linking the k/k PR and the perf-test PR. The k/k PR is missing the 1.18 milestone, so it won't merge right now. Code Freeze was enabled earlier today, so all the PRs need to have the 1.18 milestone. You'll need to submit an exception request for this one at this point.

[jeremyrickard]

/milestone clear

[prameshj]

@jeremyrickard Thanks for pointing this out - the PR kubernetes/kubernetes#88877 is ready to merge and I just added the milestone.
It is just changing the image version. I do not need an extension for making any more code changes, they are already made. Is the exception request in order to allow this PR to be merged?

[prameshj]

@jeremyrickard Just in case this is still needed, can you check if the request looks ok? I will send an email with this once i hear from you.
Enhancement name: NodeLocal DNSCache
Enhancement status (alpha/beta/stable): stable
SIG: Network
k/enhancements repo issue #: 1024
PR #’s: kubernetes/kubernetes#88877
Additional time needed (in days): 1
Reason this enhancement is critical for this milestone: This is a very important feature that improves DNS latency in kubernetes clusters.
Risks from adding code late: None
Risks from cutting enhancement: The feature went beta 3 releases ago in 1.15, missing this release for stable will make the graduation time much longer and create friction in usage of the feature.

[prameshj]

Also, the latest node-cache image can be used in any cluster and it has all the features we wanted for GA. The PR - kubernetes/kubernetes#88877 changes the version just for scripts using GCE, so it is not critical to make this change for graduating to GA.

[jeremyrickard]

@prameshj yeah, please submit the exception request. What you showed as the example above looks good.

[prameshj]

Thanks @jeremyrickard , i just sent the email.

[prameshj]

@jeremyrickard Could you mark this enhancement as tracked for 1.18? Thanks!

[kikisdeliveryservice]

/milestone 1.18

[k8s-ci-robot]

@kikisdeliveryservice: The provided milestone is not valid for this repository. Milestones in this repository: [keps-beta, keps-ga, v1.17, v1.18, v1.19, v1.20, v1.21]

Use /milestone clear to clear the milestone.

In response to this:

/milestone 1.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jeremyrickard]

/milestone v1.18

[palnabarun]

@prameshj Since, this enhancement graduated to Stable in 1.18, can you please mark it as implemented?

[prameshj]

This is already marked as implemented - https://github.com/kubernetes/enhancements/blob/master/keps/sig-network/0030-nodelocal-dns-cache.md
Is that what you were referring to?

[palnabarun]

@prameshj The KEP in the issue comment. I am guessing there were different KEPs for beta and stable.

Can you please also mark this KEP implemented? :slightly_smiling_face:

[prameshj]

Done - https://github.com/kubernetes/enhancements/pull/1695

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[palnabarun]

/remove-lifecycle stale

[kikisdeliveryservice]

This Issue has an outstanding PR: https://github.com/kubernetes/enhancements/pull/2006 That needs approval to mark it as implemented so we can close it. Can someone PTAL?

[kikisdeliveryservice]

Since #2006 has merged, closing this issue.