Enhancements: Moving kubectl package code to staging

[soltysh]

Enhancement Description

• One-line enhancement description (can be used as a release note):
  Moving kubectl package code to staging
• Kubernetes Enhancement Proposal: (link to kubernetes/enhancements file, if none yet, link to PR)
  https://github.com/kubernetes/enhancements/blob/master/keps/sig-cli/kubectl-staging.md
• Primary contact (assignee): seans3, soltysh, pwittrock
• Responsible SIGs: sig-cli
• Enhancement target (which target equals to which milestone):
  There are no particular milestones to be achieved here, the end goal is to split kubectl into a separate repository but that will be outlined in separate enhancement.

[soltysh]

/stage stable
/kind feature

[makoscafee]

Hey, @soltysh 👋 I'm the v1.15 docs Lead.
Does this enhancement require any new docs (or modifications)?

Just a friendly reminder we're looking for a PR against k/website (branch dev-1.15) due by Thursday, May 30th. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions!

[kacole2]

Hi @soltysh . Code Freeze is Thursday, May 30th 2019 @ EOD PST. All enhancements going into the release must be code-complete, including tests, and have docs PRs open.

Please list all current k/k PRs so they can be tracked going into freeze. If the PRs aren't merged by freeze, this feature will slip for the 1.15 release cycle. Only release-blocking issues and PRs will be allowed in the milestone.

If you know this will slip, please reply back and let us know. Thanks!

[kacole2]

Hi @soltysh , today is code freeze. I do not see a reply for any PRs to track for this merge. It's now being marked as At Risk in the 1.15 Enhancement Tracking Sheet. If there is no response, or you respond with PRs to track and they are not merged by EOD PST, this will be dropped from the 1.15 Milestone. After this point, only release-blocking issues and PRs will be allowed in the milestone with an exception.

[kacole2]

/milestone clear

[kacole2]

Hi @soltysh , We're beginning the 1.16 Enhancement collection. Is this going to be moving to stable in 1.16? Enhancement Freeze is 7/30.

[kcmartin]

Hello @soltysh -- 1.17 Enhancement Shadow here! 🙂

I wanted to reach out to see if this enhancement will be graduating to alpha/beta/stable in 1.17?


Please let me know so that this enhancement can be added to 1.17 tracking sheet.

Thank you!

🔔Friendly Reminder

The current release schedule is

Monday, September 23 - Release Cycle Begins
Tuesday, October 15, EOD PST - Enhancements Freeze
Thursday, November 14, EOD PST - Code Freeze
Tuesday, November 19 - Docs must be completed and reviewed
Monday, December 9 - Kubernetes 1.17.0 Released

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[palnabarun]

/remove-lifecycle stale

[johnbelamaric]

Hey there @soltysh -- 1.18 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be implemented in 1.18?

The current release schedule is:

Monday, January 6th - Release Cycle Begins
Tuesday, January 28th EOD PST - Enhancements Freeze
Thursday, March 5th, EOD PST - Code Freeze
Monday, March 16th - Docs must be completed and reviewed
Tuesday, March 24th - Kubernetes 1.18.0 Released

To be included in the release, this enhancement must have a merged KEP in the implementable status. The KEP must also have graduation criteria and a Test Plan defined.

If you would like to include this enhancement, once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

We'll be tracking enhancements here: http://bit.ly/k8s-1-18-enhancements
Thanks!

[soltysh]

@johnbelamaric this is still on-going work, it's not finished but we're actively working on it. It described in details in https://github.com/kubernetes/enhancements/blob/master/keps/sig-cli/kubectl-staging.md

[palnabarun]

@soltysh Are you planning to make this enhancement part of 1.18 release cycle?

[palnabarun]

/milestone v1.18

[iheanyi1]

Hello @soltysh,

I'm 1.18 docs shadow.

Just want to know if this enhancement work planned for 1.18 require any new docs (or modifications to existing docs)? If not, can you please update the 1.18 Enhancement Tracker Sheet (or let me know and I'll do so)

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.18) due by Friday, Feb 28th, it can just be a placeholder PR at this time. Let me know if you have any questions!

Warm regards,

chima

[johnbelamaric]

@soltysh code freeze is March 5th. Please link any PRs that planned for this in 1.18, so we can track them in the release team. Thanks!

[iheanyi1]

Hello @soltysh,

I'm 1.18 docs shadow.

Just want to know if this enhancement work planned for 1.18 require any new docs (or modifications to existing docs)? If not, can you please update the 1.18 Enhancement Tracker Sheet (or let me know and I'll do so)

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.18) due by Friday, Feb 28th, it can just be a placeholder PR at this time.

[johnbelamaric]

@soltysh Any PRs we should be tracking in the release team?

[soltysh]

I know that both @iheanyi1 and @johnbelamaric reached out to me on slack, but for posterity I'll leave here a comment stating that: there's no need for docs update on this item, since this is about code structure only (mostly moving stuff from one place to another). Since we're close to finish of the overall work there are not many active PRs we can track, we're in the discussion phase for the remaining RBAC shared code which needs to land in a separate library. I'll link PRs as we go.

[palnabarun]

@soltysh Since, this enhancement graduated to Stable in 1.18, can we mark this enhancement Implemented?

[soltysh]

@palnabarun not quite, it's still being worked on, it's a on-going process, so I actually will move the release mileston to 1.19 now.
/release v1.19

[soltysh]

/milestone v1.19

[divya-mohan0209]

Hello @soltysh , I'm one of the v1.19 docs shadows.

Could you please let me know if this piece of enhancement work planned for 1.19 release requires any new docs (or modifications to existing docs)?

If not, can you please update the 1.19 Enhancement Tracker Sheet (or let me know and I'll do so)

If yes, just a friendly reminder we're looking for a PR against k/website (branch dev-1.19) due by Friday, June 12, it can just be a placeholder PR at this time.

Please do let me know if you have any questions!

Regards,
Divya

[palnabarun]

@soltysh -- Can you please link to all the implementation PR's here - k/k or otherwise? :slightly_smiling_face:

---

The current release schedule is:

• ~Monday, April 13: Week 1 - Release cycle begins~
• ~Tuesday, May 19: Week 6 - Enhancements Freeze~
• Thursday, June 25: Week 11 - Code Freeze
• Thursday, July 9: Week 14 - Docs must be completed and reviewed
• Tuesday, August 4: Week 17 - Kubernetes v1.19.0 released

[divya-mohan0209]

@soltysh : Gentle reminder on my note above. Do feel free to get in touch if any questions!

[divya-mohan0209]

@soltysh : Good day! Please could you update if there is any requirement for docs on this piece of work for 1.19 Release?

[soltysh]

@divya-mohan0209 we don't have any concrete, yet but we're working. we're still about 2.5 weeks from code freeze and we're aware of that :)

[knight42]

/cc

@soltysh Hi! I am working on this, would send a PR ASAP.

[palnabarun]

Hi @soltysh -- just wanted to check in about the progress of the enhancement. Feel free to link here all the implementation PRs whenever ready.

The release timeline has been revised recently, more details of which can be found here.

Please let me know if you have any questions. :slightly_smiling_face:

---

The revised release schedule is:

• Thursday, July 9th: Week 13 - Code Freeze
• Thursday, July 16th: Week 14 - Docs must be completed and reviewed
• Tuesday, August 25th: Week 20 - Kubernetes v1.19.0 released

[palnabarun]

Hi @soltysh :wave:, is https://github.com/kubernetes/kubernetes/pull/92507 the only PR for this feature?

Thank you. :slightly_smiling_face:

[soltysh]

Yeah, it's still being worked on and I doubt we'll merge this for 1.19, as I wrote in slack. I'm moving this to 1.20.

/milestone v1.20

[palnabarun]

@soltysh -- Thank you for the update. :+1:

We will look forward to seeing the enhancement in 1.20. :slightly_smiling_face:

[kikisdeliveryservice]

Hi @soltysh !

Enhancements Lead here, do you still intend to target this for stable in 1.20?

Thanks!
Kirsten

[kikisdeliveryservice]

Moving this to tracked since after digging I see that there is an active PR: https://github.com/kubernetes/kubernetes/pull/92507

[MorrisLaw]

Hi @soltysh, do we still plan to target this for stable in 1.20? I notice there is a do-not-merge/hold tag on the previously mentioned PR: https://github.com/kubernetes/kubernetes/pull/92507.

Also, time permitting, can we please update the KEP to the new format detailed here https://github.com/kubernetes/enhancements/tree/master/keps/NNNN-kep-template? The Enhancements Freeze deadline for that update would be October 6th.

Thank you everyone for your work on this!

Regards,
Jeremy

[soltysh]

Hi @soltysh, do we still plan to target this for stable in 1.20? I notice there is a do-not-merge/hold tag on the previously mentioned PR: kubernetes/kubernetes#92507.

This is in-progress, it's currently waiting for the repo creation which should happen in the next few days.

Overall - yes, once the above merges we're hoping to split the code that's blocking us and should move to staging fully.

/milestone v1.20

[soltysh]

Updated KEP to the new template is in https://github.com/kubernetes/enhancements/pull/2027

[MorrisLaw]

Thank you for updating the KEP to the new format @soltysh ! I just saw that it merged 💯

[MorrisLaw]

Hi @soltysh ,

Since your Enhancement is scheduled to be in 1.20, please keep in mind the important upcoming dates:
Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline
Thursday, Nov 12th: Week 9 - Code Freeze

As a reminder, please link all of your k/k PR as well as docs PR to this issue so we can track them.

Regards,
Jeremy

[soltysh]

Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline

No docs are required for this particular enhacement. This is only about internal code organization.

[SomtochiAma]

Hello @soltysh @seans3 @pwittrock, 1.20 Docs shadow here 👋🏽.
Does this enhancement work planned for 1.20 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.20 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Nov 6th

Also take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

[soltysh]

Like mentioned before, we're not planning any doc changes, this is modifying internal code.

[SomtochiAma]

All right. Noted!

[annajung]

Hi @soltysh

Please keep in mind the important upcoming dates:

• ~Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline~ Docs Not Required
• Thursday, Nov 12th: Week 9 - Code Freeze
• ~Monday, Nov 23rd: Week 11 - Docs PR Ready for Review~ Docs Not Required

As a reminder, please link all of your k/k PR as well as docs PR to this issue for the release team to track.

[soltysh]

• shared code to component-helpers - ~https://github.com/kubernetes/kubernetes/pull/96145~
• remaining bits to staging/k8s.io/kubectl - https://github.com/kubernetes/kubernetes/pull/96190
• seperate kubectl-convert command - https://github.com/kubernetes/kubernetes/pull/96190

[MorrisLaw]

Hey @soltysh 👋

Friendly reminder that, in order to make the 1.20 milestone, we have to have k/k PR #96190 in by code freeze or an exception will need to be made.

Important upcoming date:

• Thursday, Nov 12th: Week 9 - Code Freeze

Thank you!

[kikisdeliveryservice]

@soltysh looks like kubernetes/kubernetes#96190 is fully approved and passing, does it need to be rekicked or something to merge? Actually looking closer it's rerunning bazel test I guess..

[kikisdeliveryservice]

The above PR merged! Looks like this is finished for 1.20 code freeze. :+1: