Enhancements: support generators and transformers plugins in `kubectl kustomize` and `kubectl -k`

Created on 24 Apr 2019  ·  36Comments  ·  Source: kubernetes/enhancements

Enhancement Description

This is to revendor Kustomize into kubectl with generator and transformer plugin support.

_Please to keep this description up to date. This will help the Enhancement Team track efficiently the evolution of the enhancement_

kinfeature sicli stagbeta trackeno

All 36 comments

/sig cli

/kind feature

/milestone v1.15
/stage stable

/assign @Liujingfang1 @monopole

@Liujingfang1 and @monopole we're doing a KEP review for enhancements to be included in the Kubernetes v1.15 milestone. After reviewing your KEP, it's currently missing test plan and graduation criteria which are required information per the KEP Template. Please update the KEP to include the required information before the Kubernetes 1.15 Enhancement Freeze date of 4/30/2019.

@mrbobbytables I updated it to Alpha release in 1.15.

Thanks!
/remove-stage stable
/stage alpha

opened a PR for adding test plan and graduation criteria #1023

Hey @monopole @Liujingfang1 I'm the v1.15 docs shadow.

Does this enhancement require any new docs (or modifications)?

Just a friendly reminder we're looking for a PR against k/website (branch dev-1.15) due by Friday, May 31st. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions!

Hi @Liujingfang1 . Code Freeze is Thursday, May 30th 2019 @ EOD PST. All enhancements going into the release must be code-complete, including tests, and have docs PRs open.

Please list all current k/k PRs so they can be tracked going into freeze. If the PRs aren't merged by freeze, this feature will slip for the 1.15 release cycle. Only release-blocking issues and PRs will be allowed in the milestone.

If you know this will slip, please reply back and let us know. Thanks!

We will postpone this to v1.16.

/milestone clear

Hi @Liujingfang1 @monopole , I'm the 1.16 Enhancement Lead. Is this feature going to be graduating alpha/beta/stable stages in 1.16? Please let me know so it can be added to the 1.16 Tracking Spreadsheet. If not's graduating, I will remove it from the milestone and change the tracked label.

Once coding begins or if it already has, please list all relevant k/k PRs in this issue so they can be tracked properly.

Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thank you.

@kacole2 Thank you for checking with me. Since currently kubectl is moving into staging and will be eventually moved out of core. We don't plan to make this process more complicated by integrating new kustomize version into it. We will postpone this feature.

Hello @Liujingfang1 -- 1.17 Enhancement Shadow here! 🙂

I see your comment above regarding postponing the feature, however I wanted to reach out to see if your plans have changed, and if this enhancement will be graduating to alpha/beta/stable in 1.17?


Please let me know so that this enhancement can be added to 1.17 tracking sheet.

Thank you!

🔔Friendly Reminder

The current release schedule is

  • Monday, September 23 - Release Cycle Begins
  • Tuesday, October 15, EOD PST - Enhancements Freeze
  • Thursday, November 14, EOD PST - Code Freeze
  • Tuesday, November 19 - Docs must be completed and reviewed
  • Monday, December 9 - Kubernetes 1.17.0 Released

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

/remove-lifecycle stale

Hey there @Liujingfang1 -- 1.18 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating to beta in 1.18 or having a major change in its current level?

The current release schedule is:

Tuesday, January 28th EOD PST - Enhancements Freeze
Thursday, March 5th, EOD PST - Code Freeze
Monday, March 16th - Docs must be completed and reviewed
Tuesday, March 24th - Kubernetes 1.18.0 Released

To be included in the release, this enhancement must have a merged KEP in the implementable status.

The KEP must also have graduation criteria and a Test Plan defined.

If you would like to include this enhancement, once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!

Hey @Liujingfang1 -- 1.18 Enhancements team shadow here. We're about 5 days away from Enhancement Freeze on Jan 28th. Wanted to check to see if you'll be graduating this to beta in 1.18?

@helayoty We don't have plan for this in 1.18. Thanks for reaching out.

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

/remove-lifecycle stale

Hey there @Liujingfang1, @monopole , 1.19 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating in 1.19?

In order to have this part of the release:

  1. The KEP PR must be merged in an implementable state
  2. The KEP must have test plans
  3. The KEP must have graduation criteria.

The current release schedule is:

  • Monday, April 13: Week 1 - Release cycle begins
  • Tuesday, May 19: Week 6 - Enhancements Freeze
  • Thursday, June 25: Week 11 - Code Freeze
  • Thursday, July 9: Week 14 - Docs must be completed and reviewed
  • Tuesday, August 4: Week 17 - Kubernetes v1.19.0 released

If you do, I'll add it to the 1.19 tracking sheet (http://bit.ly/k8s-1-19-enhancements). Once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!

Hi @harshanarayana I don't think it will graduate in 1.19. Thank you for checking with us.

Hi @Liujingfang1, thank you for following up with an update. I have updated the tracking sheet accordingly. 👍

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

This will happen automatically when kubernetes-sigs/kustomize#1500 closes.
Currently blocked by kubernetes-sigs/kustomize#2506, its being actively worked on.
Targeting 1.20

/remove-lifecycle rotten

/milestone v1.20

Hi @monopole @Liujingfang1

Enhancements Lead here. To confirm is this moving to beta in 1.20?

Thanks!
Kirsten

Yes it is

On Sun, Sep 13, 2020 at 2:38 PM Kirsten notifications@github.com wrote:

Hi @monopole https://github.com/monopole @Liujingfang1
https://github.com/Liujingfang1

Enhancements Lead here. To confirm is this moving to beta in 1.20?

Thanks!
Kirsten


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/enhancements/issues/993#issuecomment-691729249,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAWK4PDWLN34EWY2PVY4A7TSFU3WBANCNFSM4HIGLNZQ
.

Hi @monopole @Liujingfang1! Excited to hear this enhancement is planned for beta in 1.20. Wanted to check in on a few things as the Enhancements Freeze is coming up next Tuesday, 10/6.

  1. It appears that there is a test plan, however it is lacking detail. Is there anything that can be added to provide clarity around the required integration tests?
  2. There is nothing under the "Risks and Mitigations" section which should be completed
  3. This KEP is currently using the retired KEP template, if possible please update to use the new template before 10/6

Feel free to reach out with any comments or questions!

Thanks,
Kendall (1.20 Enhancements Team)

Hi @monopole @Liujingfang1 - a quick reminder that the Enhancements Freeze is tomorrow, 10/6. The Risk and Mitigations section is considered a required section, therefore this should be completed. Also pertaining to the comment above, please add clarity to the test plan or provide an explanation as to why this is sufficient. These changes need to be merged by EOD tomorrow in order for this KEP to be considered in release 1.20. Please reach out should you have any questions!

Thanks,

Kendall Roden
Enhancements Team 1.20

This was temporarily destaffed so won't make it into 1.20.

We did have a meeting about it last Thursday, are re-staffing it and now the target is 1.21

Thanks Kendall! Please just close this.

@monopole Thanks for the update! Just to confirm, we will keep the issue open but mark it as untracked for the 1.20 release and will have the enhancement team check back in during the 1.21 release :) @kikisdeliveryservice has removed the tracking label for 1.20!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

dekkagaijin picture dekkagaijin  ·  9Comments

andrewsykim picture andrewsykim  ·  12Comments

wlan0 picture wlan0  ·  9Comments

justinsb picture justinsb  ·  11Comments

wojtek-t picture wojtek-t  ·  12Comments