Enhancements: ExecutionHook

[xing-yang]

Enhancement Description

• One-line enhancement description (can be used as a release note):

Provide ExecutionHook API design to trigger hook commands in the containers for different use cases, e.g., volume snapshot and application snapshot. 

• Kubernetes Enhancement Proposal PR: https://github.com/kubernetes/enhancements/pull/705
• Kubernetes Enhancement Proposal: 20190120-execution-hook-design
• Primary contact (assignee): @jingxu97, @xing-yang
• Responsible SIGs: sig-storage, sig-apps
• Reviewers:
  
  
  
  • "@saad-ali"
  
  
  • "@thockin"
  
  
• Approvers:
  
  
  
  • "@thockin"
  
  
  • "@saad-ali"
  
  
• Enhancement target (which target equals to which milestone):
  
  
  
  • Alpha release target (x.y): 1.18
  
  
  • Beta release target (x.y): 1.19
  
  
  • Stable release target (x.y): 1.20
  
  

[xing-yang]

/sig storage

[xing-yang]

/kind feature

[xing-yang]

/assign @xing-yang

[xing-yang]

/assign @jingxu97

[kacole2]

/milestone v1.15
/stage alpha

[craiglpeters]

@jingxu97 and @xing-yang, Kubernetes 1.15 Enhancement Freeze is 4/30/2019. To be included in the Kubernetes 1.15 milestone, KEPs are required to be merged and in an "Implementable" state with proper test plans and graduation criteria. Please submit any PRs needed to make this KEP adhere to inclusion criteria. If this will slip from the 1.15 milestone, please let us know so we can make appropriate tracking changes.

[xing-yang]

@craiglpeters We are trying to get the KEP merged by 4/30.

[christianh814]

Hey @jingxu97 , @xing-yang I'm the v1.15 docs shadow.

Does this enhancement require any new docs (or modifications)?

Just a friendly reminder we're looking for a PR against k/website (branch dev-1.15) due by Friday, May 31st. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions!

[xing-yang]

@christianh814 Sure, I'll submit a placeholder PR soon. Thanks!

[xing-yang]

Hi @christianh814, a placeholder doc PR is submitted: https://github.com/kubernetes/website/pull/14560

[mrbobbytables]

Hey there @xing-yang . Code Freeze is Thursday, May 30th 2019 @ EOD PST. All enhancements going into the release must be code-complete, including tests, and have docs PRs open.

Please list all current k/k PRs so they can be tracked going into freeze. If the PRs aren't merged by freeze, this feature will slip for the 1.15 release cycle. Only release-blocking issues and PRs will be allowed in the milestone.

If you know this will slip, please reply back and let us know. Thanks!

[xing-yang]

Hi @mrbobbytables The code for ExecutionHook will not be in-tree so it does not have to be merged by May 30th. Thanks!

[mrbobbytables]

@xing-yang Would you mind linking to the PRs even if its not in-tree? It may not need to be in by the 30th, but they're something that should be tracked for the Enhancement.

Thanks!

[xing-yang]

@mrbobbytables, right now the code is still in my private repo here: https://github.com/xing-yang/execution-hook. We need to create a new repo under kubernetes-sigs. We have not finalized on a repo name. I opened an issue to track this and we need to get the repo created as soon as possible: https://github.com/kubernetes-csi/external-snapshotter/issues/125

[mrbobbytables]

Great, thank you for letting us know! :)

[xing-yang]

Since development work for ExecutionHook is out-of-tree, we don't need to create a doc in-tree. So I just closed https://github.com/kubernetes/website/pull/14560.

[kacole2]

Hi @jingxu97 @xing-yang, I'm the 1.16 Enhancement Lead. Is this feature going to be graduating alpha/beta/stable stages in 1.16? Please let me know so it can be added to the 1.6 Tracking Spreadsheet. If not's graduating, I will remove it from the milestone and change the tracked label.

Once coding begins or if it already has, please list all relevant k/k PRs in this issue so they can be tracked properly.

Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thank you.

[xing-yang]

@kacole2 We will try to make it Alpha in 1.16. Please add it to the 1.16 tracking spreadsheet. Thanks!

[daminisatya]

@xing-yang
I'm one of the v1.16 docs shadows.
Does this enhancement (or the work planned for v1.16) require any new docs (or modifications to existing docs)? If not, can you please update the 1.16 Enhancement Tracker Sheet (or let me know and I’ll do so)

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.16) due by Friday, August 23rd, it can just be a placeholder PR at this time. Let me know if you have any questions!

[xing-yang]

@daminisatya This does not require any doc changes. Can you please update the 1.16 Enhancement Tracker Sheet? Thanks!

[kacole2]

@xing-yang code freeze for 1.16 is on Thursday 8/29. Are there any outstanding k/k PRs that still need to be merged for this to go Alpha? I don't see any listed here.

[xing-yang]

@kacole2 This is delayed and won't make it into 1.16. Thanks.

[palnabarun]

Hey there @xing-yang , 1.17 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating to alpha in 1.17?

The current release schedule is:

• Monday, September 23 - Release Cycle Begins
• Tuesday, October 15, EOD PST - Enhancements Freeze
• Thursday, November 14, EOD PST - Code Freeze
• Tuesday, November 19 - Docs must be completed and reviewed
• Monday, December 9 - Kubernetes 1.17.0 Released

If you do, I'll add it to the 1.17 tracking sheet (https://bit.ly/k8s117-enhancement-tracking). Once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!

[xing-yang]

Hi @palnabarun, I'll let you know soon. Thanks.

[palnabarun]

Awesome! :)

Let us know of the plans before the Enhancements Freeze.

[prydonius]

Hi @palnabarun, I'm working with @xing-yang and I'd like to pick up work on this enhancement for 1.17. Can we please add it to the tracking sheet? Thanks!

[xing-yang]

Hi @palnabarun, please help track this for 1.17. Thanks!

[palnabarun]

@prydonius @xing-yang -- Unfortunately the deadline for the 1.17 Enhancement freeze has passed and the KEP is still missing a test plan. For now, this is being removed from the milestone and 1.17 tracking sheet. If there is a need to get this in, please file an enhancement exception.

[palnabarun]

/assign prydonius

[mattfarina]

/assign @prydonius
/sig apps

@prydonius if this is a SIG sponsored project in the kubernetes-sigs org does the work need to revolve around the k8s release schedule? Or, am I missing something.

[xing-yang]

WIP PR: https://github.com/kubernetes-sigs/execution-hook/pull/2

[helayoty]

Hey there @xing-yang -- 1.18 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating to beta in 1.18 or having a major change in its current level?

The current release schedule is:

Tuesday, January 28th EOD PST - Enhancements Freeze
Thursday, March 5th, EOD PST - Code Freeze
Monday, March 16th - Docs must be completed and reviewed
Tuesday, March 24th - Kubernetes 1.18.0 Released

To be included in the release, this enhancement must have a merged KEP in the implementable status.

The KEP must also have graduation criteria and a Test Plan defined.

If you would like to include this enhancement, once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!

[xing-yang]

Thanks @helayoty! We are trying to get it to Alpha in 1.18. The KEP is merged (https://github.com/kubernetes/enhancements/blob/master/keps/sig-storage/20190120-execution-hook-design.md) but implementation is WIP.

[xing-yang]

@ashish-amarnath is working on it. See PRs here:
https://github.com/kubernetes-sigs/execution-hook/pull/5
https://github.com/kubernetes-sigs/execution-hook/pull/4

[helayoty]

Thank you @xing-yang for the prompt response. Kindly if you please update the issue with all k/k PRs when it possible.

[helayoty]

/milestone v1.18

[ashish-amarnath]

/cc @ashish-amarnath

[jeremyrickard]

@xing-yang as we were reviewing the KEPs for 1.18 last night, we noticed that this one is missing test plans on the KEP. We're going to need to bump this from the release, unless you can add some test plan info to the KEP and file an Exception Request. Apologies for the late notice!

[jeremyrickard]

/milestone clear

[xing-yang]

@jeremyrickard I see. I'll add test plan to the KEP. Thanks!

[xing-yang]

Submitted a PR to add the test plan: https://github.com/kubernetes/enhancements/pull/1530

[jeremyrickard]

@xing-yang thanks for opening the PR! You'll also need to submit an Exception Request to get it back into the release. See this link for the process: https://github.com/kubernetes/sig-release/blob/master/releases/EXCEPTIONS.md

[jeremyrickard]

Hey @xing-yang,

In order to make it back into the 1.18 release, you need to file an exception request TODAY. Friendly reminder: the instructions are here: https://github.com/kubernetes/sig-release/blob/master/releases/EXCEPTIONS.md

cc: @alejandrox1 @mrbobbytables @onlydole

[xing-yang]

Hi @jeremyrickard, there were some comments came up during the code review. It means we'll have to have a design discussion to decide which direction to go. So we won't add this back to 1.18. Thanks!

[onlydole]

Thank you, @xing-yang!

[humblec]

@xing-yang Do we have a sync up call scheduled for driving this forward ? if yes, I would like to contribute to this through the same.

[xing-yang]

@humblec we don't have a call scheduled yet. I'm working on a proposal to address the review comments but it is not ready yet. Will keep you updated.

By the way, if you are interested in helping with moving the volume snapshot feature to GA, this ExecutionHook feature is not required for that.

[xing-yang]

@humblec and @ashish-amarnath, I added ExecutionHook to tomorrow's Data Protection WG agenda to discuss: https://docs.google.com/document/d/15tLCV3csvjHbKb16DVk-mfUmFry_Rlwo-2uG6KNGsfw/edit#

[humblec]

@humblec and @ashish-amarnath, I added ExecutionHook to tomorrow's Data Protection WG agenda to discuss: https://docs.google.com/document/d/15tLCV3csvjHbKb16DVk-mfUmFry_Rlwo-2uG6KNGsfw/edit#

Thanks @xing-yang ! will catch up on this.

[ashish-amarnath]

/assign ashish-amarnath

[palnabarun]

Hi @xing-yang @humblec @ashish-amarnath -- 1.19 Enhancements Lead here, I wanted to check in if you think this enhancement would graduate in 1.19?

In order to have this part of the release:

1. The KEP PR must be merged in an implementable state
2. The KEP must have test plans
3. The KEP must have graduation criteria.

---

The current release schedule is:

• Monday, April 13: Week 1 - Release cycle begins
• Tuesday, May 19: Week 6 - Enhancements Freeze
• Thursday, June 25: Week 11 - Code Freeze
• Thursday, July 9: Week 14 - Docs must be completed and reviewed
• Tuesday, August 4: Week 17 - Kubernetes v1.19.0 released

[xing-yang]

@palnabarun We actually need to do some re-design on this. So we won't track this for 1.19 yet. Thanks!

[palnabarun]

Thank you @xing-yang for the updates. I will update the tracking sheet accordingly. :+1:

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[xing-yang]

/remove-lifecycle stale

[kikisdeliveryservice]

Hi again @xing-yang :smile:

Any plans for this in 1.20?

Thanks!
Kirsten

[xing-yang]

Hi @kikisdeliveryservice,

The plan is to go with a different approach as described here: https://github.com/kubernetes/enhancements/issues/1977. If that goes through, we won't need this one any more.

Thanks!
Xing

[kikisdeliveryservice]

Makes sense to me!

[kikisdeliveryservice]

Just a ping that if you intend to use this one in 1.20, it would need test plans added by Enhancements Freeze October 6th.

Seems like 1977 is under heavy discussion though, but if you do end up wanting to move forward with this one, let me know.

[xing-yang]

Thanks @kikisdeliveryservice for the reminder! I did submit a PR for adding test plans a while ago but there's no plan for this in 1.20 so that PR won't be reviewed for now.

[kikisdeliveryservice]

@xing-yang ahh good to know, just wanted to double check :smile: