Enhancements: maxUnavailable for StatefulSets

[krmayankk]

Implement maxUnavailable for StatefulSets

• One-line enhancement description (can be used as a release note):
• Kubernetes Enhancement Proposal: (https://github.com/kubernetes/enhancements/pull/678) / https://github.com/kubernetes/enhancements/blob/master/keps/sig-apps/20190226-maxunavailable-for-statefulsets.md
• Primary contact (assignee): @krmayankk
• Responsible SIGs: sig-apps
• Enhancement target (which target equals to which milestone):
  
  
  
  • Alpha release target (1.15)
  
  
  • Beta release target (1.16)
  
  
  • Stable release target (TBD)
  
  

_Please to keep this description up to date. This will help the Enhancement Team track efficiently the evolution of the enhancement_

[krmayankk]

/sig auth

[krmayankk]

/assign @krmayankk

[krmayankk]

/milestone v1.15

[kacole2]

/stage alpha

[mrbobbytables]

@krmayankk should this be sig auth? The KEP itself refers to sig-apps.

[krmayankk]

@mrbobbytables no this is specific to sig-apps

[mrbobbytables]

@krmayankk it has the responsible sig list as sig-auth 'in the post and is labeled with auth.

• Responsible SIGs: sig-auth

Would you mind updating the issue?

Thanks!

/remove-sig auth
/sig apps

[craiglpeters]

@krmayankk, Kubernetes 1.15 Enhancement Freeze is 4/30/2019. To be included in the Kubernetes 1.15 milestone, KEPs are required to be in an "Implementable" state with proper test plans and graduation criteria. Please submit any PRs needed to make this KEP adhere to inclusion criteria. If this will slip from the 1.15 milestone, please let us know so we can make appropriate tracking changes.

[krmayankk]

@craiglpeters here is the PR https://github.com/kubernetes/enhancements/pull/1010 I will try to see if i can get some decision on this , in the next 1-2 days. If yes, i can try an exception for this enhancement to be implementable in 1.15. If no decision is nearing, will ask you to remove it from tracking.

[craiglpeters]

@krmayankk, Enhancement Freeze for Kubernetes 1.15 has passed and this did not meet the deadline. This is now being removed from the 1.15 milestone and the tracking sheet. If there is a need for this to be in 1.15, please file an Enhancement Exception. Thank you.

[craiglpeters]

/milestone clear

[craiglpeters]

@krmayankk please work to get the KEP to the implementable state quickly

/milestone v1.15

[draveness]

Is this enhancement will be included in milestone v1.15? I'd like to take this if it becomes implementable.

[kacole2]

This is still being tracked but I don't see an exception request submitted nor the KEP in an implementable state. @craiglpeters what's the status of this?

[craiglpeters]

@kacole2 an exception request was filed on May 1st. However this still is not in the implementable state, so I recommend moving out of 1.15 tracking.

[kacole2]

/milestone clear

[kacole2]

Hi @draveness @krmayankk , I'm the 1.16 Enhancement Lead. Is this feature going to be graduating alpha/beta/stable stages in 1.16? Please let me know so it can be added to the 1.16 Tracking Spreadsheet. If not's graduating, I will remove it from the milestone and change the tracked label.

Once coding begins or if it already has, please list all relevant k/k PRs in this issue so they can be tracked properly.

Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thank you.

[krmayankk]

@kacole2 yes i am planning to rollout an alpha in 1.16 for this feature.

[daminisatya]

@krmayankk

I'm one of the v1.16 docs shadows.
Does this enhancement (or the work planned for v1.16) require any new docs (or modifications to existing docs)? If not, can you please update the 1.16 Enhancement Tracker Sheet (or let me know and I’ll do so)

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.16) due by Friday, August 23rd, it can just be a placeholder PR at this time. Let me know if you have any questions!

[krmayankk]

@daminisatya we do not not require any docs for this feature since this is an alpha feature. So we are good.

Also I do realize, that you and are also from Salesforce :-)

[krmayankk]

https://github.com/kubernetes/enhancements/pull/1010

[kacole2]

@krmayankk code freeze for 1.16 is on Thursday 8/29. Are there any outstanding k/k PRs that still need to be merged for this to go Alpha? I see that #1010 is about the KEP. Is it safe to assume there will be no code merged for 1.16 in k/k and this should be bumped from the 1.16 milestone?

[kacole2]

@krmayankk today is code freeze. are there any outstanding PRs? If I do not receive a response this will be dropped from v1.16

[krmayankk]

@kacole2 please move this to 1.17. My PR is almost ready but I cant get it in by today :-)

[kcmartin]

Hello @krmayankk -- 1.17 Enhancement Shadow here! 🙂

I wanted to reach out to see if this enhancement will be graduating to alpha/beta/stable in 1.17?


Please let me know so that this enhancement can be added to 1.17 tracking sheet.

Thank you!

🔔Friendly Reminder

The current release schedule is

• Monday, September 23 - Release Cycle Begins
• Tuesday, October 15, EOD PST - Enhancements Freeze
• Thursday, November 14, EOD PST - Code Freeze
• Tuesday, November 19 - Docs must be completed and reviewed
• Monday, December 9 - Kubernetes 1.17.0 Released

[krmayankk]

@kcmartin yes this will be marked alpha in 1.17 . there is active PR here https://github.com/kubernetes/kubernetes/pull/82162

[kcmartin]

/milestone v1.17

[daminisatya]

Hello @krmayankk again 👋

I just want to confirm again that we do not need any docs for the alpha version?

( And Aloha from Salesforce :D )

[krmayankk]

Aloha from Salesforce :-), we dont need any docs for the alpha version

[kcmartin]

Hi @krmayankk

Enhancements Shadow from the 1.17 Release Team again. We are very near to Code Freeze (Nov 14th) for this release cycle. Just checking in about the progress of this enhancement. I see that kubernetes/kubernetes#82162 was filed in relation to this. Is there any other PR related to this enhancement? If yes, can you please link them here?

Thank you in advance 😄

[kcmartin]

IMPORTANT PLEASE READ
Hi @krmayankk tomorrow is code freeze for the 1.17 release cycle. It looks like the k/k PRs have not yet been merged. We're flagging as At Risk in the 1.17 Enhancement Tracking Sheet.

Do you think they will be merged by the EoD of the 14th (Thursday)? After that point, only release-blocking issues and PRs will be allowed in the milestone with an exception.

[helayoty]

Hey there @krmayankk -- 1.18 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating in 1.18 or having a major change in its current level?

Kindly if you can confirm what is the current status for this feature (alpha/beta) as I'm not sure from the history about the status.

If you can update the issue with all opening PRs so they can be tracked.

The current release schedule is:

Tuesday, January 28th EOD PST - Enhancements Freeze
Thursday, March 5th, EOD PST - Code Freeze
Monday, March 16th - Docs must be completed and reviewed
Tuesday, March 24th - Kubernetes 1.18.0 Released

To be included in the release, this enhancement must have a merged KEP in the implementable status.

Thanks!

[krmayankk]

@helayoty this will move to alpha in 1.18. API PR is here https://github.com/kubernetes/kubernetes/pull/82162

[helayoty]

Thanks @krmayankk for the update.

[helayoty]

/milestone v1.18

[savitharaghunathan]

Hi, @krmayankk :) 1.18 docs shadow here. I noticed that you had mentioned before that no docs required for alpha state. Is it still the case?

If it needs docs, just a friendly reminder we're looking for a PR against k/website (branch dev-1.18) due by Friday, Feb 28th, it can just be a placeholder PR at this time. Let me know if you have any questions!

Thanks,
Savitha

[savitharaghunathan]

Hi @krmayankk , Can you confirm on the status of docs? TIA

[savitharaghunathan]

Hi @krmayankk , Gentle reminder - We're approaching the deadline for docs placeholder PR, I'd like to confirm whether you will need docs for this enhancement.

Thanks!

[krmayankk]

@savitharaghunathan no docs for alpha

[jeremyrickard]

Hey @krmayankk

Friendly reminder,we are getting close to code freeze on 05 March 2020. I see that kubernetes/kubernetes#82162 hasn't merged yet. Are you still working toward this for 1.18?

[helayoty]

Hi @krmayankk We're only a few days out from code freeze now. It does not look like your PR has merged yet, are you still feeling like you're on track for code freeze for this enhancement? Do you want to defer this to 1.19 based on the reviewer bandwidth? Or try and make a push?

[helayoty]

/milestone clear

[helayoty]

The Code freeze is in effect now. You may need to file an exception.

[palnabarun]

Hi @krmayankk -- 1.19 Enhancements Lead here, I wanted to check in if you think this enhancement would graduate in 1.19?

---

The current release schedule is:

• Monday, April 13: Week 1 - Release cycle begins
• Tuesday, May 19: Week 6 - Enhancements Freeze
• Thursday, June 25: Week 11 - Code Freeze
• Thursday, July 9: Week 14 - Docs must be completed and reviewed
• Tuesday, August 4: Week 17 - Kubernetes v1.19.0 released

[palnabarun]

Hi @krmayankk, pinging back again as a reminder for the above.

[palnabarun]

Hi @krmayankk,

Tomorrow, Tuesday May 19 EOD Pacific Time is Enhancements Freeze

Will this enhancement be part of the 1.19 release cycle?

[palnabarun]

@krmayankk -- Unfortunately, the deadline for the 1.19 Enhancement freeze has passed. For now, this is being removed from the milestone and 1.19 tracking sheet. If there is a need to get this in, please file an enhancement exception.

[onitake]

Is this still being worked on?
The feature was filed more than a year ago, but there was no progress since February.
I'm very much interested to see this enhancement and minReadySeconds in k8s soon.

[krmayankk]

@onitake yes, i just updated the PR https://github.com/kubernetes/kubernetes/pull/82162 with final missing tests that were requested long back. Currently working on the implementation. Should have a PR by next week

[krmayankk]

The implementation and UT have been updated. Waiting for review from the sigs

[krmayankk]

@kow3ns @janetkuo @dims @liggitt who should talk to get this on milestone 1.20 ?

[liggitt]

looks like @lavalamp is the API reviewer. the sig leads own milestone planning for component work

[kikisdeliveryservice]

Hi @krmayankk

Enhancements Lead here. I see that you're currently trying to figure out whether this is in 1.20. Please keep us updated to this KEP's status as you get more info.

Thanks!
Kirsten

[kikisdeliveryservice]

Hi @krmayankk

Any update on this for 1.20?

As a note, since this KEP was filed the template has changed to include a Production Readiness Review section. If you could please update and include the missing sections noted above that would be great. See for ref https://github.com/kubernetes/enhancements/tree/master/keps/NNNN-kep-template

Best,
Kirsten

[krmayankk]

@kikisdeliveryservice yes please mark it for 1.20, i will start the kep update with readiness review section . implementation PR is here https://github.com/kubernetes/kubernetes/pull/82162
FYI @kow3ns @lavalamp

[kikisdeliveryservice]

Thanks @krmayankk just to confirm this is alpha right?

[kendallroden]

Hi @krmayankk it looks as though the KEP is in an acceptable state for inclusion in 1.20 release. The Enhancement Freeze is tomorrow, 10/6. However, just a reminder it is still not in the updated KEP format with the Production Readiness Review section as referenced above. I would recommend prioritizing this update moving forward. Please reach out with any questions!

Thanks so much,

Kendall
Enhancements Team (1.20 release)

[kendallroden]

Hi @krmayankk ,

Since your Enhancement is scheduled to be in 1.20, please keep in mind the important upcoming dates:
Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline
Thursday, Nov 12th: Week 9 - Code Freeze

As a reminder, please link all of your k/k PR as well as docs PR to this issue so we can track them.

Thanks so much,

Kendall

[SomtochiAma]

Hello @krmayankk, 1.20 Docs shadow here 👋🏽.
Does this enhancement work planned for 1.20 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.20 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Nov 6th

Also take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

[SomtochiAma]

Hi @krmayankk
The docs placeholder deadline is almost here. Please make sure to create a placeholder PR against the dev-1.20 branch in the k/website before the deadline

Also, please keep in mind the important upcoming dates:

• Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline
• Thursday, Nov 12th: Week 9 - Code Freeze
• Monday, Nov 23rd: Week 11 - Docs PR Ready for Review
  As a reminder, please link all of your k/k PR as well as docs PR to this issue for the release team to track.

Thank you!

[krmayankk]

@SomtochiAma https://github.com/kubernetes/website/pull/24923

[kendallroden]

@krmayankk I see you have linked the placeholder PR for docs, and I see kubernetes/kubernetes#82162 is referenced for implementation, can you confirm this is the only one that needs to be tracked for this Thursday's code freeze? Keep in mind that if the PR is not merged by the deadline on Nov. 12th, you will need to file an exception to be part of the milestone!

Thanks,

Kendall

[kikisdeliveryservice]

Hi @krmayankk

Code Freeze is now in effect. Your PR is still unmerged, with no approvals. If you believe this should be in the 1.20 Release, please file an Exception.

Best,
Kirsten