Enhancements: Add Watch Bookmarks support

[wojtek-t]

Enhancement Description

• One-line enhancement description (can be used as a release note): Add support for watch bookmarks to reduce load on kube-apiserver
• Kubernetes Enhancement Proposal: KEP: watch bookmarks
• Primary contact (assignee): wojtek-t
• Responsible SIGs: sig-apimachinery, sig-scalability
• Enhancement target (which target equals to which milestone):
  
  
  
  • Alpha release target (1.15)
  
  
  • Beta release target (1.16)
  
  
  • Stable release target (1.17)
  
  

_Please to keep this description up to date. This will help the Enhancement Team track efficiently the evolution of the enhancement_

[k8s-ci-robot]

@wojtek-t: There are no sig labels on this issue. Please add a sig label.

A sig label can be added by either:

1. mentioning a sig: @kubernetes/sig-<group-name>-<group-suffix>
   e.g., @kubernetes/sig-contributor-experience-<group-suffix> to notify the contributor experience sig, OR

2. specifying the label manually: /sig <group-name>
   e.g., /sig scalability to apply the sig/scalability label

Note: Method 1 will trigger an email to the group. See the group list.
The <group-suffix> in method 1 has to be replaced with one of these: _bugs, feature-requests, pr-reviews, test-failures, proposals_

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kacole2]

Thanks @wojtek-t. When coding begins please drop all k/k PRs here for tracking purposes.

/stage alpha

[wojtek-t]

Ref https://github.com/kubernetes/kubernetes/issues/73585

[mrbobbytables]

@wojtek-t we're doing a KEP review for enhancements to be included in the Kubernetes v1.15 milestone. After reviewing your KEP, it's currently missing a test plan which is required information per the KEP Template. Please update the KEP to include the required information before the Kubernetes 1.15 Enhancement Freeze date of 4/30/2019.

[wojtek-t]

https://github.com/kubernetes/enhancements/pull/1021 is out for review

[wojtek-t]

@mrbobbytables - merged.

[mrbobbytables]

Awesome. Thanks!

[christianh814]

Hey @wojtek-t I'm the v1.15 docs shadow.

Does this enhancement require any new docs (or modifications)?

Just a friendly reminder we're looking for a PR against k/website (branch dev-1.15) due by Friday, May 31st. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions!

[wojtek-t]

@christianh814 Doc PR has been opened: https://github.com/kubernetes/website/pull/14379

[wojtek-t]

@christianh814 - Doc PR has been merged.

[wojtek-t]

I would like to move it to Beta in 1.16. I already sent out a minor update to testing plan for Beta and will be pushing that in the meantime.

/stage beta

[mrbobbytables]

Hey there @wojtek-t, I'm one of the 1.16 Enhancement Shadows. It looks like you're ahead of the game with flagging as beta / linking to k/k PR :)

Just as a general reminder:
Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thanks!

[wojtek-t]

As described in KEP, the criteria for graduation was to observe the expected drop on our graphs.
Here they are:

Pods:

Nodes:

Secrets:

All coming from 5k-node tests.
So we basically observe the expected drop and the feature will get to Beta in 1.16.

We're already code-complete and the only missing thing is to update documentation that the feature is Beta, not Alpha.

[dims]

Holy Moly, that's awesome graphs! thanks @wojtek-t

[daminisatya]

@wojtek-t

I'm one of the v1.16 docs shadows.
Does this enhancement (or the work planned for v1.16) require any new docs (or modifications to existing docs)? If not, can you please update the 1.16 Enhancement Tracker Sheet (or let me know and I’ll do so)

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.16) due by Friday, August 23rd, it can just be a placeholder PR at this time. Let me know if you have any questions!

[wojtek-t]

@daminisatya - this PR is opened already (and lgtm-ed from technical point of view):
https://github.com/kubernetes/website/pull/15530

[kacole2]

@wojtek-t code freeze for 1.16 is on Thursday 8/29. Are there any outstanding k/k PRs that still need to be merged for this to go Beta? Looks like all tagged PRs here have been merged.

[wojtek-t]

Yes - this is done for beta.

[mrbobbytables]

Hey there @wojtek-t -- 1.17 Enhancements lead here. I wanted to check in and see if you think this Enhancement will be graduating to alpha/beta/stable in 1.17?

The current release schedule is:

• Monday, September 23 - Release Cycle Begins
• Tuesday, October 15, EOD PST - Enhancements Freeze
• Thursday, November 14, EOD PST - Code Freeze
• Tuesday, November 19 - Docs must be completed and reviewed
• Monday, December 9 - Kubernetes 1.17.0 Released

If you do, please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!

/milestone clear

[wojtek-t]

Yes - I would like to promote it to GA in 1.17.

[mrbobbytables]

Great, thank you! I'll update the tracking sheet 👍

Sort of an unrelated FYI -- the Enhancements team should be the only ones adding/removing the tracked/* labels. 😬 It's used as an ack that the info has or should not be added to the tracking sheet.

tracked/yes: the Enhancements team has discussed with the owner and added the issue to the Enhancements tracking spreadsheet
tracked/no: the Enhancements team has discussed with the owner and the enhancement will not be graduating for the cycle in question

[wojtek-t]

@mrbobbytables - I see. Will keep that in mind for the future.

[wojtek-t]

Code is merged. Docs PR is opened. Once merged, it will be fully done.

[pgburt]

Hello @wojtek-t , I'm one of the v1.17 docs shadows.
I see you've already linked docs, so I've updated the 1.17 Enhancement Tracker Sheet with that info.

This is just a friendly reminder we're looking for a PR against k/website (branch dev-1.17) due by Friday, November 8th, it can just be a placeholder PR at this time. Let me know if you have any questions!

[wojtek-t]

@pgburt - https://github.com/kubernetes/website/pull/17026 is already out for review for a couple days

[wojtek-t]

All PRs, including docs, are merged. This is completely done.

[annajung]

Hey @wojtek-t 1.17 Enhancement Shadow here! 👋
The Enhancement team needs to track of all k/k PRs related to this enhancement and I was wondering if there were any other k/k PRs that need to be added to our tracking sheet other than kubernetes/kubernetes#83195?

[wojtek-t]

See the comment above - everything is merged.

[warmchang]

See the comment above - everything is merged.

But this issue is still open 😄 , can it be closed?

[wojtek-t]

Do we close enhancements issues immediately after all PRs are merged?
I had a feeling that we close them once the release containing the feature is out.

[mrbobbytables]

I had a feeling that we close them once the release containing the feature is out.

Yup 👍 This is in case something has to be backed out at the last minute.