Enhancements: Add pod-startup liveness-probe holdoff for slow-starting pods

[matthyx]

Enhancement Description

• One-line enhancement description (can be used as a release note): adds initializationFailureThreshold to probes allowing a greater number of failures during the initial start of the container.
• Kubernetes Enhancement Proposal: 20190221-livenessprobe-holdoff
• Primary contact (assignee): @matthyx
• Responsible SIGs: @kubernetes/sig-node-api-reviews
• Enhancement target (which target equals to which milestone):
  
  
  
  • Alpha release target (x.y) v1.16
  
  
  • Beta release target (x.y) v1.18
  
  
  • Stable release target (x.y) v1.20
  
  
• Documentation PR: https://github.com/kubernetes/website/pull/23332

[matthyx]

/sig node

[matthyx]

/assign @derekwaynecarr

[matthyx]

/kind api-change

[matthyx]

/milestone v1.15

[k8s-ci-robot]

@matthyx: You must be a member of the kubernetes/kubernetes-milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[matthyx]

/stage alpha

[matthyx]

@kacole2 the feature is implemented in this PR: https://github.com/kubernetes/kubernetes/pull/71449

[mrbobbytables]

@matthyx Kubernetes 1.15 Enhancement Freeze is 4/30/2019. To be included in the Kubernetes 1.15 milestone, KEPs are required to be in an "Implementable" state with proper test plans and graduation criteria. Please submit any PRs needed to make this KEP adhere to inclusion criteria. If this will slip from the 1.15 milestone, please let us know so we can make appropriate tracking changes.

[matthyx]

Hi Bob!
Please have a look at #1014
I have already talked to @derekwaynecarr to have a look, he suggested adding a feature gate to the document, which I did.
I am also waiting for some feedback from @thockin after answering his concerns.

[mrbobbytables]

@matthyx Great! Thanks for the info :) Will keep an eye on #1014

[matthyx]

@mrbobbytables I haven't heard of them during the night... not sure we'll meet the deadline :-(

[matthyx]

@mrbobbytables I have the support of @thockin for this KEP, can we maintain it in 1.15?
We're just discussing the implementation now, but the fundamentals are more or less agreed upon.

[mrbobbytables]

@matthyx Enhancement Freeze for Kubernetes 1.15 has passed and this unfortunately did not meet the deadline. It's being removed from the 1.15 milestone and the tracking sheet, but it looks like you're already on track to get an Enhancement Exception in. 👍 Thanks for being on point about it :)

[mrbobbytables]

/milestone v1.15

[matthyx]

New implementation in https://github.com/kubernetes/kubernetes/pull/77807

[matthyx]

This is the PR for documentation: https://github.com/kubernetes/website/pull/14297

[mrbobbytables]

Hi @matthyx , today is code freeze for the 1.15 release cycle. The k/k PRs have not yet been merged. It's now being marked as At Risk in the 1.15 Enhancement Tracking Sheet.

Is there a high confidence these will be merged by EOD PST today? After this point, only release-blocking issues and PRs will be allowed in the milestone with an exception.

[kacole2]

/milestone clear

[matthyx]

Hasn't code freeze been postponed until tonight?

[kacole2]

@matthyx, https://github.com/kubernetes/kubernetes/pull/77807 doesn't have LGTM or Approved labels yet. This means it's not in the queue to be merged. What's the confidence it will be approved by EOD?

@claurence can you assist here?

[matthyx]

Given that it usually takes one month to have a feedback... pretty low confidence (blameless comment).
But at least I do whatever I can to push this further as I initially hoped to have it in 1.12
The whole KEP process is definitely flawed, but I will save my thoughts for the retrospect.

[matthyx]

Ok, let's give up on 1.15
Good luck with the other remaining PRs

[kacole2]

Hi @matthyx , I'm the 1.16 Enhancement Lead. Is this feature going to be graduating alpha/beta/stable stages in 1.16? Please let me know so it can be added to the 1.16 Tracking Spreadsheet. If not's graduating, I will remove it from the milestone and change the tracked label.

Once coding begins or if it already has, please list all relevant k/k PRs in this issue so they can be tracked properly.

Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thank you.

[matthyx]

@kacole2 nice to meet you!
Yes, I hope to merge this feature in 1.16, and will defend the KEP again during the sig-node meeting tonight... I will for sure update you in the coming days.

[matthyx]

@kacole2 I got some news from @dchen1107 and I now have a reviewer (@Random-Liu) and an approver (@derekwaynecarr). Please see her comment here.

Could you update the status of this KEP on your tracking sheet?

[kacole2]

@matthyx done! thanks for responding. I've got the sheet updated.

[daminisatya]

@matthyx

I'm one of the v1.16 docs shadows.
Does this enhancement (or the work planned for v1.16) require any new docs (or modifications to existing docs)? If not, can you please update the 1.16 Enhancement Tracker Sheet (or let me know and I’ll do so)

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.16) due by Friday, August 23rd, it can just be a placeholder PR at this time. Let me know if you have any questions!

[matthyx]

Hi Satya,

I will do a PR on the 1.16 branch for the doc... sorry for the delay.

Matthias

On Tue, Aug 6, 2019 at 3:11 PM Damini Satya [e-mail]
wrote:

@matthyx https://github.com/matthyx

I'm one of the v1.16 docs shadows.
Does this enhancement (or the work planned for v1.16) require any new docs
(or modifications to existing docs)? If not, can you please update the 1.16
Enhancement Tracker Sheet (or let me know and I’ll do so)

If so, just a friendly reminder we're looking for a PR against k/website
(branch dev-1.16) due by Friday, August 23rd, it can just be a placeholder
PR at this time. Let me know if you have any questions!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/enhancements/issues/950?email_source=notifications&email_token=AE5ZVEPUCFOI3ROTXCQSSTLQDFZ7ZA5CNFSM4HFDH6YKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3VCT5I#issuecomment-518662645,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AE5ZVEMV3FYYR5RX5C5LUV3QDFZ7ZANCNFSM4HFDH6YA
.

[matthyx]

https://github.com/kubernetes/website/pull/15714

On Tue, Aug 6, 2019 at 3:23 PM Matthias Bertschy <
[email protected]> wrote:

Hi Satya,

I will do a PR on the 1.16 branch for the doc... sorry for the delay.

Matthias

On Tue, Aug 6, 2019 at 3:11 PM Damini Satya [e-mail]
wrote:

@matthyx https://github.com/matthyx

I'm one of the v1.16 docs shadows.
Does this enhancement (or the work planned for v1.16) require any new
docs (or modifications to existing docs)? If not, can you please update the
1.16 Enhancement Tracker Sheet (or let me know and I’ll do so)

If so, just a friendly reminder we're looking for a PR against k/website
(branch dev-1.16) due by Friday, August 23rd, it can just be a placeholder
PR at this time. Let me know if you have any questions!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/enhancements/issues/950?email_source=notifications&email_token=AE5ZVEPUCFOI3ROTXCQSSTLQDFZ7ZA5CNFSM4HFDH6YKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3VCT5I#issuecomment-518662645,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AE5ZVEMV3FYYR5RX5C5LUV3QDFZ7ZANCNFSM4HFDH6YA
.

[kacole2]

@matthyx code freeze for 1.16 is on Thursday 8/29. Are there any outstanding k/k PRs that still need to be merged for this to go Alpha? It looked like https://github.com/kubernetes/kubernetes/pull/77807 has not been merged yet.

[matthyx]

Yes, the reviewer did a lgtm on the change, but wanted more test coverage. I have added them over the weekend, and hope to hear from him again today...

[matthyx]

@kacole2 the PR has been approved, @thockin has just requested a follow-up PR to fix the gate, which is kubernetes/kubernetes#82101

[matthyx]

Code has been merged, waiting for the doc...

[matthyx]

@kacole2 Now that it's live in 1.16 as alpha, should this issue be closed?

[mrbobbytables]

@matthyx The issue should remain open through the graduation process and be closed once it has after it has graduated to stable 👍

Along those lines, do you think it'll graduate to beta in time for 1.17? The current 1.17 release schedule is:

• Monday, September 23 - Release Cycle Begins
  
  
  
  • Tuesday, October 15, EOD PST - Enhancements Freeze
  
  
  • Thursday, November 14, EOD PST - Code Freeze
  
  
  • Tuesday, November 19 - Docs must be completed and reviewed
  
  
  • Monday, December 9 - Kubernetes 1.17.0 Released
  
  

/milestone clear

[matthyx]

Hi @mrbobbytables of course it will be ready in time for graduation... I expect to run 1.16 with the flag enabled within 2 weeks on some of my clusters and start real-life assessment for that feature.
I hope there won't be too many people hitting bugs within that time...

[mrbobbytables]

Great to hear :) I'll add it to the tracking sheet.

Thanks!

/milestone v1.17
/stage beta

[pgburt]

Hello @matthyx , I'm one of the v1.17 docs shadows.
Does this enhancement (or the work planned for v1.17) require any new docs (or modifications to existing docs)? If not, can you please update the 1.17 Enhancement Tracker Sheet (or let me know and I'll do so).

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.17) due by Friday, November 8th, it can just be a placeholder PR at this time. Let me know if you have any questions!

[matthyx]

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.17) due by Friday, November 8th, it can just be a placeholder PR at this time.

Done, thanks for the reminder!

[annajung]

Hey @matthyx 1.17 Enhancement Shadow here! 👋 I am reaching out to check in with you to see how this enhancement is going.

The Enhancement team is tracking PR kubernetes/kubernetes#83437 in the tracking sheet. Are there any other k/k PRs that need to be tracked as well?

Also, another friendly reminder that we're quickly approaching code freeze (Nov. 14th).

[matthyx]

Hi @annajung I am facing issues finding approvers for these bugfix PRs:
https://github.com/kubernetes/kubernetes/pull/84179
https://github.com/kubernetes/kubernetes/pull/84279
https://github.com/kubernetes/kubernetes/pull/84291

They are needed to make sure the startupProbe behaves as expected from the KEP and the documentation. Maybe it could help to add them to 1.17 milestone for more visibility?

[annajung]

Hi @matthyx, thank you for pointing those out! I will add them to the tracking sheet to be tracked. 👍

[annajung]

Hi @matthyx , Tomorrow is code freeze for 1.17 release cycle. It looks like some of the k/k PRs have not been merged. We’re flagging this enhancement as At Risk in the 1.17 tracking sheet.

Do you think all necessary PRs will be merged by the EoD of the 14th (Thursday)? After that, only release-blocking issues and PRs will be allowed in the milestone with an exception.

[matthyx]

Hi @annajung it all depends on @dchen1107 if she's able to approve https://github.com/kubernetes/kubernetes/pull/84279 we could see how e2e tests are behaving and then I can push for https://github.com/kubernetes/kubernetes/pull/83437

[matthyx]

I think it's probably better to keep that feature alpha in 1.18
I will keep in touch with website to revert the documentation

[annajung]

Hey @matthyx looks like all k/k PRs except kubernetes/kubernetes#83437 were merged in! Do you still think it's better to defer this enhancement to 1.18 release? We can wait until 5pm PT to make that decision? Hopefully you'll be able to push through kubernetes/kubernetes#83437

[annajung]

Hey @matthyx , Sorry about the message above, looks like there were discussion to move this to 1.18, I'll defer this enhancement.

[matthyx]

I'll defer this enhancement.

Thanks :)

[jeremyrickard]

Hey @matthyx ,

1.18 Enhancement lead here 👋

I wanted to reach out and check with you if this will make it into 1.18? It looks like both of the PRs above have merged in. If there are any additional PRs for this, please let me know.

[matthyx]

Hi @jeremyrickard ,
I think we have already everything for 1.18, I think @liggitt can confirm the CI signal looks good too.
I only have some cherrypicks to 1.16 that aren't merged, but this is not the problem of the release lead :-)
Good luck!

[jeremyrickard]

Great, thanks @matthyx !

[savitharaghunathan]

Hi, @matthyx :)
1.18 docs shadow here. Does this enhancement work planned for 1.18 require any new docs (or modifications to existing docs)? If not, can you please update the 1.18 Enhancement Tracker Sheet (or let me know and I'll do so)
If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.18) due by Friday, Feb 28th, it can just be a placeholder PR at this time. Let me know if you have any questions!

Thanks,
Savitha

[matthyx]

Hi @savitharaghunathan normally the godoc comment will update the website... Maybe you could send me the link once it's available to double check?

Thanks for your reminder :)
Matthias

[savitharaghunathan]

@matthyx - I am not super familiar with godoc comments updating k/website. My understanding is that a PR needs to be manually created against the 1.18-dev branch. I will confirm and get back to you. Thanks!

[matthyx]

See the comment from @sftim
https://github.com/kubernetes/website/pull/17164#discussion_r346312341

[savitharaghunathan]

@matthyx you are right. I just learnt about the process. Sorry for the confusion.

[palnabarun]

/milestone clear

(removing the issue from the v1.18 milestone as 1.18 cycle had ended)

[matthyx]

Thanks @palnabarun, I will eventually graduate it to stable for 1.20 depending on the feedback from beta.

[johnbelamaric]

Hi @matthyx Enhancements shadow for 1.19 here. Any plans for this in 1.19? Or should I just set it for v1.20?

[matthyx]

Hi @johnbelamaric let's track it for 1.20 if you can. Thanks!

[johnbelamaric]

Sure.

/milestone v1.20

[qixiaobo]

Enhancement Description

• One-line enhancement description (can be used as a release note): adds initializationFailureThreshold to probes allowing a greater number of failures during the initial start of the container.
• Kubernetes Enhancement Proposal: 20190221-livenessprobe-holdoff
• Primary contact (assignee): @matthyx
• Responsible SIGs: @kubernetes/sig-node-api-reviews

• Enhancement target (which target equals to which milestone):

  • Alpha release target (x.y) v1.16
  • Beta release target (x.y) v1.XY
  • Stable release target (x.y) v1.XY

Glad to hear this

[k8s-ci-robot]

@qixiaobo: Reiterating the mentions to trigger a notification:
@kubernetes/sig-node-api-reviews

In response to this:

Enhancement Description

• One-line enhancement description (can be used as a release note): adds initializationFailureThreshold to probes allowing a greater number of failures during the initial start of the container.
• Kubernetes Enhancement Proposal: 20190221-livenessprobe-holdoff
• Primary contact (assignee): @matthyx
• Responsible SIGs: @kubernetes/sig-node-api-reviews

• Enhancement target (which target equals to which milestone):

  • Alpha release target (x.y) v1.16
  • Beta release target (x.y) v1.XY
  • Stable release target (x.y) v1.XY

Glad to hear this

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kikisdeliveryservice]

Hi @matthyx !

Enhancements Lead here, do you still intend to go GA in 1.20?

Thanks!
Kirsten

[matthyx]

Hi @kikisdeliveryservice

I actually did already with this PR: https://github.com/kubernetes/kubernetes/pull/94160
I just need to merge the corresponding doc: https://github.com/kubernetes/website/pull/23332

[kikisdeliveryservice]

@matthyx Perfect thank you for the update!

[kikisdeliveryservice]

Also just as a reminder once this feature totally complete and all of your PRs are merged, please update the kep to have a status of implemented: https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/20190221-livenessprobe-holdoff.md

[matthyx]

sure!

[mikejoh]

Hi @matthyx :wave:!

I'm one of the Enhancement shadows for the 1.20 release cycle. Not exactly relevant to this KEP since it's almost completed, but the Enhancement freeze is on the 6th of Oct.

It looks like one of the last things to do is to get the following PR (#1988) merged to move this KEP to implemented, there's one lgtm at this point and i guess there's someone you can poke at to get it approved!

Thanks!

[kikisdeliveryservice]

Keeping this open for tracking until we close the milestone :)