Enhancements: Add non-preempting option to PriorityClasses

[vllry]

Enhancement Description

• One-line enhancement description (can be used as a release note):
  This feature adds a new option to PriorityClasses, which can enable or disable pod preemption.
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/tree/master/keps/sig-scheduling/902-non-preempting-priorityclass
• Primary contact (assignee): @denkensk
• Responsible SIGs: scheduling
• Enhancement target (which target equals to which milestone):
  
  
  
  • Alpha release target (x.y): 1.15
  
  
  • Beta release target (x.y): 1.19
  
  
  • Stable release target (x.y)
  
  

PR: https://github.com/kubernetes/kubernetes/pull/74614

[vllry]

/sig scheduling

[kacole2]

@vllry I'm going to add this to the 1.15 milestone for tracking purposes. Please link to any k/k PRs so we can see the status of the merges to make sure this will make it to code freeze.

/milestone v1.15
/stage alpha

[justaugustus]

/assign @denkensk

[daminisatya]

Hey, @denkensk @vllry Is alpha release of this enhancement targeted for v1.15?

[vllry]

@daminisatya it is, but I believe API review is still pending.

[daminisatya]

Thank you @vllry

Just a friendly reminder we're looking for a PR against k/website (branch dev-1.15) due by Thursday, May 30th. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions! 😄

[vllry]

@denkensk do you have time to start docs, or would you like me to start?

[denkensk]

@denkensk do you have time to start docs, or would you like me to start?

@vllry Thank you. You can help to start docs If you have time.

[vllry]

Placeholder docs PR is up: https://github.com/kubernetes/website/pull/14599

@daminisatya what's the deadline for merging the documentation?

[makoscafee]

Hi, @vllry documentation should be merged by 10th June. but the deadline is broken down to

• 30th deadline for placeholder PR
• 04th deadline for all placeholder to have reviewable content
• 10th all docs PR should be merged.

Thanks.

[mrbobbytables]

@vllry @denkensk, today is code freeze for the 1.15 release cycle. The k/k PRs have not yet been merged. It's now being marked as At Risk in the 1.15 Enhancement Tracking Sheet.

Is there a high confidence these will be merged by EOD PST today? After this point, only release-blocking issues and PRs will be allowed in the milestone with an exception.

[kacole2]

/milestone clear

[vllry]

@kacole2 why was this removed from 1.15? The PR was merged last night.

[kacole2]

@vllry I apologize about that! I didn't see the PR listed in the original post. adding it back!

/milestone v1.15

[vllry]

Sorry about the lack of clarity! Doc PR is open and being refined, let me know if anything is missing.

[denkensk]

I apologize about that! I didn't see the PR listed in the original post. adding it back!

I reference this merged pr here kubernetes/kubernetes#74614 thank you

[kacole2]

Hi @denkensk, I'm the 1.16 Enhancement Lead. Is this feature going to be graduating alpha/beta/stable stages in 1.16? Please let me know so it can be added to the 1.6 Tracking Spreadsheet. If not's graduating, I will remove it from the milestone and change the tracked label.

Once coding begins or if it already has, please list all relevant k/k PRs in this issue so they can be tracked properly.

Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thank you.

[jeremyrickard]

Hey there @denkensk @vllry -- 1.17 Enhancements shadow here 👋 . I wanted to check in and see if you think this Enhancement will be graduating to beta in 1.17?

The current release schedule is:

• Monday, September 23 - Release Cycle Begins
• Tuesday, October 15, EOD PST - Enhancements Freeze
• Thursday, November 14, EOD PST - Code Freeze
• Tuesday, November 19 - Docs must be completed and reviewed
• Monday, December 9 - Kubernetes 1.17.0 Released

If you do, I'll add it to the 1.17 tracking sheet (https://bit.ly/k8s117-enhancements). Once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[vllry]

/lifecycle frozen

[fejta-bot]

Enhancement issues opened in kubernetes/enhancements should never be marked as frozen.
Enhancement Owners can ensure that enhancements stay fresh by consistently updating their states across release cycles.

/remove-lifecycle frozen

[johnbelamaric]

Hey there @vllry -- I am an Enhancements shadow this cycle. I wanted to check in and see if you think this Enhancement will be graduating to beta in 1.18 or having a major change?

The current release schedule is:
Monday, January 6th - Release Cycle Begins
Tuesday, January 28th EOD PST - Enhancements Freeze
Thursday, March 5th, EOD PST - Code Freeze
Monday, March 16th - Docs must be completed and reviewed
Tuesday, March 24th - Kubernetes 1.18.0 Released

To be included in the release, this enhancement must have a merged KEP in the implementable status. The KEP must also have graduation criteria and a Test Plan defined.

If you would like to include this enhancement, once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

We'll be tracking enhancements here: http://bit.ly/k8s-1-18-enhancements
Thanks!

[johnbelamaric]

Will go to beta in 1.18 per @ahg-g and @vllry on slack.

[johnbelamaric]

/milestone v1.18

[savitharaghunathan]

Hi, @denkensk @vllry :) 1.18 docs shadow here.

I noticed that this feature is graduating to beta. Does this require any new docs (or modifications to existing docs)? If not, can you please update the 1.18 Enhancement Tracker Sheet (or let me know and I'll do so)
If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.18) due by Friday, Feb 28th, it can just be a placeholder PR at this time. Let me know if you have any questions!

Thanks,
Savitha

[johnbelamaric]

Hi @denkensk and @vllry. Code freeze is March 5th. Please list the PRs that need to merge for graduating this feature, so we can track them in the release team. Thanks!

[johnbelamaric]

@denkensk @vllry ping - any PRs for this yet?

[johnbelamaric]

@denkensk @vllry Code freeze is tomorrow, looks like this is not going to make it unless some activity happens ASAP.

[johnbelamaric]

/milestone clear

[johnbelamaric]

Alas, this has missed code freeze.

[palnabarun]

Hi @denkensk @vllry -- 1.19 Enhancements Lead here, I wanted to check in if you think this enhancement would graduate in 1.19?

---

The current release schedule is:

• Monday, April 13: Week 1 - Release cycle begins
• Tuesday, May 19: Week 6 - Enhancements Freeze
• Thursday, June 25: Week 11 - Code Freeze
• Thursday, July 9: Week 14 - Docs must be completed and reviewed
• Tuesday, August 4: Week 17 - Kubernetes v1.19.0 released

[palnabarun]

Hi @denkensk @vllry, pinging again to check whether this enhancement would graduate to beta in 1.19.

[Huang-Wei]

SIG-Scheduling agreed to promote it to beta in 1.18, but unfortunately somehow it slipped. I think it's valid to move it to beta, from what I know, some users (@karlkfi) are expecting it to try it out and give some feedback.

@denkensk @vllry Do you think you're able to cover this in 1.19? If no, I can ask around in sig-scheduling if anyone else can step in.

[vllry]

I will do my best, but I need to brush up on the API promotion process.

On Wed, May 13, 2020 at 12:39 PM, Wei Huang [e-mail]
wrote:

SIG-Scheduling agreed to promote it to beta in 1.18, but unfortunately
somehow it slipped. I think it's valid to move it to beta, from what I
know, some users (@karlkfi https://github.com/karlkfi) are expecting it
to try it out and give some feedback.

@denkensk https://github.com/denkensk @vllry https://github.com/vllry
Do you think you're able to cover this in 1.19? If no, I can ask around in
sig-scheduling if anyone else can step in.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/enhancements/issues/902#issuecomment-628203846,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACRYN7ONRVE2LADZKUB4OB3RRLZN5ANCNFSM4G7DYKNQ
.

[denkensk]

@Huang-Wei @vllry thanks for your reminder, I will try my best to promote it to beta in 1.19.

[palnabarun]

Hi @denkensk @vllry @Huang-Wei, do you think this could make it by the Enhancements Freeze?

---

Tomorrow, Tuesday May 19 EOD Pacific Time is Enhancements Freeze

[Huang-Wei]

@palnabarun #1781 is out. But it needs some work on adopting new PRR requirements. I will try my best to catch the date.

[palnabarun]

@Huang-Wei -- Thanks for the update. I will keep on checking that PR. :+1:

[palnabarun]

@Huang-Wei -- I see that the KEP update PR was merged. However, the KEP was merged with an implemented state. We generally update the status to implemented when the work on the feature is complete and graduates to Stable.

[palnabarun]

cc: @denkensk @vllry ^^^

[denkensk]

@palnabarun I will fix it right now.

[denkensk]

https://github.com/kubernetes/enhancements/pull/1800 @palnabarun Can you help to review it?

[Huang-Wei]

@palnabarun Thanks for pointing that out! I just approved the pr that changes the status to implementable.

[palnabarun]

@denkensk @Huang-Wei -- Thanks for the quick update. :+1:

[palnabarun]

PS: I updated the issue description with the updated link to the KEP.

[palnabarun]

/stage beta
/milestone v1.19

[divya-mohan0209]

Hello @vllry & @denkensk , I'm one of the v1.19 docs shadows.

Does this enhancement work planned for 1.19 release require any new docs (or modifications to existing docs)?

If not, can you please update the 1.19 Enhancement Tracker Sheet (or let me know and I'll do so)

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.19) due by Friday, June 12, it can just be a placeholder PR at this time.

Please do feel free to let me know, if any questions.

Regards,
Divya

[palnabarun]

@Huang-Wei @vllry @denkensk -- Can you please link to all the implementation PR's here - k/k or otherwise? :slightly_smiling_face:

---

The current release schedule is:

• ~Monday, April 13: Week 1 - Release cycle begins~
• ~Tuesday, May 19: Week 6 - Enhancements Freeze~
• Thursday, June 25: Week 11 - Code Freeze
• Thursday, July 9: Week 14 - Docs must be completed and reviewed
• Tuesday, August 4: Week 17 - Kubernetes v1.19.0 released

[divya-mohan0209]

@vllry & @Huang-Wei : Gentle reminder on my note above. Please do feel free to get in touch, if you have any questions.

[denkensk]

@divya-mohan0209 Thanks, we don't need to update the doc. I update the 1.19 Enhancement Tracker Sheet

[Huang-Wei]

@denkensk we need to update the doc, at least for indicate it's a beta feature now.

[palnabarun]

Can you please link to all the implementation PR's here - k/k or otherwise?

@denkensk @Huang-Wei -- Pinging back as a friendly reminder of the above. :slightly_smiling_face:

[Huang-Wei]

ok, I will ping @denkensk .

[denkensk]

https://github.com/kubernetes/website/pull/21453 Update Doc
https://github.com/kubernetes/kubernetes/pull/91899 Update NonPreempt feature gate to beta

[palnabarun]

Hi @denkensk -- just wanted to check in about the progress of the enhancement.

The release timeline has been revised recently, more details of which can be found here.

Please let me know if you have any questions. :slightly_smiling_face:

---

The revised release schedule is:

• Thursday, July 9th: Week 13 - Code Freeze
• Thursday, July 16th: Week 14 - Docs must be completed and reviewed
• Tuesday, August 25th: Week 20 - Kubernetes v1.19.0 released

[palnabarun]

Hi @denkensk :wave:, I saw that all the PRs linked above were merged. Do you have any other implementation PRs or is the feature code complete?

Thank you. :slightly_smiling_face:

[denkensk]

Hi, @palnabarun There is one pr left for doc update. https://github.com/kubernetes/website/pull/21453

[palnabarun]

Thank you @denkensk for the confirmation. :+1:

[kikisdeliveryservice]

/milestone clear

(removing this enhancement issue from the v1.19 milestone as the milestone is complete)

[kikisdeliveryservice]

Hi @denkensk

Enhancements Lead here. Any plans for this in 1.20?

Thanks!
Kirsten

[kikisdeliveryservice]

Hi @denkensk

Enhancements Lead here again. Enhancements Freeze is next week Tuesday October 6th. If you intend to be included you'll need to update your graduation criteria for GA.

Thanks!
Kirsten