Enhancements: Configurable scale velocity for HPA

[gliush]

Enhancement Description

• Configurable HPA velocity
• Kubernetes Enhancement Proposal (PR): https://github.com/kubernetes/enhancements/pull/883
• KEP: 20190307-configurable-scale-velocity-for-hpa
• k8s API change PR: https://github.com/kubernetes/kubernetes/pull/74525
• Documentation PR: https://github.com/kubernetes/website/pull/18157
• RFC: https://docs.google.com/document/d/1Su2tzHEtjc7_orTVbKZEhSFGWiHk16JqA4Z7zJU2oNs/edit
• Primary contact (assignee): @gliush
• Responsible SIGs: SIG Autoscaling
• Enhancement target (which target equals to which milestone):
  
  
  
  • Alpha release target (x.y)
  
  
  • Beta release target (x.y)
  
  
  • Stable release target (x.y)
  
  

[gliush]

/sig autoscaling

[kacole2]

Hi @gliush. I'm the Enhancement Lead for 1.15. Does this feature plan on being implemented into an alpha state for 1.15?

[gliush]

Hi @kacole2, I'm ok to implement it as soon as I get an approval. So, I'm ok with 1.15 as well as with 1.xx version :)

[kacole2]

@gliush Enhancement Freeze is April 30th. Code Freeze is May 29th. We need a KEP approved and merged before these deadlines to be included.

/milestone v1.15

[justaugustus]

/assign @gliush

[mrbobbytables]

@gliush Kubernetes 1.15 Enhancement Freeze is 4/30/2019. To be included in the Kubernetes 1.15 milestone, KEPs are required to be merged and in an "Implementable" state with proper test plans and graduation criteria. Please submit any PRs needed to make this KEP adhere to inclusion criteria. If this will slip from the 1.15 milestone, please let us know so we can make appropriate tracking changes.

[mrbobbytables]

@gliush Enhancement Freeze for Kubernetes 1.15 has passed and this did not meet the deadline. This is now being removed from the 1.15 milestone and the tracking sheet. If there is a need for this to be in 1.15, please file an Enhancement Exception. Thank you.

[kacole2]

Hi @gliush , I'm the 1.16 Enhancement Lead. Is this feature going to be graduating alpha/beta/stable stages in 1.16? Please let me know so it can be added to the 1.16 Tracking Spreadsheet. If not's graduating, I will remove it from the milestone and change the tracked label.

Once coding begins or if it already has, please list all relevant k/k PRs in this issue so they can be tracked properly.

Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thank you.

[josephburnett]

@kacole2, yes, I think we should target alpha for 1.16. Are there documented requirements for what is required for an alpha feature?

@gliush this means we need to land all the code by 8/29. I have a TODO to review your PR https://github.com/kubernetes/kubernetes/pull/74525 this week.

[kacole2]

@josephburnett I'll get this added to the tracking sheet. As for requirements to be considered alpha is all based on the graduation criteria in the KEP. I just checked out 20190307-configurable-scale-velocity-for-hpa and noticed there is no graduation criteria. I would talk amongst the SIG and establish what requirements are necessary for graduating between stages going forward. Get those merged into the KEP and then you will have a community consensus. Lastly, the KEP is currently in a provisional state. KEPs must be in an Implementable state which requires SIG owners to LGTM and Approve.

I would focus on doing those first before trying to get the code landed.

[mrbobbytables]

@josephburnett @gliush I'm one of the 1.16 Enhancement Shadows -- I just wanted to check in. Do you think the KEP will have the graduation criteria and be bumped to an implementable state by the freeze tomorrow?

[kacole2]

@josephburnett @gliush

Enhancement Freeze has passed for 1.16. The KEP at is still in a Provisional state and now this is being removed from the 1.16 milestone. If this would like to be re-added, please file an exception and it will require approval from the release lead.

/milestone clear

[kcmartin]

Hello @josephburnett / @gliush -- 1.17 Enhancement Shadow here! 🙂

I wanted to reach out to see if this enhancement will be graduating to alpha/beta/stable in 1.17?


Please let me know so that this enhancement can be added to 1.17 tracking sheet.

Thank you!

🔔Friendly Reminder

The current release schedule is

• Monday, September 23 - Release Cycle Begins
• Tuesday, October 15, EOD PST - Enhancements Freeze
• Thursday, November 14, EOD PST - Code Freeze
• Tuesday, November 19 - Docs must be completed and reviewed
• Monday, December 9 - Kubernetes 1.17.0 Released

[kcmartin]

@gliush / @josephburnett
We're only 5 days away from the Enhancements Freeze (Tuesday, October 15, EOD PST).
Another friendly reminder -- do you intend to graduate this in the 1.17 release?

KEP must have graduation criteria defined, in an implementable state, and merged in.

[gliush]

Yep, we do intend to graduate this in the 1.17 release.
We'll fix everything, we still have some time, don't we? :)

[josephburnett]

FYI: @kcmartin we have an update to the KEP that includes and graduation criteria and will put it in an implementable state.

https://github.com/kubernetes/enhancements/pull/1234

[kcmartin]

Thanks for the update @josephburnett and @gliush !
/milestone v1.17

[kcmartin]

I'm pulling for this one to make it into 1.17!!
:)

[pgburt]

Hello @gliush @josephburnett , I'm one of the v1.17 docs shadows.
Does this enhancement (or the work planned for v1.17) require any new docs (or modifications to existing docs)? If not, can you please update the 1.17 Enhancement Tracker Sheet (or let me know and I'll do so).

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.17) due by Friday, November 8th, it can just be a placeholder PR at this time. Let me know if you have any questions!

[gliush]

Hi @pgburt, yes, this enhancement requires docs update.
Thank you for the reminder and for providing the deadline!!

[pgburt]

Hello @gliush and @josephburnett. Just writing to see if we have a placeholder PR that we can link to in the Enhancement Tracking sheet.

As a reminder, we're hoping to have placeholder PRs against kubernetes/website (branch dev-1.17) by Friday, Nov 8th. Let me know if I can help,

[gliush]

@pgburt: placeholder PR: https://github.com/kubernetes/website/pull/17400
I misread your original message and hurried to give a full PR ready by Friday.
How great that I still have more time for that!

[gliush]

I updated the original issue description to contain the link.

[kcmartin]

Hi my HPA friends, @gliush and @josephburnett:
Enhancements Shadow for the 1.17 Release Team again! We are very near to Code Freeze (Nov 14th) for this release cycle. Just checking in about the progress of this enhancement. I see that kubernetes/kubernetes#74525 was filed in relation to this--are there any other PRs related to this enhancement? If yes, can you please link them here?

Thank you in advance 😄

[gliush]

Yes, I have another PR for the KEP: https://github.com/gliush/kubernetes/pull/2
Though, I don't know how to create a PR in the kubernetes/kubernetes repo that will be based on gliush/kubernetes branch with API changes (as the https://github.com/kubernetes/kubernetes/pull/74525 is not merged yet).

[kcmartin]

IMPORTANT, PLEASE READ

Hi @gliush and @josephburnett -- tomorrow is code freeze for the 1.17 release cycle. It looks like the k/k PRs have not yet been merged. We're flagging as At Risk in the 1.17 Enhancement Tracking Sheet.

Do you think they will be merged by the EoD of the 14th (Thursday)? After that point, only release-blocking issues and PRs will be allowed in the milestone with an exception.

[gliush]

Yes, we are working on it right now.
We have everything ready except for a couple of small problems that we will fix today.

[kcmartin]

@gliush Code freeze is now in effect for the 1.17 release. It doesn't look like the PRs were added to a merge pool in time. I'm going to go ahead and remove this from the milestone, if you feel it is release blocking or urgent that it gets merged, please file an exception request

[kcmartin]

/milestone remove

[k8s-ci-robot]

@kcmartin: The provided milestone is not valid for this repository. Milestones in this repository: [keps-beta, keps-ga, v1.17, v1.18, v1.19, v1.20, v1.21]

Use /milestone clear to clear the milestone.

In response to this:

/milestone remove

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kcmartin]

/milestone clear

[jeremyrickard]

Hello @gliush and @josephburnett --

1.18 enhancements team checking in! Do you you plan on landing this in the 1.18 release? It looks like the PR you mentioned above hasn't been merged into the kubernetes/kuberntes repo. Code freeze for 1.18 will be March 5th. If there are other PRs, could you please list them here so we can track them?

Thanks!

[jeremyrickard]

Hello @gliush and @josephburnett --

We're about a week out from 1.18. You missed code freeze for 1.17, but we currently aren't tracking this for 1.18 yet. Can you confirm if you plan on graduating this in the 1.18 release so we can track it? Thanks so much!

[gliush]

@jeremyrickard : Yes, This should be a part of 1.18.
The KEP is merged to master, code is merged to master, documentation is merged to master.
Everything seems to be ready.
Should I do anything else to make it happen?

[josephburnett]

Ping @jeremyrickard. What is required to make this cell show "Tracked" instead of "Pending Inclusion"?

[palnabarun]

@josephburnett Everything seems fine. Just one concern, does this KEP not require any Test Plans?

[jeremyrickard]

@josephburnett @gliush sorry for the delay. We'll flip the status in the sheet. @palnabarun is right, the KEP should really have a test plan defined. I think we missed calling that out for 1.17. Is that something that you can get done before enhancement freeze tomorrow? Apologies for not catching this during the 1.17 time frame and seeing it so late in the enhancement cycle now.

[jeremyrickard]

Since we're so close to the enhancement freeze, we can approve an exception if you can get the test plan added within the next few days?

[jeremyrickard]

@josephburnett @gliush any luck getting a KEP PR for the test plan?

[kikisdeliveryservice]

(adding milestone for tracking purposes)

/milestone v1.18

[jeremyrickard]

Hey @josephburnett @gliush,

Unfortunately we need to bump this from the milestone since it's missing the test plan. If you can update the KEP to include that and file an Exception Request, we'll get it back in!

[jeremyrickard]

/milestone clear

[gliush]

The PR contains information about test plan. It will be merged soon.
@jeremyrickard : can we put it to the 1.18?

[jeremyrickard]

@gliush please file an exception request so we can track. Make sure to link the KEP PR in the request.

[jeremyrickard]

Hey @gliush @josephburnett @arjunrn

In order to make it back into the 1.18 release, you need to file an exception request TODAY. Friendly reminder: the instructions are here: https://github.com/kubernetes/sig-release/blob/master/releases/EXCEPTIONS.md

cc: @alejandrox1 @mrbobbytables @onlydole

[jeremyrickard]

Exception request was approved. Adding back to the milestone.
/milestone v1.18

[arjunrn]

@jeremyrickard The test plan was merged into the kep. I think we don't need the exception anymore. Also this PR on k/k for this enhancement was already merged. But I cannot find this feature listed in the changelog. Is there something missing from our end. Is it just because this KEP was left in the implementable state? Because I've changed it to implemented now.

[savitharaghunathan]

Hello, @gliush @josephburnett @arjunrn :) 1.18 docs shadow here. Does this enhancement work planned for 1.18 require any new docs (or modifications to existing docs)? If not, can you please update the 1.18 Enhancement Tracker Sheet (or let me know and I'll do so)
If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.18) due by Friday, Feb 28th, it can just be a placeholder PR at this time. Let me know if you have any questions!

Thanks,
Savitha

[arjunrn]

@savitharaghunathan Here is the PR. The changes were originally made against master but they have been reverted. Can you also add the PR to the Enhancement Tracker.

[savitharaghunathan]

@arjunrn - thanks for the update. I will link the PR to the enhancements tracker.

[gliush]

@jeremyrickard , @savitharaghunathan: could you confirm that this is going to be part of 1.18 and we don't miss anything?

[palnabarun]

@gliush This enhancement surely satisfies all criteria to be part of the release cycle.

Just a few concerning things:

1. The KEP status is set to implemented, whereas it should have been implementable if it yet to be implemented. The status is set to implemented only when an enhancement graduates successfully to the stable phase.
2. Can you please confirm which graduation stage are you targeting this release cycle?

[palnabarun]

PS: We are actively tracking it on the tracking sheet

[palnabarun]

Investigating further, the PR that set the status to implemented: https://github.com/kubernetes/enhancements/pull/1522

[jeremyrickard]

As @palnabarun pointed out, you're going to need to update this to implementable. You won't set the status to implemented until it graduates to stable. @arjunrn @gliush

You don't need another exception to fix that, but please do it ASAP.

[jeremyrickard]

Hey @gliush

I think everything for this is merged yes? Could you link us to the PRs that merged the implementation for this enhancement so we can update the tracking sheet? Code freeze for 1.18 is March 05, 2020, so anything additional will need to be completed and merged prior to that.

[gliush]

Hi @jeremyrickard

Yes, everything seems to be merged.

[palnabarun]

/milestone clear

(removing this enhancement issue from the v1.18 milestone as the milestone is complete)

[gliush]

This enhancement was merged. What should I do with it? I don't see good documentation anywhere that explains the usual enhancement flow.
Should I just close the issue? Should I mention somewhere that the enhancement is merged in 1.18?

[johnbelamaric]

@gliush So, as I read it, this was implemented as part of a beta API, so there will be no separate graduation for this feature. It will graduate with that API. Therefore, we can just close this!

/close

[k8s-ci-robot]

@johnbelamaric: Closing this issue.

In response to this:

@gliush So, as I read it, this was implemented as part of a beta API, so there will be no separate graduation for this feature. It will graduate with that API. Therefore, we can just close this!

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[johnbelamaric]

/milestone v1.18

Since that is when it was implemented.

[johnbelamaric]

/stage beta

Also, we would categorize this as "a change to an existing beta API", so I believe the stage should be beta. @palnabarun , make sense?

[palnabarun]

@johnbelamaric LGTM! :slightly_smiling_face:

[gliush]

@johnbelamaric : Thank you very much for explanation, it was really helpful!