Enhancements: Graduate the kube-scheduler ComponentConfig to GA

[luxas]

Enhancement Description

• One-line enhancement description (can be used as a release note): Usage of the kube-scheduler configuration file has graduated from experimental, as the API version now is v1beta1
• Primary contact (assignee): @alculquicondor
• Responsible SIGs: @kubernetes/sig-scheduling-api-reviews @kubernetes/wg-component-standard
• KEP: https://github.com/kubernetes/enhancements/tree/master/keps/sig-scheduling/785-scheduler-component-config-api
• Link to e2e and/or unit tests:
• Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: @bsalamat @k82cn
• Approver (likely from SIG/area to which enhancement belongs): @bsalamat @k82cn
• Enhancement target (which target equals to which milestone):
  
  
  
  • Alpha release target (x.y)
  
  
  • Beta release target (x.y) 1.14
  
  
  • Stable release target (x.y) 1.15
  
  

The kube-scheduler ComponentConfig is currently in v1alpha1. The spec needs to be graduated to v1beta1 and beyond in order to be usable widely.
/assign @bsalamat @k82cn

[sttts]

We need a thorough API review of the kube-scheduler component config in the light of unifying them for all components. Moving what we have to beta in the 1.14 time frame feels like rushing in the light of us having just started with component-base.

[claurence]

@luxas I don't see a KEP for this issue links in the description. I'm removing it from the 1.14 milestone - to have it added back please file an exception request.

[kacole2]

@luxas I'm the enhancement lead for 1.15. I don't see a KEP filed for this enhancement and per the guidelines, all enhancements will require one. Please let me know if this issue will have any work involved for this release cycle and update the original post reflect it. Thanks!

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[mtaufen]

/remove-lifecycle stale
/lifecycle frozen

[fejta-bot]

Enhancement issues opened in kubernetes/enhancements should never be marked as frozen.
Enhancement Owners can ensure that enhancements stay fresh by consistently updating their states across release cycles.

/remove-lifecycle frozen

[mrbobbytables]

Hey there @luxas, I'm one of the 1.16 Enhancement Shadows. Is this feature going to be graduating alpha/beta/stable stages in 1.16? Please let me know so it can be added to the 1.16 Tracking Spreadsheet. If not's graduating, I will remove it from the milestone and change the tracked label.

Once coding begins or if it already has, please list all relevant k/k PRs in this issue so they can be tracked properly.

As a reminder, every enhancement requires a KEP in an implementable state with Graduation Criteria explaining each alpha/beta/stable stages requirements.

Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thank you.

[bsalamat]

@mrbobbytables given that this issue does not have an owner and we didn't plan it for 1.16 in SIG scheduling, I doubt if this can make it to 1.16, but given that we still have another ~10 days before enhancement freeze, we may still be able to squeeze this in. If I find an owner for this, I will update it and will let you know.
Let's remove this from 1.16 for now.

[jfbai]

@bsalamat I’d like to work on this if you have not assign to anyone.

[bsalamat]

@jfbai Please go ahead and send a KEP as soon as possible. The KEP must be merged by the end of July for this to be considered for 1.16.

[jfbai]

@jfbai Please go ahead and send a KEP as soon as possible. The KEP must be merged by the end of July for this to be considered for 1.16.

@bsalamat Are there any big changes against kube-scheduler configuraions when graduating to v1beta1? Or, just keep it same as v1alpha1?

According to Moving ComponentConfig API types to staging repos, ComponentConfig is to split component config to internal and external with version, and move external versioned config to staging/, so, my understanding is there is no structure changes will be introduced.

If I missed something important, could you please provide suggestion to accomplish this work, since I am lack of knowledge about related works.

[bsalamat]

@bsalamat Are there any big changes against kube-scheduler configuraions when graduating to v1beta1? Or, just keep it same as v1alpha1?

Initially we didn't plan to make any changes, but now we should make sure that fields are optional as is proposed by: https://github.com/kubernetes/enhancements/pull/1173

We need to wait for that KEP to be implemented. For that reason, we cannot promote the scheduler config to beta in 1.16.

[jfbai]

@bsalamat Are there any big changes against kube-scheduler configuraions when graduating to v1beta1? Or, just keep it same as v1alpha1?

Initially we didn't plan to make any changes, but now we should make sure that fields are optional as is proposed by: #1173

We need to wait for that KEP to be implemented. For that reason, we cannot promote the scheduler config to beta in 1.16.

I see, thanks a lot.

[jfbai]

/assign

[k82cn]

@luxas , @jfbai , what's current status of this feature, alpha, beta? Not sure current status according to the history :)

[jfbai]

@luxas , @jfbai , what's current status of this feature, alpha, beta? Not sure current status according to the history :)

@k82cn we are waiting for this KEP to be implemented. Then, migrate to v1beta1.

[palnabarun]

Hey there @jfbai, 1.17 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating to beta in 1.17?

The current release schedule is:

• Monday, September 23 - Release Cycle Begins
• Tuesday, October 15, EOD PST - Enhancements Freeze
• Thursday, November 14, EOD PST - Code Freeze
• Tuesday, November 19 - Docs must be completed and reviewed
• Monday, December 9 - Kubernetes 1.17.0 Released

If you do, I'll add it to the 1.17 tracking sheet (https://bit.ly/k8s117-enhancement-tracking). Once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!

[ahg-g]

@luxas , @jfbai , what's current status of this feature, alpha, beta? Not sure current status according to the history :)

@k82cn we are waiting for this KEP to be implemented. Then, migrate to v1beta1.

why are we blocked on that? Changing the fields to nil is a backwards compatible change, so it does not matter whether we are in alpha or beta.

[jfbai]

@luxas , @jfbai , what's current status of this feature, alpha, beta? Not sure current status according to the history :)

@k82cn we are waiting for this KEP to be implemented. Then, migrate to v1beta1.

why are we blocked on that? Changing the fields to nil is a backwards compatible change, so it does not matter whether we are in alpha or beta.

@ahg-g Thanks for notification, I will continue this work when you guys have conclusion in this PR

[helayoty]

Hey there @jfbai @luxas -- 1.18 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating to beta in 1.18 or having a major change in its current level?

The current release schedule is:

Tuesday, January 28th EOD PST - Enhancements Freeze
Thursday, March 5th, EOD PST - Code Freeze
Monday, March 16th - Docs must be completed and reviewed
Tuesday, March 24th - Kubernetes 1.18.0 Released

To be included in the release, this enhancement must have a merged KEP in the implementable status.

If you would like to include this enhancement, once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly.

Thanks!

[ahg-g]

/cc @alculquicondor

[helayoty]

Hey @jfbai @luxas @ahg-g -- 1.18 Enhancements team shadow here. We're about 5 days away from Enhancement Freeze on Jan 28th. Wanted to check to see if you'll be graduating this to beta in 1.18?

[ahg-g]

Hi Heba, this will not graduate to Beta in this cycle.

[ahg-g]

Sorry, we may still graduate this to Beta, we will have a decision before the deadline.

[helayoty]

/milestone v1.18

[helayoty]

@ahg-g Thanks for the update. Please note that KEP must be merged before the deadline.

Kindly if you can include any k/k PRs in the issue.

[ahg-g]

/remove-milestone v1.18

so we decided that we are not going to beta, we are going to v1alpha2

[palnabarun]

@ahg-g Thank you! I will update the same in the tracking sheet.

[jeremyrickard]

Hey @ahg-g is there a KEP dedicated to this issue? https://github.com/kubernetes/enhancements/pull/1173 seems related but not exactly the KEP for this issue, unless I'm reading it wrong? Thanks!

[ahg-g]

you mean dedicated kep for v1beta1 or v1alpha2?

[jeremyrickard]

@ahg-g I meant is there a KEP that covers the graduation of this enhancement, aside from #1173?

[jeremyrickard]

This will result in a new alpha API version, so we'll track for 1.18.

[alculquicondor]

the introduction of v1alpha2 is already tracked in #1451

Is this enough?

[jeremyrickard]

@alculquicondor yes, although the KEP needs to be merged :) we'll track on that. thanks!

[alculquicondor]

Done :)

[savitharaghunathan]

Hi, @ahg-g @luxas @jfbai :) 1.18 docs shadow here. Does this enhancement work planned for 1.18 require any new docs (or modifications to existing docs)? If not, can you please update the 1.18 Enhancement Tracker Sheet (or let me know and I'll do so)
If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.18) due by Friday, Feb 28th, it can just be a placeholder PR at this time. Let me know if you have any questions!

Thanks,
Savitha

[ahg-g]

This is not graduating to Beta in 1.18

/remove-milestone v1.18

[jeremyrickard]

@ahg-g This is going to be updating from v1alpha1 to v1alpha2 though per the discussion above yes and would need updated docs wouldn't it? We will still track those things for the milestone.

[jeremyrickard]

Hey @ahg-g based on your comments above, I've dropped this from the milestone. If you're making any changes to the api that would need release notes or docs updates, let us know and we'll track this again.

[ahg-g]

Right, this issue is to graduate to v1beta1, which is not happening in this cycle.

Looking at the docs, I don't see one for v1alpha1! We should update https://kubernetes.io/docs/concepts/scheduling/kube-scheduler/

[ahg-g]

@alculquicondor will create docs for component config as part of https://github.com/kubernetes/kubernetes/issues/87617

[palnabarun]

Hi @ahg-g -- 1.19 Enhancements Lead here, I wanted to check in if you think this enhancement would graduate to Beta in 1.19?

In order to have this part of the release:

1. The KEP PR must be merged in an implementable state
2. The KEP must have test plans
3. The KEP must have graduation criteria.

---

The current release schedule is:

• Monday, April 13: Week 1 - Release cycle begins
• Tuesday, May 19: Week 6 - Enhancements Freeze
• Thursday, June 25: Week 11 - Code Freeze
• Thursday, July 9: Week 14 - Docs must be completed and reviewed
• Tuesday, August 4: Week 17 - Kubernetes v1.19.0 released

[alculquicondor]

@palnabarun I'm already working on this.

/close

I'm now tracking in kubernetes/kubernetes#89701 and I will soon write the KEP

[k8s-ci-robot]

@alculquicondor: Closing this issue.

In response to this:

@palnabarun I'm already working on this.

/close

I'm now tracking in #89701 and I will soon write the KEP

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[alculquicondor]

Oops, didn't realize this is the enhancement repo

/reopen

[k8s-ci-robot]

@alculquicondor: Reopened this issue.

In response to this:

Oops, didn't realize this is the enhancement repo

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[palnabarun]

@alculquicondor No problem :sweat_smile: Let me know if a KEP would be ready by the Enhancements Freeze. :slightly_smiling_face:

[alculquicondor]

It will

[palnabarun]

@alculquicondor Awesome! I will update the tracking sheet to reflect the same.

[palnabarun]

/stage beta
/milestone v1.19

[divya-mohan0209]

Hello, @luxas I'm one of the v1.19 docs shadows.

Could you please let me know if this piece of enhancement work planned for 1.19 release requires any new docs (or modifications to existing docs)?

If not, can you please update the 1.19 Enhancement Tracker Sheet (or let me know and I'll do so)

If yes, just a friendly reminder we're looking for a PR against k/website (branch dev-1.19) due by Friday, June 12, it can just be a placeholder PR at this time.

Please do let me know if you have any questions!

Regards,
Divya

[neolit123]

@ahg-g hi, i've assigned you as the primary contact for this issue as Lucas is busy. please let me know if you think someone else is more appropriate.

[alculquicondor]

I'm handling this. Could you please update?

re @divya-mohan0209, we will require an update to https://kubernetes.io/docs/reference/scheduling/profiles/

[divya-mohan0209]

@alculquicondor Please could you raise a PR against k/website for the above update?

[neolit123]

@alculquicondor ack, updated the OP.

[alculquicondor]

Thanks,
@divya-mohan0209 Will do

[palnabarun]

@alculquicondor -- Do you have any working PR other than https://github.com/kubernetes/kubernetes/issues/89701 ? If yes, can you please link them here? :slightly_smiling_face:

---

The current release schedule is:

• ~Monday, April 13: Week 1 - Release cycle begins~
• ~Tuesday, May 19: Week 6 - Enhancements Freeze~
• Thursday, June 25: Week 11 - Code Freeze
• Thursday, July 9: Week 14 - Docs must be completed and reviewed
• Tuesday, August 4: Week 17 - Kubernetes v1.19.0 released

[alculquicondor]

Not yet. We are opening them soon.

[divya-mohan0209]

@alculquicondor : Gentle reminder on my above comment.

[alculquicondor]

It's all being tracked in kubernetes/kubernetes#89701

The next PR in queue is kubernetes/kubernetes#91420 (almost merged now)

[divya-mohan0209]

@alculquicondor Thanks for the update! Could you please link the PR that you'd be using for the docs update (raised against k/website) here for efficient tracking?

[alculquicondor]

Will do. It's not open yet.

[palnabarun]

@alculquicondor -- Thanks! I have noted the k/k issues mentioned above. Please keep on posting them as they are opened. :slightly_smiling_face:

[alculquicondor]

/assign

[alculquicondor]

WIP docs kubernetes/website#21437

[palnabarun]

Hi @alculquicondor -- just wanted to check in about the progress of the enhancement.

The release timeline has been revised recently, more details of which can be found here.

Please let me know if you have any questions. :slightly_smiling_face:

---

The revised release schedule is:

• Thursday, July 9th: Week 13 - Code Freeze
• Thursday, July 16th: Week 14 - Docs must be completed and reviewed
• Tuesday, August 25th: Week 20 - Kubernetes v1.19.0 released

[palnabarun]

Hi @alculquicondor :wave:, I saw that all the items in the checklist are complete apart from the feature gate implementation and reference docs. Do you think they will be completed by Code Freeze? Is there any way we can help speed things up before the code freeze on Thursday?

Thank you. :slightly_smiling_face:

---

Code Freeze begins on Thursday, July 9th EOD PST

[alculquicondor]

They were labelled as nice-to-have. We won't be completing those for 1.19

• The feature gate changes had pending discussions
• The reference docs generation is not a trivial effort. Sadly, we didn't get a contributor to handle it.

But the core functionality is completed.

[palnabarun]

@alculquicondor -- Thank you for the update :smile:

Aha! I see. So, can we assume that the enhancement is code complete for this cycle?

Thank you!

[alculquicondor]

Correct.

[palnabarun]

@alculquicondor -- Awesome! :+1:

[kikisdeliveryservice]

/milestone clear

(removing this enhancement issue from the v1.19 milestone as the milestone is complete)

[kikisdeliveryservice]

Hi @alculquicondor

Enhancements Lead here. Are there any plans for this 1.20?

Thanks!
Kirsten

[alculquicondor]

We'll give it one release before graduation to GA :)

[alculquicondor]

/retitle Graduate the kube-scheduler ComponentConfig to GA