Enhancements: Skip attach for non-attachable CSI volumes

[msau42]

Enhancement Description

• One-line enhancement description (can be used as a release note): Allow CSI drivers that don't support attach to not require the CSI external-attacher
• Primary contact (assignee): @jsafrane
• Responsible SIGs: sig-storage
• Design proposal link (community repo)/ KEP: https://github.com/kubernetes/enhancements/pull/768 / https://github.com/kubernetes/enhancements/blob/master/keps/sig-storage/20190129-csi-skip-attach.md
• Link to e2e and/or unit tests:
• Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: @msau42 @saad-ali
• Approver (likely from SIG/area to which enhancement belongs): @saad-ali
• Enhancement target (which target equals to which milestone):
  
  
  
  • Alpha release target (x.y): 1.12
  
  
  • Beta release target (x.y): 1.14
  
  
  • Stable release target (x.y)
  
  

API PRs:

• [ ] https://github.com/kubernetes/kubernetes/pull/73883
• [ ] https://github.com/kubernetes/kubernetes/pull/74283

_Please to keep this description up to date. This will help the Enhancement Team track efficiently the evolution of the enhancement_

[msau42]

For some reason I couldn't find a feature issue for this, so I created this

[msau42]

@kubernetes/sig-storage-feature-requests

[msau42]

cc @claurence
This should be tracked as beta for 1.14.

[msau42]

/assign @bertinatto @jsafrane

[saad-ali]

KEP: https://github.com/kubernetes/enhancements/blob/master/keps/sig-storage/20190129-csi-skip-attach.md

[ameukam]

/stage beta

[simplytunde]

Hey @msau42 Just a friendly reminder we're looking for a PR against k/website (branch dev-1.14) due by Friday, March 1. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions!

[claurence]

@msau42 Checking in as code freeze is approaching (March 7th) - I see a few PRs mentioned above but want to check which ones need to be merged by code freeze for this to be included in the 1.14 release (and if there are any additional PRs).

[msau42]

I updated the description with all the k/k prs required

[jsafrane]

This feature is not facing users and thus does not have docs on kubernetes.io. Its documentation is at https://kubernetes-csi.github.io/docs/. 1.14 updates are in progress at https://github.com/kubernetes-csi/docs/pull/121

[kacole2]

Hello @msau42 @jsafrane , I'm the Enhancement Lead for 1.15. Is this feature going to be graduating alpha/beta/stable stages in 1.15? Please let me know so it can be tracked properly and added to the spreadsheet. Drop any relevant k/k PRs into this issue so they can be tracked as well. Thanks!

[msau42]

This feature will remain in beta for 1.15

[mrbobbytables]

Hey there @msau42 @jsafrane, I'm one of the 1.16 Enhancement Shadows. Is this feature going to be graduating alpha/beta/stable stages in 1.16? Please let me know so it can be added to the 1.16 Tracking Spreadsheet. If it's not graduating, I will remove it from the milestone and change the tracked label.

Once coding begins or if it already has, please list all relevant k/k PRs in this issue so they can be tracked properly.

Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thank you.

[kcmartin]

Hello @msau42 @jsafrane -- 1.17 Enhancement Shadow here! 🙂

I wanted to reach out to see if this enhancement will be graduating to alpha/beta/stable in 1.17?


Please let me know so that this enhancement can be added to 1.17 tracking sheet.

Thank you!

🔔Friendly Reminder

The current release schedule is

• Monday, September 23 - Release Cycle Begins
• Tuesday, October 15, EOD PST - Enhancements Freeze
• Thursday, November 14, EOD PST - Code Freeze
• Tuesday, November 19 - Docs must be completed and reviewed
• Monday, December 9 - Kubernetes 1.17.0 Released

[gnufied]

We are tracking this feature to go GA in 1.17. Can we please add this to tracking sheet?

[kcmartin]

@gnufied Thanks, I've added it to the tracking sheet!
/milestone v1.17

[kcmartin]

/stage stable

[VineethReddy02]

Hey, @msau42 @jsafrane. I am docs shadow for 1.17 release. Just a friendly reminder we're looking for a PR against k/website (branch dev-1.17) due by Friday, Nov 8th. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions!

Thanks!

[VineethReddy02]

Hey, @msau42 @jsafrane Just a friendly reminder we're looking for a PR against k/website (branch dev-1.17) due by Friday, Nov 8th. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions!
We are 5 days away from the deadline. Thanks!

[kcmartin]

Hi @msau42 and @jsafrane
I am one of the Enhancements Shadows for the 1.17 Release Team. We are very near to Code Freeze (Nov 14th) for this release cycle. Just checking in about the progress of this enhancement. I see that kubernetes/kubernetes#84814 was filed in relation to this. Is there any other PRs related to this enhancement? If yes, can you please link them here?

Thank you in advance 😄

[mrbobbytables]

👋 @msau42 @jsafrane 1.17 Enhancement lead here -- Just a heads up, an open Docs PR is needed by the end of the day today to remain in the milestone. 😬 If there isn't a PR by EoD, an exception will need to be filed to remain in the 1.17 release.

Please link it here as soon as it's created.

Thanks!

[helayoty]

Hey @msau42 @jsafrane -- 1.18 Enhancements shadow here. I wanted to check in and see if you think a Docs PR is planned to be included in 1.18 or having a major change in its current level?

The current release schedule is:

Tuesday, January 28th EOD PST - Enhancements Freeze
Thursday, March 5th, EOD PST - Code Freeze
Monday, March 16th - Docs must be completed and reviewed
Tuesday, March 24th - Kubernetes 1.18.0 Released

If you would like to include this enhancement, once you open the Docs PR(s), please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!

[gnufied]

Since we narrowly missed finishing this in 1.18, we are planning to get this feature done in 1.18. I have updated merged KEPs - https://github.com/kubernetes/enhancements/pull/1455

[helayoty]

Thanks, @gnufied for the update!

[helayoty]

/milestone v1.18

[irvifa]

Hello @msau42 @jsafrane I'm one of the v1.18 docs shadows.
Does this enhancement for (or the work planned for v1.18) require any new docs (or modifications to existing docs)? If not, can you please update the 1.18 Enhancement Tracker Sheet (or let me know and I'll do so)

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.18) due by Friday, Feb 28th., it can just be a placeholder PR at this time. Let me know if you have any questions!

[irvifa]

Hello @msau42 @jsafrane I'm one of the v1.18 docs shadows.

Does this enhancement for (or the work planned for v1.18) require any new docs (or modifications to existing docs)? If not, can you please update the 1.18 Enhancement Tracker Sheet (or let me know and I'll do so)

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.18) due by Friday, Feb 28th, which is roughly 1 weeks from now. It can just be a placeholder PR at this time. Let me know if you have any questions!

[jeremyrickard]

Hello @msau42 @jsafrane @gnufied,

Can you please link us to any k/k PRs for this enhancement so we can better track things. Code freeze is coming up quickly on 05 March 2020

[irvifa]

Hi @msau42 @jsafrane @gnufied I know you’re keeping tabs on this.. since the deadline is this Friday would you like to share when will you create a placeholder PR? Thanks..

[jeremyrickard]

/milestone clear

[VineethReddy02]

Hi, @msau42 @jsafrane @gnufied as there is no docs placeholder PR for this enhancement and didn't receive any update on the docs front. we have crossed the docs placeholder PR deadline. So we are removing this enhancement from the 1.18 release. If you want to request an exception. Please refer to https://github.com/kubernetes/sig-release/blob/master/releases/EXCEPTIONS.md

Thanks!

[gnufied]

so this enhancment and https://github.com/kubernetes/enhancements/issues/603 are basically behind same feature gate which is called CSIDriverRegistry and it does make sense to open two different placeholder docs for documenting same feature-gate - https://github.com/kubernetes/website/pull/19354

[VineethReddy02]

So @gnufied https://github.com/kubernetes/website/pull/19354 will this placeholder PR contain docs for this enhancement or you want to create another placeholder PR? In the previous comment, you mentioned you want different placeholder PR

[msau42]

I think the same PR covers both

[jeremyrickard]

/milestone v1.18

[jeremyrickard]

/reopen @gnufied @msau42 you should leave this open until the KEP is updated to implemented

[gnufied]

Yeah. This is a side effect of PRs using direct ref rather than xref.

[jsafrane]

you should leave this open until the KEP is updated to implemented

Filed https://github.com/kubernetes/enhancements/pull/1605

[palnabarun]

/close

(closing this since the KEP has been implemented)

[palnabarun]

/milestone clear

[k8s-ci-robot]

@palnabarun: Closing this issue.

In response to this:

/close

(closing this since the KEP has been implemented)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.