Enhancements: Kubelet Resource Metrics Endpoint

Created on 25 Jan 2019  路  34Comments  路  Source: kubernetes/enhancements

Enhancement Description

  • One-line enhancement description: Introduce a new kubelet endpoint for serving metrics about first-class resources.
  • Primary contact: @dashpole
  • Responsible SIGs: Sig-Node, Sig-Instrumentation
  • KEP: https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/kubelet-resource-metrics-endpoint.md
  • Link to e2e and/or unit tests: Coming soon
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: @DirectXMan12
  • Approver: @dchen1107 @brancz
  • Enhancement target (which target equals to which milestone):

    • Alpha release target 1.14

    • Beta release target TBD

    • Stable release target TBD

sinode stagalpha stagbeta trackeno

Most helpful comment

Hey @dashpole 馃憢! I'm Naomi, a v1.14 docs release shadow.

Does this enhancement require any new docs (or modifications)?

Just a friendly reminder we're looking for a PR against k/website (branch dev-1.14) due by Friday, March 1. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions!

All 34 comments

/sig node

@dashpole I've added this enhancement to the 1.14 tracking doc since it looks like y'all are targeting alpha here.

Are there any open PRs for this that should be tracked as well for it to be added to 1.14 as alpha?

@claurence I am going to wait until the KEP is approved to open PRs. Ill reference this feature issue from the PRs if/when that happens

/cc

@dashpole since the KEP for this issue isn't merged yet we will be removing it from the 1.14 milestone. To have it added back in please file an exception - information on the exception process can be found here: https://github.com/kubernetes/sig-release/blob/master/releases/EXCEPTIONS.md

@claurence where is it specified that KEPs must be merged by feature freeze?
In previous releases the only requirement was to have this issue open.

@claurence
https://github.com/kubernetes/sig-release/tree/master/releases/release-1.14#enhancements-freeze states:

"By Tuesday January 29, 2019 all enhancements landing in v1.14.0 must ... have an associated KEP merged or in progress in kubernetes/enhancements, linked to in the description of the tracking issue"

Hey @dashpole apologies as our docs have been changing a bit today - given feedback we've heard we are going to be lenient with KEPs though we want them merged by Feb 4th.

Added back to 1.14 per exception request submitted and approved

Hey @dashpole 馃憢! I'm Naomi, a v1.14 docs release shadow.

Does this enhancement require any new docs (or modifications)?

Just a friendly reminder we're looking for a PR against k/website (branch dev-1.14) due by Friday, March 1. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions!

Hello @dashpole , I'm the Enhancement Lead for 1.15. Is this feature going to be graduating alpha/beta/stable stages in 1.15? Please let me know so it can be tracked properly and added to the spreadsheet.

Once coding begins, please list all relevant k/k PRs in this issue so they can be tracked properly.

/milestone clear

@kacole2 I don't have any plans to graduate this in 1.15

/assign @dashpole

Hi @dashpole , I'm the 1.16 Enhancement Shadow. Is this feature going to be graduating alpha/beta/stable stages in 1.16? Please let me know so it can be added to the 1.16 Tracking Spreadsheet. If not's graduating, I will remove it from the milestone and change the tracked label.

Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thank you.

I don't have any plans for 1.16. We should migrate the metrics server to this endpoint before moving it to beta.

Hey there @dashpole , 1.17 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating to alpha/beta/stable in 1.17?

The current release schedule is:

  • Monday, September 23 - Release Cycle Begins
  • Tuesday, October 15, EOD PST - Enhancements Freeze
  • Thursday, November 14, EOD PST - Code Freeze
  • Tuesday, November 19 - Docs must be completed and reviewed
  • Monday, December 9 - Kubernetes 1.17.0 Released

If you do, I'll add it to the 1.17 tracking sheet (https://bit.ly/k8s117-enhancement-tracking). Once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 馃憤

Thanks!

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

/remove-lifecycle stale

Hey there @dashpole -- 1.18 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating to alpha|beta|stable in 1.18?

The current release schedule is:
Monday, January 6th - Release Cycle Begins
Tuesday, January 28th EOD PST - Enhancements Freeze
Thursday, March 5th, EOD PST - Code Freeze
Monday, March 16th - Docs must be completed and reviewed
Tuesday, March 24th - Kubernetes 1.18.0 Released

To be included in the release, this enhancement must have a merged KEP in the implementable status. The KEP must also have graduation criteria and a Test Plan defined.
If you would like to include this enhancement, once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 馃憤
We'll be tracking enhancements here: http://bit.ly/k8s-1-18-enhancements
Thanks!

As a reminder @dashpole :

Tuesday, January 28th EOD PST - Enhancements Freeze

Enhancements Freeze is in 7 days. If you seek inclusion in 1.18 please update as requested above.

Thanks!

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

/remove-lifecycle stale

Hi @dashpole !

1.19 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating in 1.19?

In order to have this part of the release:

The KEP PR must be merged in an implementable state
The KEP must have test plans
The KEP must have graduation criteria.

The current release schedule is:

Monday, April 13: Week 1 - Release cycle begins
Tuesday, May 19: Week 6 - Enhancements Freeze
Thursday, June 25: Week 11 - Code Freeze
Thursday, July 9: Week 14 - Docs must be completed and reviewed
Tuesday, August 4: Week 17 - Kubernetes v1.19.0 released

Please let me know and I'll add it to the 1.19 tracking sheet (http://bit.ly/k8s-1-19-enhancements). Once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 馃憤

Thanks!

As a reminder, enhancements freeze is tomorrow May 19th EOD PST. In order to be included in 1.19 all KEPS must be implementable with graduation criteria and a test plan.

Thanks.

Unfortunately the deadline for the 1.19 Enhancement freeze has passed. For now this is being removed from the milestone and 1.19 tracking sheet. If there is a need to get this in, please file an enhancement exception.

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

/remove-lifecycle stale

Hi @dashpole

Enhancements Lead here. Are there any plans for this 1.20?

Thanks!
Kirsten

Yeah, lets see if we can move this to beta in 1.20. The only blocker for beta is https://github.com/kubernetes-sigs/metrics-server/issues/559.

Great we will track this and I also updated the description to link to the merged KEP. :+1:

Hey @dashpole, just wanted to leave a friendly reminder that the Enhancements Freeze deadline is October 6th.

Can we please update the following:

Appreciate your work!! 馃槃

Regards,
Jeremy

Hey @dashpole , reminder that the 1.20 Enhancement Freeze deadline is October 6th.

Please update the KEP to include test plans if we are still planning on graduating to beta for the 1.20 milestone.

Regards,
Jeremy

Thanks for making that PR @dashpole

As a reminder, Enhancements Freeze deadline is Tomorrow October 6th EOD PST.

Hi

Enhancements Freeze is now in effect. Unfortunately, your the PR updating your KEP to include test plans has not merged. If you wish to be included in the 1.20 Release, please submit an Exception Request as soon as possible.

Best,
Kirsten
1.20 Enhancements Lead

Was this page helpful?
0 / 5 - 0 ratings

Related issues

majgis picture majgis  路  5Comments

justaugustus picture justaugustus  路  3Comments

xing-yang picture xing-yang  路  13Comments

justinsb picture justinsb  路  11Comments

wojtek-t picture wojtek-t  路  12Comments