Enhancements: Skip Volume Ownership Change

[mattsmithdatera]

Enhancement Description

• NewPermissionChangePolicy string field in PersistentVolumeClaimVolumeSource struct and related conditional volume ownership change behavior
• Primary contact (assignee): @mattsmithdatera @gnufied
• Responsible SIGs: sig-storage
• KEP: https://github.com/kubernetes/enhancements/blob/master/keps/sig-storage/695-skip-permission-change
• Link to e2e and/or unit tests: TBD
• Reviewer(s): @saad-ali @msau42
• Approver (likely from SIG/area to which enhancement belongs): @liggitt
• Enhancement target (which target equals to which milestone):
  
  
  
  • Alpha release target (x.y) 1.18
  
  
  • Beta release target (x.y) 1.20
  
  
  • Stable release target (x.y)
  
  

Pull request implementing this change: https://github.com/kubernetes/kubernetes/pull/73232

[mattsmithdatera]

/sig storage
/kind feature
cc @gnufied @saad-ali @msau42

[gnufied]

/sig api-machinery

[kacole2]

Hello @mattsmithdatera , I'm the Enhancement Lead for 1.15. Is this feature going to be graduating alpha/beta/stable stages in 1.15? Please let me know so it can be tracked properly and added to the spreadsheet. I also do not see a KEP. All enhancements require one to be included.

Once coding begins, please list all relevant k/k PRs in this issue so they can be tracked properly.

[justaugustus]

/assign @mattsmithdatera @gnufied

[evillgenius75]

Hi @mattsmithdatera I'm a 1.16 Enhancement Shadow. Is this feature going to be graduating alpha/beta/stable stages in 1.16? Please let me know so it can be added to the 1.16 Tracking Spreadsheetand the correct milestone and tracked label is applied.

As a reminder, every enhancement requires a KEP in an implementable state with Graduation Criteria explaining each alpha/beta/stable stages requirements. I see that the KEP #696 has yet to be merged.

Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thank you.

[kcmartin]

Hello @mattsmithdatera / @gnufied -- 1.17 Enhancement Shadow here! 🙂

I wanted to reach out to see if this enhancement will be graduating to alpha/beta/stable in 1.17?


Please let me know so that this enhancement can be added to 1.17 tracking sheet.

Thank you!

🔔Friendly Reminder

The current release schedule is

• Monday, September 23 - Release Cycle Begins
• Tuesday, October 15, EOD PST - Enhancements Freeze
• Thursday, November 14, EOD PST - Code Freeze
• Tuesday, November 19 - Docs must be completed and reviewed
• Monday, December 9 - Kubernetes 1.17.0 Released

[gnufied]

We are not doing anything for this in 1.17, but this is a problem that we are aiming to solve for 1.18.

[helayoty]

Hey @mattsmithdatera / @gnufied -- 1.18 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating to alpha in 1.18 or having a major change in its current level?

The current release schedule is:

Tuesday, January 28th EOD PST - Enhancements Freeze
Thursday, March 5th, EOD PST - Code Freeze
Monday, March 16th - Docs must be completed and reviewed
Tuesday, March 24th - Kubernetes 1.18.0 Released

To be included in the release, this enhancement must have a merged KEP in the implementable status. The KEP must also have graduation criteria and a Test Plan defined.

If you would like to include this enhancement, once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly.

Thanks!

[gnufied]

We could not make this feature in 1.17 timeline but we are trying to get this done as an alpha feature in 1.18. I have submitted a KEP with updated design https://github.com/kubernetes/enhancements/pull/1478 to address some of the issues raised in original design.

[helayoty]

Thanks @gnufied for the update. Kindly include all k/k PRs in the issue so they can be tracked

[helayoty]

/milestone v1.18

[irvifa]

Hello @mattsmithdatera @gnufied I'm one of the v1.18 docs shadows.
Does this enhancement for (or the work planned for v1.18) require any new docs (or modifications to existing docs)? If not, can you please update the 1.18 Enhancement Tracker Sheet (or let me know and I'll do so)

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.18) due by Friday, Feb 28th., it can just be a placeholder PR at this time. Let me know if you have any questions!

[irvifa]

Hello @mattsmithdatera @gnufied I'm one of the v1.18 docs shadows.

Does this enhancement for (or the work planned for v1.18) require any new docs (or modifications to existing docs)? If not, can you please update the 1.18 Enhancement Tracker Sheet (or let me know and I'll do so)

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.18) due by Friday, Feb 28th, which is roughly 1 weeks from now. It can just be a placeholder PR at this time. Let me know if you have any questions!

[jeremyrickard]

Hey @gnufied following up, can you please list out k/k PRs for this enhancement? We are getting close to code freeze on 05 March 2020.

Thanks

[gnufied]

@jeremyrickard thanks. The first PR that implements necessary api change is - https://github.com/kubernetes/kubernetes/pull/88488/files

Update: Same PR https://github.com/kubernetes/kubernetes/pull/88488 contains both API change and implementation.

[VineethReddy02]

Hello @gnufied
The docs placeholder PR deadline is tomorrow please raise a placeholder against the dev-1.18 branch. Having a placeholder PR in place will definitely help us in tracking enhancements much better.

Thanks! :)

[irvifa]

Hi @gnufied Following up, is this enhancement need any docs? If it is can you please create a placeholder PR? Since the deadline should be today.. Thanks!

[gnufied]

it does need docs PR and placeholder PR is - https://github.com/kubernetes/website/pull/19391

[helayoty]

Hi @gnufied We're only a few days out from code freeze now. It does not look like your PRs have merged yet, are you still feeling like you're on track for code freeze for this enhancement? Do you want to defer this to 1.19 based on the reviewer bandwidth? Or try and make a push?

[gnufied]

I will try to get merged before deadline.

[helayoty]

/milestone clear

[helayoty]

The Code freeze is in effect now. You may need to file an exception.

[msau42]

@helayoty code freeze is not until EOD pacific?

[jeremyrickard]

@msau42 yeah, that is correct. There was a correction email sent out, but EOD is 5 PM PST.

[gnufied]

Does this needs to be added back to 1.18 milestone or PR missed the milestone? The PR had necessary lgtm and approvals before 5.00PM PST.

[jeremyrickard]

@gnufied yeah I'll get it back in.

[jeremyrickard]

/milestone v1.18

[palnabarun]

/milestone clear

(removing this enhancement issue from the v1.18 milestone as the milestone is complete)

[gnufied]

@palnabarun we are planning to move this to beta in 1.19. Can we keep this in 1.19 milestone plz?

[johnbelamaric]

Hi @gnufied, I will add this to the tracking sheet.

/milestone v1.19

[annajung]

Hi @gnufied 👋 1.19 docs shadow here! Does this enhancement work planned for 1.19 require new or modification to docs?

Friendly reminder that if new/modification to docs are required, a placeholder PR against k/website (branch dev-1.19) are needed by Friday, June 12.

[annajung]

Hi @gnufied hope you're doing well, checking in again to see if docs are required for this or not. Could you confirm?

[annajung]

Hi @gnufied 👋 Checking in again. Please note if new or modification to current doc is required, then a placeholder PR against k/website (branch dev-1.19) is needed by Friday, June 12.

[annajung]

Hi @gnufied just adding on the comment above. If you're waiting to see if this will make it into 1.19 or be pushed to future release, Docs team still highly recommend getting the draft PR in before the due date as it's easier to clean up a draft PR then not having the draft in place to move this enhancement forward :)

[gnufied]

@annajung sorry for late response, I am aware of doc deadline. However we are going to leave this enhancement in alpha state in 1.19 and not going to move to beta. This is to ensure that this enhancement could be considered properly with selinux enhancement - https://github.com/kubernetes/enhancements/issues/1710

This decision was taken after KEP change to move this feature to beta merged.

[palnabarun]

@gnufied -- Thanks for the update about the status of the enhancement for this release. :+1:

I have updated the tracking sheet accordingly.

[palnabarun]

/milestone clear

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[kikisdeliveryservice]

Hi @gnufied

Enhancements Lead here. Are there any plans to get this to beta for this 1.20?

Thanks!
Kirsten

[gnufied]

@kikisdeliveryservice we are targeting beta of this feature in 1.20

[kikisdeliveryservice]

Thanks!

/milestone v1.20

[mikejoh]

Hi @gnufied :wave:!

I'm one of the Enhancement shadows for the 1.20 release cycle. I see that there's ongoing efforts to graduate this feature to beta. I just wanted to add a friendly reminder that the Enhancement freeze is roughly one week from now on the 6th of October!

[mikejoh]

Hi again @gnufied,

As a minor fix to the kep.yaml could you change the latest-milestone field to 1.20?

https://github.com/kubernetes/enhancements/blob/5f6d4f5cefa96bcf2d65d36b2f9bf8331e7441cd/keps/sig-storage/695-skip-permission-change/kep.yaml#L22

Thanks!

[xing-yang]

Hi @gnufied,

We are targeting Beta in 1.20, right? So the following line in kep.yaml should be updated to 1.20.

https://github.com/kubernetes/enhancements/blob/5f6d4f5cefa96bcf2d65d36b2f9bf8331e7441cd/keps/sig-storage/695-skip-permission-change/kep.yaml#L25

Thanks.

[mikejoh]

Hi @gnufied ,

Since your Enhancement is scheduled to be in 1.20, please keep in mind the important upcoming dates:

• Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline
• Thursday, Nov 12th: Week 9 - Code Freeze

As a reminder, please link all of your k/k PR as well as docs PR to this issue so we can track them.

Regards,
Mikael

[eagleusb]

Hello @gnufied :wave:, 1.20 Docs shadow here.

Does this enhancement work planned for 1.20 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.20 branch in the k/website repo.

This PR can be just a placeholder at this time and must be created before Nov 6th

Also take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

[eagleusb]

Hi @gnufied @mattsmithdatera :wave:

The docs placeholder deadline is almost here.

Please make sure to create a placeholder PR against the dev-1.20 branch in the k/website before the deadline.

Also, please keep in mind the important upcoming dates:

• Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline
• Thursday, Nov 12th: Week 9 - Code Freeze
• Monday, Nov 23rd: Week 11 - Docs PR Ready for ReviewAs a reminder, please link all of your k/k PR as well as docs PR to this issue for the release team to track.

[fedebongio]

Hi! API Machinery has going through the open enhancements for 1.20 and we came across this one, in which we were tagged almost a year ago. We will remove ourselves for now. If there is anything that we are missing by doing that, would you let us know?
Thanks in advance
/remove-sig api-machinery
/cc @deads2k @lavalamp

[kikisdeliveryservice]

@fedebongio

Doubling checked the tracking sheet and this is only tagged as storage there. :+1: Thanks for the update!

[kikisdeliveryservice]

Hi @gnufied @mattsmithdatera

I don't see any open or merged k/k prs related to this KEP, can you please update us with the status?

Just a reminder that Code Freeze is tomorrow Thursday, November 12th. All PRs must be merged by that date, otherwise an Exception is required.

Thanks,
Kirsten

[gnufied]

The Kubernetes PR that moves the feature gate to beta - https://github.com/kubernetes/kubernetes/pull/96376
PR that adds metrics for time taken to perform permission change - https://github.com/kubernetes/kubernetes/pull/95866
Add e2e for fsgroupchangepolicy - https://github.com/kubernetes/kubernetes/pull/96247

[kikisdeliveryservice]

Nice thanks @gnufied !! updating the tracking sheet!