Enhancements: Support Volume Expansion Through StatefulSets

[SidakM-zz]

Enhancement Description

• One-line enhancement description (can be used as a release note): Allow changes to storage requests in StatefulSets.volumeClaimTemplates to propagate to associated PVCs.
• Primary contact (assignee): @SidakM
• Responsible SIGs: sig-apps
• Design proposal link (community repo): https://github.com/kubernetes/enhancements/pull/660
• Link to e2e and/or unit tests:
• Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: @janetkuo @gnufied
• Approver (likely from SIG/area to which enhancement belongs):
• Enhancement target (which target equals to which milestone):
  
  
  
  • Alpha release target (1.14)
  
  
  • Beta release target (x.y)
  
  
  • Stable release target (x.y)
  
  

_Please to keep this description up to date. This will help the Enhancement Team track efficiently the evolution of the enhancement_

[SidakM-zz]

/kind feature
/sig apps

[janetkuo]

@kubernetes/sig-apps-feature-requests

[claurence]

@SidakM - Hello I'm the enhancements lead for 1.14. It looks like this issue is targeting 1.14 for alpha can you let me know if that is still planned. Enhancements freeze is Jan 29th and we want all issues to have a KEP associated with them.

[SidakM-zz]

Hey @claurence ,
Was waiting for a review from @kubernetes/sig-apps-feature-requests . Not sure when one of them will look at it though.

[k8s-ci-robot]

@SidakM: Reiterating the mentions to trigger a notification:
@kubernetes/sig-apps-feature-requests

In response to this:

Hey @claurence ,
Was waiting for a review from @kubernetes/sig-apps-feature-requests . Not sure when one of them will look at it though.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[claurence]

@SidakM checking in as enhancements freeze is on Tuesday - was the KEP reviewed? Are there any open PRs to track for the 1.14 cycle?

[SidakM-zz]

@claurence Someone looked and commented but didn't follow up after so I am unsure where its at.

[claurence]

@SidakM since the KEP for this issue isn't merged yet we will be removing it from the 1.14 milestone. To have it added back in please file an exception - information on the exception process can be found here: https://github.com/kubernetes/sig-release/blob/master/releases/EXCEPTIONS.md

[delgod]

@claurence it is critical functionality for stateful applications like databases.
If your run databases - you must to use StatefulSet.
so currently, PVC resize feature is mostly useless without StatefulSet resize.
please include it to 1.14 milestone.

[claurence]

@delgod because we have passed enhancement freeze and the KEP still is not merged please submit an exception request.

[chino]

Can we see something similar for DaemonSets?

[kacole2]

I'm the Enhancement Lead for 1.15. Is this feature going to be graduating alpha/beta/stable stages in 1.15? Please let me know so it can be tracked properly and added to the spreadsheet. Enhancements do require a KEP as well.

Once coding begins, please list all relevant k/k PRs in this issue so they can be tracked properly.

[justaugustus]

/assign @SidakM

[SidakM-zz]

@gnufied Can we get this in for 1.15?

[evillgenius75]

Hi @SidakM , I'm the 1.16 Enhancement Shadow. Is this feature going to be graduating alpha/beta/stable stages in 1.16? Please let me know so it can be added to the 1.16 Tracking Spreadsheet.

Once coding begins or if it already has, please list all relevant k/k PRs in this issue so they can be tracked properly.

As a reminder, every enhancement requires a KEP in an implementable state with Graduation Criteria explaining each alpha/beta/stable stages requirements merged into the k/e repo. The KEp is currently still open

Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thank you.

[archetec]

Why is this feature request keeps getting pushed to one Enhancement to another...? This is very important, not only for databases but also for Kafka clusters in production! Although it's possible to replicate to a new cluster with more storage, and then swtich over, it's not a viable solution. We need this!

[kacole2]

@archetec have you joined the meetings for SIG Apps and SIG Storage to see how this can be prioritized? So far, this is in infant stages because the KEP hasn't been approved. That means there is no community consensus for implementation of this feature.

[archetec]

@kacole2 I understand, and I just started to read about this... Please forgive my partial understanding of the process.

Reading comments on #660 it looks like there's a solution in review. But yes I see it's not approved yet, and looks like it's getting pushed to 1.17.

[gnufied]

@archetec the KEP has been approved but @SidakM was fine with moving it to 1.17 since getting the KEP merged within 1.16 time frame required requesting KEP exception. It is tricky feature and it is important to get the details right. We should have this implemented in 1.17.

[kcmartin]

Hello @SidakM -- 1.17 Enhancement Shadow here! 🙂

I wanted to reach out to see if this enhancement will be graduating to alpha/beta/stable in 1.17?


Please let me know so that this enhancement can be added to 1.17 tracking sheet.

Thank you!

🔔Friendly Reminder

The current release schedule is

• Monday, September 23 - Release Cycle Begins
• Tuesday, October 15, EOD PST - Enhancements Freeze
• Thursday, November 14, EOD PST - Code Freeze
• Tuesday, November 19 - Docs must be completed and reviewed
• Monday, December 9 - Kubernetes 1.17.0 Released

[SidakM-zz]

@kcmartin The goal is to graduate to alpha in 1.17. Waiting for api review. @gnufied

[kcmartin]

/milestone v1.17

[kcmartin]

Hi @SidakM We're only 5 days away from the Enhancements Freeze (Tuesday, October 15, EOD PST). Another friendly reminder that to be able to graduate this in the 1.17 release, KEP must have graduation criteria defined, in an implementable state, and merged in.

[SidakM-zz]

@gnufied As mentioned above the freeze is on Tuesday. Haven't heard back for the api review since I responded to the comments in the kep. Can we reach out for an update?

[gnufied]

@SidakM I agree with @liggitt that for the spec to be implementable - https://github.com/kubernetes/enhancements/pull/660#discussion_r325233794 comment needs to be addressed. As I understand it, this scenario can happen even if resize was successful and hence could prevent an user from rolling back.

[kcmartin]

Hey @SidakM / @gnufied , unfortunately deadline for 1.17 enhancement freeze has passed and looks like the KEP is still open. I will be removing this enhancement from the 1.17 milestone.

Please note that you can file an enhancement exception if you need to get this in for 1.17

/milestone clear

[dudicoco]

When will this feature finally be implemented? This would greatly improve stateful apps migration into k8s.

[stanislavkozlovski]

+1, much needed feature

[johnbelamaric]

Hey there @SidakM -- 1.18 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be implemented as alpha in 1.18?

The current release schedule is:
Monday, January 6th - Release Cycle Begins
Tuesday, January 28th EOD PST - Enhancements Freeze
Thursday, March 5th, EOD PST - Code Freeze
Monday, March 16th - Docs must be completed and reviewed
Tuesday, March 24th - Kubernetes 1.18.0 Released

To be included in the release, this enhancement must have a merged KEP in the implementable status. The KEP must also have graduation criteria and a Test Plan defined.
If you would like to include this enhancement, once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍
We'll be tracking enhancements here: http://bit.ly/k8s-1-18-enhancements
Thanks!

[kkmsft]

@SidakM : wondering are you still working/interested in continuing to work on this ?

[sowhatim]

+1 this should be very useful and important feature to have.

[johnbelamaric]

@janetkuo @SidakM I am on the enhancements team again for release 1.19. Any plans for this in 1.19?

[johnbelamaric]

@janetkuo @SidakM Ping! We need to track it in the release team if so - please let me know if there are any plans for this in 1.19.

_Enhancements freeze is in one week, on May 19._

In order to be in the release this KEP will need:

• To be implementable
• To have a test plan
• To have graduation criteria defined
• To have answers to the PRR questions in the template relevant to the stage

Thanks!

[johnbelamaric]

@janetkuo @SidakM Enhancements freeze is tomorrow. To be included in the release the KEP will need to meet the above criteria by then.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[abraithwaite]

/remove-lifecycle stale

[kikisdeliveryservice]

Hi @janetkuo @SidakM

Enhancements Lead here. Are there any plans for this 1.20?

Thanks!
Kirsten

[kikisdeliveryservice]

Hi @janetkuo @SidakM

Following up: 1.20 Enhancements Freeze is October 6th. Could you let us know if you have plans for 1.20?

To be included in the milestone:
The KEP must be merged in an implementable state
The KEP must have test plans
The KEP must have graduation criteria

Best,
Kirsten

[andyxning]

/sub

[andyxning]

As we are evolving to support resize in-use PVC, i think we need to support StatefulSet PVC change.