Enhancements: API Server Tracing

[dashpole]

Enhancement Description

• One-line enhancement description: Use distributed tracing for kube-apiserver requests.
• Primary contact: dashpole
• Responsible SIGs: Sig-Instrumentation
• Design proposal link: https://github.com/kubernetes/enhancements/pull/650
• KEP: https://github.com/kubernetes/enhancements/tree/master/keps/sig-instrumentation/647-apiserver-tracing
• Link to e2e and/or unit tests: Coming soon
• Reviewers - recommend having 2+ reviewers agreed to review. Reviewers from multiple companies preferred: @logicalhan @caesarxuchao
• Approver (likely from SIG/area to which enhancement belongs): @brancz @lavalamp
• Enhancement target (which target equals to which milestone):
  
  
  
  • Alpha release target (1.20)
  
  
  • Beta release target (TBD)
  
  
  • Stable release target (TBD)
  
  

_Please to keep this description up to date. This will help the Enhancement Team track efficiently the evolution of the enhancement_

[dashpole]

/sig instrumentation

[dashpole]

xref https://github.com/kubernetes/org/issues/285

[claurence]

@dashpole Hell - Enhancements lead for 1.14 here. I see this issue is targeted for Alpha in 1.14 - is that still planned for? Enhancements freeze is 1/29 and we want all enhancements in 1.14 to have a KEP associated with them.

[dashpole]

@claurence I am optimistically hoping for this to land in 1.14. The kep is https://github.com/kubernetes/enhancements/pull/650, which I added to the Enhancement Description above.

[claurence]

@dashpole thanks! Are there any open PRs for this issue that should be tracked in our sheet?

[dashpole]

@claurence not at the moment. I'll open the relevant PRs after the KEP is approved.

[claurence]

@dashpole since the KEP for this issue hasn't been merged yet we will be removing it from the 1.14 milestone. To have it added back in please file an exception - information on the exception process can be found here: https://github.com/kubernetes/sig-release/blob/master/releases/EXCEPTIONS.md

[kacole2]

I'm the Enhancement Lead for 1.15. Is this feature going to be graduating alpha/beta/stable stages in 1.15? Please let me know so it can be tracked properly and added to the spreadsheet.

Once coding begins, please list all relevant k/k PRs in this issue so they can be tracked properly.

[dashpole]

I don't have any plans to graduate this in 1.15

[justaugustus]

/assign @dashpole

[evillgenius75]

Hi @dashpole I'm the 1.16 Enhancement Shadow. Is this feature going to be graduating alpha/beta/stable stages in 1.16? Please let me know so it can be added to the 1.16 Tracking Spreadsheet.

Once coding begins or if it already has, please list all relevant k/k PRs in this issue so they can be tracked properly.

I noticed the KEP is still not merged. As a reminder, every enhancement requires a KEP in an implementable state with Graduation Criteria explaining each alpha/beta/stable stages requirements.

Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thank you.

[dashpole]

I don't have any plans to work on this in 1.16

[kcmartin]

Hello @dashpole -- 1.17 Enhancement Shadow here! 🙂

I wanted to reach out to see if this enhancement will be graduating to alpha/beta/stable in 1.17?


Please let me know so that this enhancement can be added to 1.17 tracking sheet.

Thank you!

🔔Friendly Reminder

The current release schedule is

• Monday, September 23 - Release Cycle Begins
• Tuesday, October 15, EOD PST - Enhancements Freeze
• Thursday, November 14, EOD PST - Code Freeze
• Tuesday, November 19 - Docs must be completed and reviewed
• Monday, December 9 - Kubernetes 1.17.0 Released

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[brancz]

/remove-lifecycle stale

[johnbelamaric]

@dashpole David are you planning on graduating this to beta in 1.18? I am shadowing for enhancements for the release team and will need to update the tracking sheet and milestone. Release schedule is:

Monday, January 6th - Release Cycle Begins
Tuesday, January 28th EOD PST - Enhancements Freeze
Thursday, March 5th, EOD PST - Code Freeze
Monday, March 16th - Docs must be completed and reviewed
Tuesday, March 24th - Kubernetes 1.18.0 Released

[dashpole]

@johnbelamaric this is targeted for Alpha in 1.18

[johnbelamaric]

Awesome. I will track it and mark it as At Risk until we get it to implementable and it has a test plan. I see you did the prod readiness survey - thanks!

[johnbelamaric]

/milestone v1.18

[johnbelamaric]

Moving to v1.19 per @dashpole
/milestone v1.19

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[dashpole]

/remove-lifecycle stale

[palnabarun]

Hi @dashpole -- 1.19 Enhancements Lead here, I wanted to check in if you think this enhancement would graduate in 1.19?

---

The current release schedule is:

• Monday, April 13: Week 1 - Release cycle begins
• Tuesday, May 19: Week 6 - Enhancements Freeze
• Thursday, June 25: Week 11 - Code Freeze
• Thursday, July 9: Week 14 - Docs must be completed and reviewed
• Tuesday, August 4: Week 17 - Kubernetes v1.19.0 released

[palnabarun]

Hi @dashpole, checking back again as a reminder to the above.

[dashpole]

@palnabarun This should hopefully be alpha for 1.19

[palnabarun]

Hi @dashpole, thank you for the update. I have the tracking sheet accordingly.

Please keep updating here the relevant k/k or other repository PR's for the release team to track, once work on the KEP starts.

[palnabarun]

/stage alpha

[palnabarun]

@dashpole -- I noticed that the KEP is still in provisional state and is missing Test Plans. Can you please update the KEP?

---

The Enhancements Freeze is on Tuesday, May 19 EOD Pacific Time

[dashpole]

ack. I asked the reviewers of the KEP update to give their feedback.

[palnabarun]

@dashpole -- Thanks for the update. I will check back later. :+1:

[palnabarun]

@dashpole -- Unfortunately the deadline for the 1.19 Enhancement freeze has passed. I see that the KEP is still missing test plans and is in a provisional state. Also, https://github.com/kubernetes/enhancements/pull/1458 is yet to be merged pending discussions.

For now this is being removed from the milestone and 1.19 tracking sheet. If there is a need to get this in, please file an enhancement exception.

[palnabarun]

/milestone clear

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[ashrayjain]

/remove-lifecycle stale

[kikisdeliveryservice]

Hi @dashpole

Enhancements Lead here. Are there any plans to graduate this to alpha in 1.20?

Thanks!
Kirsten

[dashpole]

Yes, I plan to work on this for 1.20

[kikisdeliveryservice]

/milestone v1.20

[kikisdeliveryservice]

Thanks @dashpole Please keep in mind the comments here ie provisional KEP & test plans still needs to be resolved before the Enhancements Freeze on October 6th.

[MorrisLaw]

Hey @dashpole, 1.20 Enhancements Shadow here 👋

Just a friendly reminder that Enhancements Freeze is October 6th and in order to include this KEP in the 1.20 release, we need the following:

• KEP must have test plans.
• KEP must be merged in an implementable state (PR #1458)

Last update in that PR looks to be May 28. Are discussions still pending regarding that do-not-merge/hold label?

[MorrisLaw]

As a reminder, Enhancements Freeze deadline is Tomorrow October 6th EOD PST.

[kikisdeliveryservice]

Hi @dashpole

Enhancements Freeze is now in effect. Unfortunately, your KEP was not updated as required. If you wish to be included in the 1.20 Release, please submit an Exception Request as soon as possible.

Best,
Kirsten
1.20 Enhancements Lead

[kikisdeliveryservice]

Hi @dashpole

Your Exception Request was approved so moving this back into 1.20 :+1:

[MorrisLaw]

Hi @dashpole,

Since your Enhancement is scheduled to be in 1.20, please keep in mind the important upcoming dates:
Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline
Thursday, Nov 12th: Week 9 - Code Freeze

As a reminder, please link all of your k/k PR as well as docs PR to this issue so we can track them.

Regards,
Jeremy

[SomtochiAma]

Hello @dashpole, 1.20 Docs shadow here 👋🏽.
Does this enhancement work planned for 1.20 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.20 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Nov 6th

Also take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

[annajung]

Hi @dashpole

Thanks for creating the docs PR!

Please keep in mind the important upcoming dates:

• ~Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline~ DONE!
• Thursday, Nov 12th: Week 9 - Code Freeze
• Monday, Nov 23rd: Week 11 - Docs PR Ready for Review

As a reminder, please link all of your k/k PR as well as docs PR to this issue for the release team to track.

[MorrisLaw]

Hi @dashpole

Just a friendly reminder to link any k/k PRs still in flight and that we need to have code merged in by Thursday if the aim is to have this in for the 1.20 milestone. Do we think this will make the deadline?

Important upcoming dates:

• Thursday, Nov 12th: Week 9 - Code Freeze
• Monday, Nov 23rd: Week 11 - Docs PR Ready for Review

[kikisdeliveryservice]

Hi @dashpole

Code Freeze is now in effect. Your PR is still unmerged, with no approvals and has a hold. If you believe this should be in the 1.20 Release, please file an Exception.

Best,
Kirsten

[kikisdeliveryservice]

For ref: some explanation here: https://github.com/kubernetes/kubernetes/pull/94942#issuecomment-726909452 on the compounded blocking issues (opentelemetry, grpc, etc) that caused this to not make 1.20.