Enhancements: aws-ebs-csi-driver alpha

Created on 24 Oct 2018 · 22Comments · Source: kubernetes/enhancements

Feature Description

One-line feature description (can be used as a release note): The Amazon Elastic Block Store CSI Driver provides a CSI interface used by Container Orchestrators to manage the lifecycle of EBS volumes.
Primary contact (assignee): @leakingtapan
Responsible SIGs: SIG AWS
Design proposal link (community repo): https://github.com/kubernetes/community/pull/2840
Link to e2e and/or unit tests:
https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/pkg/cloud/cloud_test.go
https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/pkg/cloud/metadata_test.go
https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/pkg/cloud/devicemanager/allocator_test.go
https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/pkg/cloud/devicemanager/manager_test.go
https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/pkg/driver/controller_test.go
https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/tests/sanity/sanity_test.go
Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: @bertinatto @gnufied
Approver (likely from SIG/area to which feature belongs): @jsafrane
Feature target (which target equals to which milestone):
- Alpha release target (1.13)
- Beta release target (1.14)
- Stable release target (1.15)

areprovideaws kinfeature lifecyclrotten sistorage stagalpha trackeno

Source

d-nishi

Most helpful comment

That's correct. I will amend the KEP with Beta changes

leakingtapan on 17 Jan 2019

👍2

All 22 comments

/sig aws

d-nishi on 24 Oct 2018

/assign @leakingtapan @d-nishi @bertinatto

d-nishi on 24 Oct 2018

/sig storage

d-nishi on 24 Oct 2018

Hi @d-nishi and @leakingtapan, I'm Enhancements Shadow for 1.13. Could you please update the release team with the progression of this enhancement for the 1.13 release?

Code slush begins on 11/9 and code freeze is 11/15.

Thank you!

ameukam on 6 Nov 2018

@ameukam --

code is ready.
CI signal is available here: https://testgrid.k8s.io/sig-aws-ebs-csi-driver
Docs are currently in the READme section: https://github.com/kubernetes-sigs/aws-ebs-csi-driver

Is this data enough?

d-nishi on 6 Nov 2018

👍1

/kind feature

d-nishi on 10 Nov 2018

@d-nishi - Hello I'm the enhancements lead for 1.14 - it looks like this feature is targeting beta in 1.14 can you confirm if that is correct? We want all enhancements to have a KEP, it looks like this issues KEP is here -https://github.com/kubernetes/enhancements/blob/master/keps/sig-aws/20181127-aws-ebs-csi-driver.md - let me know if that is not the correct KEP. Thanks.

claurence on 15 Jan 2019

That's correct. I will amend the KEP with Beta changes

leakingtapan on 17 Jan 2019

👍2

@claurence Here is the Beta release KEP.

leakingtapan on 29 Jan 2019

@claurence @leakingtapan @d-nishi I hate to keep hammering on this, but I don't think CSI drivers should be tracked as part of the Kubernetes core release. The whole point of CSI was to decouple plugin development from the development of core Kubernetes. There are so many CSI drivers. None of them have code shipping as part of k8s 1.14, and nothing that the release team needs to do for these drivers.

Therefore I suggest closing these issues or moving them out of the enhancements repo to somewhere else:

saad-ali on 30 Jan 2019

@saad-ali if I'm understanding correctly are you saying this issue should be removed from the milestone and be closed?

claurence on 30 Jan 2019

@claurence I will discuss this with @saad-ali and revert.

d-nishi on 30 Jan 2019

@saad-ali if I'm understanding correctly are you saying this issue should be removed from the milestone and be closed?

Yes

@claurence I will discuss this with @saad-ali and revert.

Happy to chat!

saad-ali on 30 Jan 2019

@saad-ali @d-nishi - checking on this issue - was it decided that is no longer needs to be tracked for 1.14?

If it's still being tracked for 1.14 - the KEP is marked as "provisional" - what additional work is needed for this KEP to be "implementable"?

claurence on 11 Feb 2019

@claurence @saad-ali and I agreed to open this issue for open discussion with SIG release members

This has been discussed with @justaugustus and @spiffxp

@spiffxp will tell us the appropriate approach for 1.14 release and we can formalize the approach in 1.15 based on what I was told last.

d-nishi on 12 Feb 2019

👍1

/milestone clear
I agree with @saad-ali the release team shouldn't track this for v1.14. I appreciate @d-nishi erring on the side of transparency here.

I'm of the opinion that release notes for kubernetes v1.14 shouldn't be talking about code that has landed out of tree. At present, a "release" only consists of bits that were cut from kubernetes/kubernetes.

However it would be useful for end users to know what out of tree subprojects / plugins / etc. have been released in the interim. This seems like appropriate content for the kubernetes blog. WDYT @nwoods3 @kbarnard10

spiffxp on 21 Feb 2019

Hello, I'm the Enhancement Lead for 1.15. Is this feature going to be graduating alpha/beta/stable stages in 1.15? Please let me know so it can be tracked properly and added to the spreadsheet.

Once coding begins, please list all relevant k/k PRs in this issue so they can be tracked properly.

kacole2 on 12 Apr 2019

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

fejta-bot on 11 Jul 2019

Hi @leakingtapan @d-nishi , I'm the 1.16 Enhancement Shadow. Is this feature going to be graduating alpha/beta/stable stages in 1.16? Please let me know so it can be added to the 1.16 Tracking Spreadsheet.

Once coding begins or if it already has, please list all relevant k/k PRs in this issue so they can be tracked properly.

As a reminder, every enhancement requires a KEP in an implementable state with Graduation Criteria explaining each alpha/beta/stable stages requirements.

Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thank you.

evillgenius75 on 11 Jul 2019

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

fejta-bot on 14 Aug 2019

/close
since csi drivers are tracked out of tree by storage providers

leakingtapan on 19 Aug 2019

@leakingtapan: Closing this issue.

In response to this:

/close
since csi drivers are tracked out of tree by storage providers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.