Enhancements: [Azure] Cross resource group nodes

Created on 31 Jul 2018 · 43Comments · Source: kubernetes/enhancements

Feature Description

One-line feature description (can be used as a release note): Add support of cross resource group nodes.
Primary contact (assignee): @feiskyer
Responsible SIGs: sig-azure
Design proposal link (community repo): https://github.com/kubernetes/community/pull/2479
KEP: 20180809-cross-resource-group-nodes
Link to e2e and/or unit tests:
Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: @khenidak
Approver (likely from SIG/area to which feature belongs): @brendandburns
Feature target (which target equals to which milestone):
- Alpha release target (1.12)
- Beta release target (1.15)
- Stable release target (x.y)

areprovideazure kinfeature stagstable

Source

feiskyer

Most helpful comment

@VineethReddy02 Thanks, no new docs are required.

feiskyer on 2 Aug 2019

🚀2 👍1

All 43 comments

/sig azure
/milestone v1.12

feiskyer on 31 Jul 2018

/kind feature
/stage alpha

feiskyer on 31 Jul 2018

@feiskyer thank you. this has been added to the 1.12 Feature Tracking sheet. Please keep the post updated with links to PRs and design docs proposals.

kacole2 on 31 Jul 2018

👍2

Community PR created https://github.com/kubernetes/community/pull/2479

feiskyer on 6 Aug 2018

Hey there! @feiskyer I'm the wrangler for the Docs this release. Is there any chance I could have you open up a docs PR against the release-1.12 branch as a placeholder? That gives us more confidence in the feature shipping in this release and gives me something to work with when we start doing reviews/edits. Thanks! If this feature does not require docs, could you please update the features tracking spreadsheet to reflect it?

zparnold on 20 Aug 2018

@zparnold We will update docs in repo https://github.com/kubernetes/cloud-provider-azure. Should it also be placeholded?

feiskyer on 21 Aug 2018

Only if it needs to go into the general https://kubernetes.io/ website
docs. :)

On Mon, Aug 20, 2018 at 9:47 PM Pengfei Ni notifications@github.com wrote:

@zparnold https://github.com/zparnold We will update docs in repo
https://github.com/kubernetes/cloud-provider-azure. Should it also be
placeholded?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/features/issues/604#issuecomment-414532102,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AE81SPUL3EjV9Wte-npQHzQYGOzLxPFoks5uS3SzgaJpZM4VoNqe
.

zparnold on 25 Aug 2018

@feiskyer -- it would be nice to have a blurb about configuring this on kubernetes.io

justaugustus on 29 Aug 2018

@justaugustus Which folder do you suggest?

feiskyer on 29 Aug 2018

@justaugustus Yep, codes have been merged now and docs will be added to https://github.com/kubernetes/cloud-provider-azure

feiskyer on 6 Sep 2018

Thanks for the update!

justaugustus on 6 Sep 2018

Hi folks,
Kubernetes 1.13 is going to be a 'stable' release since the cycle is only 10 weeks. We encourage no big alpha features and only consider adding this feature if you have a high level of confidence it will make code slush by 11/09. Are there plans for this enhancement to graduate to alpha/beta/stable within the 1.13 release cycle? If not, can you please remove it from the 1.12 milestone or add it to 1.13?

We are also now encouraging that every new enhancement aligns with a KEP. If a KEP has been created, please link to it in the original post. Please take the opportunity to develop a KEP.

ameukam on 5 Oct 2018

It's already part of KEP, https://github.com/kubernetes/community/pull/2479. Let's keep it in v1.13.

/milestone v1.13

feiskyer on 5 Oct 2018

👍1

@feiskyer can you please update the original post with milestone of beta for 1.13? Thanks!
/stage beta

kacole2 on 5 Oct 2018

can you please update the original post with milestone of beta for 1.13? Thanks!

@kacole2 Sorry, didn't catch you. The PR has already been merged, why its milestone should be changed?

feiskyer on 6 Oct 2018

@feiskyer sorry, I should have been more clear. In the original post description please update the milestone information so it’s clear

Feature target (which target equals to which milestone):
Alpha release target (1.12)
Beta release target (x.y)
Stable release target (x.y)

kacole2 on 6 Oct 2018

@kacole2 Thanks. Updated.

feiskyer on 6 Oct 2018

@feiskyer what work is left for this to land in Beta in 1.13? Is there a list of pending PRs we are tracking for this (code, test and docs) or is everything merged?

AishSundar on 17 Oct 2018

Hi @feiskyer, will there be any updates to the docs necessary for 1.13? The deadline for placeholder PRs for the 1.13 release is November 8. So it's important to make a docs PR as soon as possible if needed.

tfogo on 3 Nov 2018

@feiskyer is this still on track for 1.13? is there any pending PR for this for 1.13 - code, docs ? We are fast approaching Code slush (11/9) and Code freeze (11/16)

AishSundar on 5 Nov 2018

@AishSundar No docs updates required in this release, thanks.

feiskyer on 6 Nov 2018

Also from offline discussion with @feiskyer looks like all code changes are in for this !

AishSundar on 6 Nov 2018

@feiskyer Hello - I’m the enhancement’s lead for 1.14 and I’m checking in on this issue to see what work (if any) is being planned for the 1.14 release. Enhancements freeze is Jan 29th and I want to remind that all enhancements must have a KEP - it looks like this issue has a KEP here: https://github.com/kubernetes/enhancements/blob/master/keps/sig-azure/0025-20180809-cross-resource-group-nodes.md - let me know if that isn't accurate

claurence on 14 Jan 2019

yep, it's being tracked by the KEP 25, and it'll still be in beta stage in v1.14.

feiskyer on 15 Jan 2019

👍1

@feiskyer any open PRs for the 1.14 cycle?

claurence on 22 Jan 2019

@claurence not yet.

feiskyer on 22 Jan 2019

I'm the Enhancement Lead for 1.15. Is this feature going to be graduating alpha/beta/stable stages in 1.15? Please let me know so it can be tracked properly and added to the spreadsheet.

Once coding begins, please list all relevant k/k PRs in this issue so they can be tracked properly.

kacole2 on 12 Apr 2019

yep, this is on tracked.

/milestone v1.15

feiskyer on 12 Apr 2019

@feiskyer, we're doing a KEP review for enhancements to be included in the Kubernetes v1.15 milestone. After reviewing your KEP, it's currently missing test plans and graduation criteria which is required information per the KEP Template. Please update the KEP to include the required information before the Kubernetes 1.15 Enhancement Freeze date of 4/30/2019. Thank you

kacole2 on 29 Apr 2019

@feiskyer, Enhancement Freeze for Kubernetes 1.15 has passed and this did not meet the deadline. Still missing Test Plans and Graduation Criteria from the KEP. This is now being removed from the 1.15 milestone and the tracking sheet. If there is a need for this to be in 1.15, please file an Enhancement Exception. Thank you. @claurence

/milestone clear

kacole2 on 1 May 2019

/milestone v1.16

feiskyer on 5 Jul 2019

Hi @feiskyer , I'm a 1.16 Enhancement Shadow. Is this feature going to be graduating alpha/beta/stable stages in 1.16? Please let me know so it can be added to the 1.16 Tracking Spreadsheet. If it's not graduating, I will remove it from the milestone and change the tracked label.

Once coding begins or if it already has, please list all relevant k/k PRs in this issue so they can be tracked properly.

Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thanks!

rbitia on 11 Jul 2019

@rbitia Yep, already added to 1.16 milestone

feiskyer on 12 Jul 2019

Are you planning to graduate to stable or beta?

rbitia on 15 Jul 2019

Hey @rbitia! We're going GA/Stable with this in 1.16. :)

justaugustus on 15 Jul 2019

Yep, we're working on the e2e tests for this.

feiskyer on 30 Jul 2019

Hi @feiskyer, I'm the v1.16 docs release shadow.

Does this enhancement require any new docs (or modifications)?

Just a friendly reminder we're looking for a PR against k/website (branch dev-1.16) due by Friday,August 23rd. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions!

Thanks!

VineethReddy02 on 1 Aug 2019

@VineethReddy02 Thanks, no new docs are required.

feiskyer on 2 Aug 2019

🚀2 👍1

@feiskyer urgent request can you please update the KEP with Graduation Criteria. This is a requirement for being included in the current 1.16 milestone. Please respond back with the PR ASAP. Thank you.

kacole2 on 5 Aug 2019

@kacole2 thanks, would do

feiskyer on 6 Aug 2019

Update: PR sent at https://github.com/kubernetes/enhancements/pull/1202

feiskyer on 6 Aug 2019

Documents have been added at https://github.com/kubernetes/cloud-provider-azure/blob/master/docs/using-cross-resource-group-nodes.md.

E2e tests have been added at https://github.com/kubernetes/cloud-provider-azure/pull/205.

Because aks-engine doesn't support to provision cross-resource-group nodes, the e2e tests couldn't be run periodically yet. But I think aks-engine should not be the blocker for this feature.

/close

feiskyer on 9 Aug 2019

@feiskyer: Closing this issue.

In response to this:

Documents have been added at https://github.com/kubernetes/cloud-provider-azure/blob/master/docs/using-cross-resource-group-nodes.md.

E2e tests have been added at https://github.com/kubernetes/cloud-provider-azure/pull/205.

Because aks-engine doesn't support to provision cross-resource-group nodes, the e2e tests couldn't be run periodically yet. But I think aks-engine should not be the blocker for this feature.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.