Enhancements: RuntimeClass

[tallclair]

Enhancement Description

• One-line feature description (can be used as a release note): RuntimeClass is a new cluster-scoped resource that surfaces container runtime properties to the control plane.
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/runtime-class.md
• Primary contact (assignee): @tallclair
• Responsible SIGs: sig-node
• Feature target (which target equals to which milestone):
  
  
  
  • Alpha release target: 1.12
  
  
  • Beta release target: 1.14
  
  
  • Stable release target: x.y
  
  

---

EDIT(spiffxp): I edited this to match the current enhancement tracking issue template, the following entries or content are not part of the template

• Reviewer(s): @dchen1107 @yujuhong @derekwaynecarr
• Approver(s): @dchen1107 @yujuhong @derekwaynecarr

[tallclair]

/sig node
/milestone v1.12

[justaugustus]

@tallclair --

It looks like this feature is currently in the Kubernetes 1.12 Milestone.

If that is still accurate, please ensure that this issue is up-to-date with ALL of the following information:

• One-line feature description (can be used as a release note):
• Primary contact (assignee):
• Responsible SIGs:
• Design proposal link (community repo):
• Link to e2e and/or unit tests:
• Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
• Approver (likely from SIG/area to which feature belongs):
• Feature target (which target equals to which milestone):
  
  
  
  • Alpha release target (x.y)
  
  
  • Beta release target (x.y)
  
  
  • Stable release target (x.y)
  
  

Set the following:

• Description
• Assignee(s)
• Labels:
  
  
  
  • stage/{alpha,beta,stable}
  
  
  • sig/*
  
  
  • kind/feature
  
  

Once this feature is appropriately updated, please explicitly ping @justaugustus, @kacole2, @robertsandoval, @rajendar38 to note that it is ready to be included in the Features Tracking Spreadsheet for Kubernetes 1.12.

---

Please note that the Features Freeze is July 31st, after which any incomplete Feature issues will require an Exception request to be accepted into the milestone.

In addition, please be aware of the following relevant deadlines:

• Docs deadline (open placeholder PRs): 8/21
• Test case freeze: 8/28

Please make sure all PRs for features have relevant release notes included as well.

Happy shipping!
/kind feature
/stage alpha

[derekwaynecarr]

LGTM

[justaugustus]

Thanks for the update! This has been added to the 1.12 Tracking sheet.

[zparnold]

Hey there! @tallclair I'm the wrangler for the Docs this release. Is there any chance I could have you open up a docs PR against the release-1.12 branch as a placeholder? That gives us more confidence in the feature shipping in this release and gives me something to work with when we start doing reviews/edits. Thanks! If this feature does not require docs, could you please update the features tracking spreadsheet to reflect it?

[tallclair]

@zparnold what are the docs expectations for alpha features?

[zparnold]

Hey @tallclair I think in order to get usage out of the feature it's best to document it in the same way it would be a beta/GA feature. Then if people file issues against it we can improve the feature/docs. What do you think?

[tianshapjq]

Are there any docs on the available options about RuntimeClassName to be able to leverage this feature?

[tallclair]

https://github.com/kubernetes/website/pull/10102 will provide the documentation, but it's not written yet.

[tallclair]

Unless you're looking for https://github.com/kubernetes/community/blob/master/keps/sig-node/0014-runtime-class.md

[zparnold]

Thanks!

On Thu, Aug 30, 2018 at 12:58 PM Tim Allclair (St. Clair) <
[email protected]> wrote:

Unless you're looking for
https://github.com/kubernetes/community/blob/master/keps/sig-node/0014-runtime-class.md

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/features/issues/585#issuecomment-417448101,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AE81SG8dCfMJqkktvR1fiIykYpqElXTpks5uWEPvgaJpZM4VJ8Uv
.

[justaugustus]

@tallclair --
Any update on docs status for this feature? Are we still planning to land it for 1.12?
At this point, code freeze is upon us, and docs are due on 9/7 (2 days).
If we don't here anything back regarding this feature ASAP, we'll need to remove it from the milestone.

cc: @zparnold @jimangel @tfogo

[justaugustus]

@tallclair -- is this good to go for 1.12? Docs are overdue. Please let us know ASAP what the status is.

[tallclair]

Sorry, was out last week - This made the 1.12 cut (alpha). Docs PR merged: https://github.com/kubernetes/website/pull/10102

[ameukam]

Hi folks,
Kubernetes 1.13 is going to be a 'stable' release since the cycle is only 10 weeks. We encourage no big alpha features and only consider adding this feature if you have a high level of confidence it will make code slush by 11/09. Are there plans for this enhancement to graduate to alpha/beta/stable within the 1.13 release cycle? If not, can you please remove it from the 1.12 milestone or add it to 1.13?

We are also now encouraging that every new enhancement aligns with a KEP. If a KEP has been created, please link to it in the original post. Please take the opportunity to develop a KEP.

[tallclair]

There are no plans for big changes to RuntimeClass in 1.13. I'm hoping to bring it to beta in 1.14.

If not, can you please remove it from the 1.12 milestone or add it to 1.13?

I'm confused by this... it's not graduating in 1.13 but you want it in the 1.13 milestone? Was that a typo?

[kacole2]

@tallclair apologies. This will be removed from all milestones. Only added to 1.13 if there was a need for it to be. thanks for responding
/milestone clear

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[claurence]

@tallclair Hello - I’m the enhancement’s lead for 1.14 and I’m checking in on this issue to see what work (if any) is being planned for the 1.14 release. Enhancements freeze is Jan 29th and I want to remind that all enhancements must have a KEP

[tallclair]

/remove-lifecycle stale

I intend to take this feature to Beta in v1.14. I will update the KEP soon with the plans.

[claurence]

thanks @tallclair - any open PRs for this issue we should track for 1.14? Thanks

[tallclair]

not yet

[tallclair]

Actually, https://github.com/kubernetes/enhancements/pull/697 updates the KEP with the beta criteria.

[thockin]

I'll take API.

@vishh shadow

[jaredbhatti]

Hey folks, I'm helping out with the docs for v1.14.

Just a friendly reminder we're looking for a PR against k/website (branch dev-1.14) due by Friday, March 1. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions or need additional guidance!

[lachie83]

Hello @tallclair, 1.14 enhancement shadow here. Code Freeze is March 7th and all PRs must be merged by then to your issue to make the 1.14 release. What open K/K PRs do you still have that need to merge? Thanks

[tallclair]

• [x] https://github.com/kubernetes/kubernetes/pull/74433 is the most important, which migrates to an internal API and adds the beta API
• [x] Bump feature gate, blocked on beta API
• [x] https://github.com/kubernetes/enhancements/pull/723 - Mostly just process, but ticks a box on the graduation requirements & improves documentation
• [x] More testing - https://github.com/kubernetes/kubernetes/pull/74757

[jaredbhatti]

I noticed you linked to a merged PR for docs that went out in the last release - are there no docs changes per this release?

[tallclair]

Thanks for pointing that out @jaredbhatti, I'm afraid I missed your last comment. I see that I've missed the March 1st deadline for this, but if it's not too late I've opened https://github.com/kubernetes/website/pull/13043

[spiffxp]

/remove-stage alpha
/stage beta
reconciling with https://bit.ly/k8s114-enhancements

[kacole2]

I'm the Enhancement Lead for 1.15. Is this feature going to be graduating alpha/beta/stable stages in 1.15? Please let me know so it can be tracked properly and added to the spreadsheet.

Once coding begins, please list all relevant k/k PRs in this issue so they can be tracked properly.

[tallclair]

This will remain in beta for 1.15, but we are making to related enhancements:

1. Scheduling - https://github.com/kubernetes/enhancements/issues/894
2. Pod Overhead - https://github.com/kubernetes/enhancements/issues/688

[rbitia]

Hi @tallclair, & @thockin, I'm the 1.16 Enhancement Shadow. Is this feature going to be graduating alpha/beta/stable stages in 1.16? Please let me know so it can be added to the 1.16 Tracking Spreadsheet. If it's not's graduating, I will remove it from the milestone and change the tracked label.

Once coding begins or if it already has, please list all relevant k/k PRs in this issue so they can be tracked properly.

Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thanks!

[tallclair]

RuntimeClass will remain in beta for 1.16. The 2 changes to RuntimeClass are tracked separately:
https://github.com/kubernetes/enhancements/issues/688
https://github.com/kubernetes/enhancements/issues/894

[jeremyrickard]

Hey there @tallclair -- 1.17 Enhancements shadow here 👋 . I wanted to check in and see if you think this Enhancement will be graduating to stable in 1.17?

The current release schedule is:

• Monday, September 23 - Release Cycle Begins
• Tuesday, October 15, EOD PST - Enhancements Freeze
• Thursday, November 14, EOD PST - Code Freeze
• Tuesday, November 19 - Docs must be completed and reviewed
• Monday, December 9 - Kubernetes 1.17.0 Released

If you do, I'll add it to the 1.17 tracking sheet (https://bit.ly/k8s117-enhancements). Once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!

[tallclair]

No changes planned for v1.17

[jeremyrickard]

Thanks @tallclair.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[palnabarun]

/remove-lifecycle stale

[palnabarun]

Hey there @tallclair -- 1.18 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating to [alpha|beta|stable] in 1.18 or having a major change in it's current level?

The current release schedule is:

• Monday, January 6th - Release Cycle Begins
• Tuesday, January 28th EOD PST - Enhancements Freeze
• Thursday, March 5th, EOD PST - Code Freeze
• Monday, March 16th - Docs must be completed and reviewed
• Tuesday, March 24th - Kubernetes 1.18.0 Released

To be included in the release,

1. The KEP PR must be merged
2. The KEP must be in an implementable state
3. The KEP must have test plans and graduation criteria.

If you would like to include this enhancement, once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

We'll be tracking enhancements here: http://bit.ly/k8s-1-18-enhancements

Thanks! :)

[tallclair]

No changes planned, except to PodOverhead, which is tracked separately.

[palnabarun]

Cool. Thanks. :)

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[palnabarun]

/remove-lifecycle stale

[msedzins]

Hey there @tallclair , @thockin -- 1.19 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating in 1.19?

In order to have this part of the release:

1. The KEP PR must be merged in an implementable state
2. The KEP must have test plans
3. The KEP must have graduation criteria.

The current release schedule is:

• Monday, April 13: Week 1 - Release cycle begins
• Tuesday, May 19: Week 6 - Enhancements Freeze
• Thursday, June 25: Week 11 - Code Freeze
• Thursday, July 9: Week 14 - Docs must be completed and reviewed
• Tuesday, August 4: Week 17 - Kubernetes v1.19.0 released

If you do, I'll add it to the 1.19 tracking sheet (http://bit.ly/k8s-1-19-enhancements). Once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!

[tallclair]

No changes planned for v1.19. We might go to GA in v1.20.

[msedzins]

Thank you @tallclair for letting me know.

[msedzins]

/milestone v1.20

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[palnabarun]

/remove-lifecycle stale

[kikisdeliveryservice]

Hi @tallclair

Enhancements Lead here, do you still intend to go GA in 1.20?

Thanks!
Kirsten

[tallclair]

Yep, still planned for v1.20. See https://docs.google.com/document/d/17nROj6ayPsUpx09mhLrzOkRLgo-8sn6Vgfyy-gmyuo4/edit#heading=h.3qoppsm7jdvw for planning.

/assign @saschagrunert
/unassign @thockin

[kikisdeliveryservice]

thanks @tallclair

/milestone v1.20

[saschagrunert]

The SIG Node feature health check tells me that @harche would like to take this.
/assign @harche

[k8s-ci-robot]

@saschagrunert: GitHub didn't allow me to assign the following users: harche.

Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

The SIG Node feature health check tells me that @harche would like to take this.
/assign @harche

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[harche]

thanks @saschagrunert

[spiffxp]

/assign @harche
(now that they have commented on this issue, github should allow assigning)

[kikisdeliveryservice]

As noted on the KEP, a test plan (which seems to exist in the word doc) and graduation criteria (which has alpha, beta but is missing stable) will need to be added to the KEP and the PR should merge by Enhancement Freeze tomorrow October 6th.

Please let me know if you have any questions.

Best,
Kirsten

cc: @kinarashah

[kinarashah]

Hi all,

1.20 Enhancement shadow here 👋

Since this Enhancement is scheduled to be in 1.20, please keep in mind these important upcoming dates:
Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline
Thursday, Nov 12th: Week 9 - Code Freeze

As a reminder, please link all of your k/k PR as well as docs PR to this issue so we can track them.

Thank you!

[reylejano-rxm]

Hello @tallclair , 1.20 Docs shadow here.

Does this enhancement work planned for 1.20 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against the dev-1.20 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Nov 6th.

Also take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

[tallclair]

@SergeyKanzhelev can you answer @reylejano-rxm 's question?

[SergeyKanzhelev]

@harche was going to submit this PR. @harche are you still up for it? I can do it, not a problem.

[harche]

Yeah, I have to focus on one critical customer issue so if you can do it, that would be a great help. Otherwise I can look into it sometime next week.

[SergeyKanzhelev]

Website PR: https://github.com/kubernetes/website/pull/24698/

[kikisdeliveryservice]

Hey all,

I see that kubernetes/kubernetes#95718 is still unmerged but alllmost finished. Is that all we're waiting code-wise?

Just a reminder that Code Freeze is coming up tomorrow on Thursday, November 12th. All PRs must be merged by that date, otherwise an Exception is required.

Thanks
Kirsten

[SergeyKanzhelev]

Hey all,

I see that kubernetes/kubernetes#95718 is still unmerged but alllmost finished. Is that all we're waiting code-wise?

Just a reminder that Code Freeze is coming up in 2 days on Thursday, November 12th. All PRs must be merged by that date, otherwise an Exception is required.

Yes, fixing an issue with the code, but overall PR is good to go otherwise. Thank you for reminder

[kikisdeliveryservice]

"coming up in 2days" --> "coming up tomorrow" (sorry for the bad copypasta)

Thanks for the update!

[kikisdeliveryservice]

It merge and this is in before Code Freeze! :dancers:

[SergeyKanzhelev]

there is another issue arose - mentioned it. It is test-related though so theoretically can be fixed after code freeze. I will try to get it in today

[kikisdeliveryservice]

Update: Asked a q here: https://github.com/kubernetes/kubernetes/issues/96524#issuecomment-726324953 re: conformance test requirement for GA APIs. There's also some discussion on slack, so would like the final word before marking this as Done per Code Freeze.

As a note: Code Freeze means that required tests must also be finished: https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#code-freeze

[jeremyrickard]

@SergeyKanzhelev this is more than test-related. I think per the release phases definitions:

All enhancements going into the release must be code-complete, including tests, and have docs PRs open by the due date.

In this case, you're ADDING a new tests no? Then that needs to be promoted to Conformance. As this is going GA, it's very important that we have these things in place. And this really should have been done before code freeze.

You will need to file an exception request for this, I think, so we can discuss the implications.

[hh]

From #k8s-conformance slack conversation https://kubernetes.slack.com/archives/C78F00H99/p1605209694093700:

From what I recall, two weeks as a flakiness check was not based on data. I would be open to adjusting that if the data shows that tests with say 1 week or 10 days of clean runs are highly likely to have 2 weeks of clean runs. @johnbelamaric

i'm open to that too @smarterclayton

If we can get solid conformance tests on these endpoints this week, this should allow 7-10 days of non-flakey CI runs:

https://apisnoop.cncf.io/conformance-progress/endpoints/1.20.0?filter=promoted-without-tests

[jeremyrickard]

@hh thank you for that additional context and input.

@SergeyKanzhelev could you please open a code freeze exception request for this (assuming you won't have a PR for this merged by code freeze today). Otherwise, I think we'll need to talk about reverting this for the 1.20 release, as it's lacking the conformance tests.

[SergeyKanzhelev]

@SergeyKanzhelev could you please open a code freeze exception request for this (assuming you won't have a PR for this merged by code freeze today). Otherwise, I think we'll need to talk about reverting this for the 1.20 release, as it's lacking the conformance tests.

Can you please help me with this? Where I can read about exception process/form?

[jeremyrickard]

@SergeyKanzhelev oh sorry! I thought I had linked it above! 😞

You can find the process documented here.

In essence:

Enhancement Owners
To file for an exception, please fill out the questions below:

Enhancement name:
Enhancement status (alpha/beta/stable):
SIG:
k/enhancements repo issue #:
PR #’s:
Additional time needed (in days):
Reason this enhancement is critical for this milestone:
Risks from adding code late: (to k8s stability, testing, etc.)
Risks from cutting enhancement: (partial implementation, critical customer usecase, etc.)
Email them to:

Your SIG's mailing list
[email protected]
[email protected]

We'll need to know how many days you'll need for the work to get the tests turned around.

Thanks so much!!

[SergeyKanzhelev]

sure. Since tests freeze is 23rd - should I already file an exception? Or if PR will be merged tomorrow it will be fine?

(I know, this is not ideal and should have known about these tests before)

[kikisdeliveryservice]

@SergeyKanzhelev

Code Freeze requires: "All enhancements going into the release must be code-complete, including tests"

So yes you will need to file an exception as this test is a requirement for your feature to be GA - as of now it is not complete. Please file an exception ASAP (Jeremy linked above).

[kikisdeliveryservice]

Hi @SergeyKanzhelev

Code Freeze is now in effect. As discussed above, you will need to file an Exception.

Best,
Kirsten

[kikisdeliveryservice]

An exception was filed and granted:
https://groups.google.com/g/kubernetes-sig-release/c/0b5SQLz2tZg/m/6x26WRccAgAJ

/milestone v1.20

[kikisdeliveryservice]

As an update: https://github.com/kubernetes/kubernetes/pull/96551 has merged and we are waiting for sufficient runs to promote to conformance via another pr (https://github.com/kubernetes/kubernetes/pull/96551#issuecomment-726989775)

[kikisdeliveryservice]

Looks like the conformance tests are in. Updating the tracking sheet.

[SergeyKanzhelev]

@kikisdeliveryservice thank you!

[hh]

Congrats on the Conformance Test Promotion:

https://apisnoop.cncf.io/1.20.0/stable/node

[hh]

https://apisnoop.cncf.io/conformance-progress/endpoints/1.20.0?filter=promoted-with-tests