Enhancements: APIServer DryRun

[apelisse]

Feature Description

• One-line feature description (can be used as a release note):
  Add apiserver "dry-run" query-parameter so that requests can be validated and "processed" without actually being persisted.
• Primary contact (assignee): @apelisse
• Responsible SIGs: @kubernetes/sig-api-machinery-feature-requests
• Design proposal link (community repo)/KEP:
  https://github.com/kubernetes/enhancements/blob/master/keps/sig-api-machinery/0015-dry-run.md
• Link to e2e and/or unit tests: None yet
• Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: @deads2k @lavalamp
• Approver (likely from SIG/area to which feature belongs): @lavalamp
• Feature target (which target equals to which milestone):
  
  
  
  • Alpha release target (x.y): 1.12
  
  
  • Beta release target (x.y): 1.13
  
  
  • Stable release target (x.y): 1.18
  
  

[apelisse]

Fixes https://github.com/kubernetes/kubernetes/issues/65435

[justaugustus]

@apelisse --

It looks like this feature is currently in the Kubernetes 1.12 Milestone.

If that is still accurate, please ensure that this issue is up-to-date with ALL of the following information:

• One-line feature description (can be used as a release note):
• Primary contact (assignee):
• Responsible SIGs:
• Design proposal link (community repo):
• Link to e2e and/or unit tests:
• Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
• Approver (likely from SIG/area to which feature belongs):
• Feature target (which target equals to which milestone):
  
  
  
  • Alpha release target (x.y)
  
  
  • Beta release target (x.y)
  
  
  • Stable release target (x.y)
  
  

Set the following:

• Description
• Assignee(s)
• Labels:
  
  
  
  • stage/{alpha,beta,stable}
  
  
  • sig/*
  
  
  • kind/feature
  
  

Please note that the Features Freeze is July 31st, after which any incomplete Feature issues will require an Exception request to be accepted into the milestone.

In addition, please be aware of the following relevant deadlines:

• Docs deadline (open placeholder PRs): 8/21
• Test case freeze: 8/28

Please make sure all PRs for features have relevant release notes included as well.

Happy shipping!

/cc @justaugustus @kacole2 @robertsandoval @rajendar38
/kind feature
/stage alpha

[apelisse]

@justaugustus I think we're good!

[justaugustus]

Thanks for the update, @apelisse!

[zparnold]

Hey there! @apelisse I'm the wrangler for the Docs this release. Is there any chance I could have you open up a docs PR against the release-1.12 branch as a placeholder? That gives us more confidence in the feature shipping in this release and gives me something to work with when we start doing reviews/edits. Thanks! If this feature does not require docs, could you please update the features tracking spreadsheet to reflect it?

[phillipao]

Design proposal link is invalid. Looks like it has moved to https://github.com/kubernetes/community/blob/master/keps/sig-api-machinery/0015-dry-run.md.

[justaugustus]

@phillipao -- thanks for pointing that out! I've updated the link in the description. :)

[justaugustus]

@apelisse @jennybuckley --
Any update on docs status for this feature? Are we still planning to land it for 1.12?
At this point, code freeze is upon us, and docs are due on 9/7 (2 days).

cc: @zparnold @jimangel @tfogo

[apelisse]

Still on track, fixing and pushing the doc PR (https://github.com/kubernetes/website/pull/10033), thanks for the ping!

[justaugustus]

Thanks for the update, @apelisse !

[apelisse]

This will fix https://github.com/kubernetes/kubernetes/issues/11488.

[apelisse]

Also fixes https://github.com/kubernetes/kubernetes/issues/62197

[kacole2]

/stage beta

[spiffxp]

@apelisse @deads2k @lavalamp what work needs to be done to move this to beta? are there any issues or PR's we can link to track this?

[spiffxp]

🤦‍♂️ right, I just noticed https://github.com/kubernetes/kubernetes/issues/68514 but since one of those items is Beta/GA I can't tell if this is just "make docs look good" or if there is code that needs to be written for this

[apelisse]

Yeah, the Beta/GA means that it'd be nice if we have it for beta, not mandatory. So it's basically just docs I think.

[tfogo]

Hi @apelisse, could you please open a placeholder PR for the docs for this enhancement against the dev-1.13 branch of k/website and send me a link? If you already have a docs PR open, or if this doesn't require docs in k/website, please let me know.

The deadline for placeholder PRs for the 1.13 release is November 8. So it's important to make a docs PR as soon as possible.

If you have any questions about any of this, I'm happy to help. You can also message me on slack (I'm tfogo there too). 😀

Thanks! ✨

[apelisse]

Thanks @tfogo, there it is: https://github.com/kubernetes/website/pull/10881

[tfogo]

Thanks!

[AishSundar]

@apelisse can we consider this enhancement complete w.r.t for Beta in 1.13? Is documentation the only open PR?

[apelisse]

@AishSundar Correct!

[marpaia]

/milestone v1.14

[marpaia]

/milestone clear

[claurence]

@apelisse Hello - I’m the enhancement’s lead for 1.14 and I’m checking in on this issue to see what work (if any) is being planned for the 1.14 release. Enhancements freeze is Jan 29th and I want to remind that all enhancements must have a KEP - It looks like this is the KEP for this issue - https://github.com/kubernetes/enhancements/blob/master/keps/sig-api-machinery/0015-dry-run.md - let me know if this is not correct

[apelisse]

I've updated the description, we'll see when this moves to GA. That is the KEP, I'll add it to the description, thanks!

[apelisse]

It's already linked in design proposal

[claurence]

@apelisse thanks! Sounds like nothing to track for 1.14. I will remove it from our tracking spreadsheet - lmk if I'm misinterpreting that.

[kacole2]

I'm the Enhancement Lead for 1.15. Is this feature going to be graduating alpha/beta/stable stages in 1.15? Please let me know so it can be tracked properly and added to the spreadsheet.

Once coding begins, please list all relevant k/k PRs in this issue so they can be tracked properly.

[apelisse]

/milestone v1.16

[k8s-ci-robot]

@apelisse: You must be a member of the kubernetes/kubernetes-milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[apelisse]

Nothing planned for this release ;-)

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[rbitia]

Hi @apelisse , I'm the 1.16 Enhancement Shadow. Is this feature going to be graduating alpha/beta/stable stages in 1.16? Please let me know so it can be added to the 1.16 Tracking Spreadsheet. If not's graduating, I will remove it from the milestone and change the tracked label.

Once coding begins or if it already has, please list all relevant k/k PRs in this issue so they can be tracked properly.

Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thank you.

[apelisse]

No need to be tracked for this release, we'll probably go GA for 1.17, thanks!

[rbitia]

okay! thanks for the response

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[apelisse]

/reopen
/lifecycle frozen

[k8s-ci-robot]

@apelisse: Reopened this issue.

In response to this:

/reopen
/lifecycle frozen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[fejta-bot]

Enhancement issues opened in kubernetes/enhancements should never be marked as frozen.
Enhancement Owners can ensure that enhancements stay fresh by consistently updating their states across release cycles.

/remove-lifecycle frozen

[jeremyrickard]

Hey there @apelisse -- 1.17 Enhancements shadow here 👋 . I wanted to check in and see if you think this Enhancement will be graduating to stable in 1.17?

The current release schedule is:

• Monday, September 23 - Release Cycle Begins
• Tuesday, October 15, EOD PST - Enhancements Freeze
• Thursday, November 14, EOD PST - Code Freeze
• Tuesday, November 19 - Docs must be completed and reviewed
• Monday, December 9 - Kubernetes 1.17.0 Released

If you do, I'll add it to the 1.17 tracking sheet (https://bit.ly/k8s117-enhancements). Once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!

[apelisse]

We are planning on promoting this feature to GA in 1.18.

[johnbelamaric]

@apelisse thanks Antoine, I will add it to 1.18 release tracking

[johnbelamaric]

/milestone v1.18

[palnabarun]

Updated the issue description to the correct KEP.

[apelisse]

Looks like the KEP here was missing some section, we just merged #1535 to address the problem. Thanks

[palnabarun]

Thank you @apelisse for addressing this. :)

[jeremyrickard]

This received an exception to enhancement freeze.

[sethmccombs]

Hello, @apelisse - I'm a Docs shadow on the 1.18 release team.

Does this enhancement work planned for 1.18 require any new docs or modifications to existing docs?

If not, can you please update the 1.18 Enhancement Tracker Sheet (or let me know and I'll do so)

If doc updates are required, reminder that the placeholder PRs against k/website (branch dev-1.18) are due by Friday, Feb 28th.

Let me know if you have any questions!

[apelisse]

Thanks for the reminder, we're already actively working on documentation for this feature. @zhouya0

[johnbelamaric]

Hi @apelisse, code freeze is March 5. Please list out/link to any PRs you are working on toward this enhancement, so we can track it in the release team. Thanks!

[apelisse]

That PR is the last piece of work that needs to go in before code-freeze, thanks!

[VineethReddy02]

Hi @apelisse
We are close to the docs placeholder PR deadline against the dev-1.18 branch. Having a placeholder PR in place will definitely help us in tracking enhancements much better.
Could you please share the link to docs placeholder PR?

Thanks! :)

[apelisse]

I've created the empty PR: https://github.com/kubernetes/website/pull/19287

[apelisse]

https://github.com/kubernetes/enhancements/pull/1628