Enhancements: Defaulting of Custom Resources

[nikhita]

Feature Description

• One-line feature description (can be used as a release note): Support for defaulting of Custom Resources.
• Primary contact (assignee): @sttts
• Responsible SIGs: SIG API Machinery
• KEP:
  
  
  
  • Pruning - https://github.com/kubernetes/enhancements/pull/709
  
  
  • 20180731-crd-pruning
  
  
  • Defaulting - https://github.com/kubernetes/enhancements/pull/1006
  
  
  • 20190426-crd-defaulting
  
  
• Link to e2e and/or unit tests:
• Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
  
  
  
  • @deads2k
  
  
  • @liggitt
  
  
  • @mbohlool
  
  
  • @lavalamp
  
  
• Approver (likely from SIG/area to which feature belongs):
  
  
  
  • @deads2k
  
  
  • @lavalamp
  
  
• Feature target (which target equals to which milestone):
  
  
  
  • Alpha release target (v1.15)
  
  
  • Beta release target (v1.16)
  
  
  • Stable release target (v1.17)
  
  

[nikhita]

@justaugustus @idvoretskyi this is for 1.12.

/assign @sttts

original CRD feature: https://github.com/kubernetes/features/issues/95 (this is a sub-feature)
PR open: https://github.com/kubernetes/kubernetes/pull/63604 (defaulting) and https://github.com/kubernetes/kubernetes/pull/64558 (pruning)

/sig api-machinery
/kind feature
/stage alpha

[mbohlool]

Is there any design doc or discussion on this feature that I can read before diving into the code?

[nikhita]

Is there any design doc

It wasn't written originally but we plan to write a small design doc for this :+1:

discussion on this feature

This was discussed in the sig api-machinery 31 January 2018 meeting: https://docs.google.com/document/d/1x9RNaaysyO0gXHIr1y50QFbiL1x8OWnk2v3XnrdkT5Y/edit#heading=h.l54g1ses43w1 (to those who want to read this, you might need to join the sig-api-machinery google group).

Defaulting was discussed in: https://github.com/kubernetes/kubernetes/pull/55885, https://github.com/kubernetes/kubernetes/pull/63604, https://github.com/go-openapi/validate/pull/81

Pruning: https://github.com/kubernetes/kubernetes/issues/59151, https://github.com/kubernetes/kubernetes/pull/64558

[justaugustus]

@nikhita --

It looks like this feature is currently in the Kubernetes 1.12 Milestone.

If that is still accurate, please ensure that this issue is up-to-date with ALL of the following information:

• One-line feature description (can be used as a release note):
• Primary contact (assignee):
• Responsible SIGs:
• Design proposal link (community repo):
• Link to e2e and/or unit tests:
• Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
• Approver (likely from SIG/area to which feature belongs):
• Feature target (which target equals to which milestone):
  
  
  
  • Alpha release target (x.y)
  
  
  • Beta release target (x.y)
  
  
  • Stable release target (x.y)
  
  

Set the following:

• Description
• Assignee(s)
• Labels:
  
  
  
  • stage/{alpha,beta,stable}
  
  
  • sig/*
  
  
  • kind/feature
  
  

Once this feature is appropriately updated, please explicitly ping @justaugustus, @kacole2, @robertsandoval, @rajendar38 to note that it is ready to be included in the Features Tracking Spreadsheet for Kubernetes 1.12.

---

Please note that the Features Freeze is July 31st, after which any incomplete Feature issues will require an Exception request to be accepted into the milestone.

In addition, please be aware of the following relevant deadlines:

• Docs deadline (open placeholder PRs): 8/21
• Test case freeze: 8/28

Please make sure all PRs for features have relevant release notes included as well.

Happy shipping!

[justaugustus]

@sttts -- This has been added to the 1.12 Tracking sheet. Apologies for missing it before!

[zparnold]

Hey there! @nikhita I'm the wrangler for the Docs this release. Is there any chance I could have you open up a docs PR against the release-1.12 branch as a placeholder? That gives us more confidence in the feature shipping in this release and gives me something to work with when we start doing reviews/edits. Thanks! If this feature does not require docs, could you please update the features tracking spreadsheet to reflect it?

[jimangel]

@sttts Bump for docs ☝️

[justaugustus]

@sttts --
Any update on docs status for this feature? Are we still planning to land it for 1.12?
At this point, code freeze is upon us, and docs are due on 9/7 (2 days).
If we don't here anything back regarding this feature ASAP, we'll need to remove it from the milestone.

cc: @zparnold @jimangel @tfogo

[AishSundar]

@sttts is this feature still on track to go to Alpha in 1.13? could you let us know what work is pending for this in k/k eg: list of PRs or issues, status of docs etc. do we feel confident this will hit the deadlines for 1.13 (code freeze 11/15)

[sttts]

As this lacks concensus, it won't be in 1.13. Updated the milestone.

[AishSundar]

@sttts thanks for making an early decision in favor of release stability

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[claurence]

@sttts Hello - I’m the enhancement’s lead for 1.14 and I’m checking in on this issue to see what work (if any) is being planned for the 1.14 release. Enhancements freeze is Jan 29th and I want to remind that all enhancements must have a KEP

[claurence]

@sttts since there is no KEP for this issue yet we will be removing it from the 1.14 milestone. To have it added back in please file an exception - information on the exception process can be found here: https://github.com/kubernetes/sig-release/blob/master/releases/EXCEPTIONS.md

[liggitt]

KEP is in progress at https://github.com/kubernetes/enhancements/pull/709 but is not targeted at 1.14

[kacole2]

@sttts @liggitt anything targeted for 1.15 here?

[sttts]

KEP for the defaulting part is separate: https://github.com/kubernetes/enhancements/pull/1006

[nikhita]

/milestone v1.15

[kacole2]

@nikhita @sttts can you please expand why this needs to be included? From what I can tell there is a KEP still waiting to be merged and this is past the Freeze. Can this get merged today?

[liggitt]

detailed in https://groups.google.com/d/msg/kubernetes-sig-release/uqVu7DRKv7w/iMtiaN2BDAAJ

yes, KEP merge is targeted for today

[kacole2]

Thanks will track for now and come back later to check on the merge. i appreciate the quick response @liggitt

[simplytunde]

Hey @sttts Just a friendly reminder we're looking for a PR against k/website (branch dev-1.15) due by Thursday, May 30. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions!

[simplytunde]

@sttts The placeholder PR against k8s.io dev-1.15 is due Thursday May 30th.

[kacole2]

Hi @sttts @liggitt . Code Freeze is Thursday, May 30th 2019 @ EOD PST. All enhancements going into the release must be code-complete, including tests, and have docs PRs open.

Please list all current k/k PRs so they can be tracked going into freeze. If the PRs aren't merged by freeze, this feature will slip for the 1.15 release cycle. Only release-blocking issues and PRs will be allowed in the milestone.

If you know this will slip, please reply back and let us know. Thanks!

[sttts]

Docs PR for 1.15: https://github.com/kubernetes/website/pull/14583

@nikhita can you update the issue description?

[kacole2]

Hi @sttts @nikhita @liggitt , today is code freeze for the 1.15 release cycle. I do not see a reply for any k/k PRs to track for this merge. It's now being marked as At Risk in the 1.15 Enhancement Tracking Sheet. If there is no response, or you respond with PRs to track and they are not merged by EOD PST, this will be dropped from the 1.15 Milestone. After this point, only release-blocking issues and PRs will be allowed in the milestone with an exception.

[liggitt]

defaulting and pruning are already merged, there are no outstanding PRs, and the docs PR is open.

[liggitt]

/milestone v1.16
/stage stable

[mariantalla]

Hi @nikhita @sttts -- I'm an Enhancements shadow for 1.16. From looking at labels it seems that the plan is for this feature to go stable in 1.16. I'll go ahead and add it to the 1.16 Tracking Spreadsheet.

If I've got this wrong and it's not graduating, please let me know I will remove it from the milestone and change the tracked label.

Are there any remaining relevant k/k PRs? If so, please list them in this issue so they can be tracked properly.

1.16 milestone dates: Enhancement Freeze 7/30 and Code Freeze 8/29.

Thanks!

[simplytunde]

Hey, @nikhita @sttts I'm the v1.16 docs release lead.

Does this enhancement (or the work planned for v1.16) require any new docs (or modifications)?

Just a friendly reminder we're looking for a PR against k/website (branch dev-1.16) due by Friday,August 23rd. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions!

[sttts]

@simplytunde the placeholder PR https://github.com/kubernetes/website/pull/15983

[kacole2]

@sttts @liggitt assuming there are no more PRs to be merged here and we're ready to go Stable?

[liggitt]

pruning is going to stable in 1.16 and has no remaining PRs.

defaulting is going to beta in 1.16, and has only the feature gate promotion PR left to merge https://github.com/kubernetes/kubernetes/pull/81872

[kacole2]

Thanks @liggitt i guess we should have created two separate issues but we are pretty far along now so let's just keep running with it.

[liggitt]

docs ready for review in https://github.com/kubernetes/website/pull/15982

[liggitt]

Pruning released as stable in v1.16.0

Defaulting targeted for stable in v1.17.0

[mrbobbytables]

@liggitt @sttts @nikhita -- Enhancement lead for 1.17 here. Looks like you're ahead of the game :)

The current release schedule is:

• Monday, September 23 - Release Cycle Begins
• Tuesday, October 15, EOD PST - Enhancements Freeze
• Thursday, November 14, EOD PST - Code Freeze
• Tuesday, November 19 - Docs must be completed and reviewed
• Monday, December 9 - Kubernetes 1.17.0 Released

Once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!

[VineethReddy02]

@liggitt @sttts @nikhita

I'm one of the v1.17 docs shadows.
Does this enhancement (or the work planned for v1.17) require any new docs (or modifications to existing docs)? If not, can you please update the 1.17 Enhancement Tracker Sheet (or let me know and I’ll do so)

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.17) due by Friday, Nov 8th, it can just be a placeholder PR at this time. Let me know if you have any questions!

Thanks!

[sttts]

@VineethReddy02 it only needs the small changes replacing "beta" with GA.

[daminisatya]

Awesome! @sttts We still need a placeholder PR before Nov 8th.

[mrbobbytables]

Hey there @sttts 1.17 Enhancement lead here. 👋 Code Freeze is right around the corner (November 14th).

It looks like the only outstanding PR is https://github.com/kubernetes/kubernetes/pull/84713. Do you think this will make in? Only release-blocking issues and PRs will be allowed in the milestone after the freeze 😬

Thanks!

[sttts]

It looks like the only outstanding PR is kubernetes/kubernetes#84713. Do you think this will make in?

I hope so :)

[sttts]

@VineethReddy02 here is the docs PR https://github.com/kubernetes/website/pull/17450

[jeremyrickard]

Hey @sttts , Happy New Year! 1.18 Enhancements lead here 👋

I'm going though and doing some cleanup for the milestone and checking on things that graduated in the last release. Since this graduated to GA in 1.17, I'd like to close this issue out but the defaulting KEP is still marked as implementable (the pruning KEPis as well). Could you submit a PR to update the KEP to implemented and then we can close this issue out?

Thanks so much!

[sttts]

@jeremyrickard https://github.com/kubernetes/enhancements/pull/1436

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[palnabarun]

/remove-lifecycle stale

[palnabarun]

Thank you @liggitt @sttts @nikhita for working on this enhancement. :+1:

I'm going ahead and closing this since the corresponding KEPs are implemented.

/close

[k8s-ci-robot]

@palnabarun: Closing this issue.

In response to this:

Thank you @liggitt @sttts @nikhita for working on this enhancement. :+1:

I'm going ahead and closing this since the corresponding KEPs are implemented.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.