Enhancements: Add resizing support to CSI volumes

[gnufied]

Enhancement Description

• Add resizing support for CSI volumes:
• Kubernetes Enhancement Proposal PR: #780
• Kubernetes Enhancement Proposal: 20190129-csi-volume-resizing.md
• Primary contact (assignee): @gnufied
• Responsible SIGs: sig-storage
• Enhancement target (which target equals to which milestone):
  
  
  
  • Alpha release target (x.y) 1.12
  
  
  • Beta release target (x.y) 1.16
  
  
  • Stable release target (x.y) 1.xx
  
  

[gnufied]

/assign

[gnufied]

/sig storage

[justaugustus]

/kind feature

[gnufied]

We should move this to 1.12. We still have CSI spec change under discussion.

[justaugustus]

@gnufied @kubernetes/sig-storage-feature-requests --

This feature was removed from the previous milestone, so we'd like to check in and see if there are any plans for this in Kubernetes 1.12.

If so, please ensure that this issue is up-to-date with ALL of the following information:

• One-line feature description (can be used as a release note):
• Primary contact (assignee):
• Responsible SIGs:
• Design proposal link (community repo):
• Link to e2e and/or unit tests:
• Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
• Approver (likely from SIG/area to which feature belongs):
• Feature target (which target equals to which milestone):
  
  
  
  • Alpha release target (x.y)
  
  
  • Beta release target (x.y)
  
  
  • Stable release target (x.y)
  
  

Set the following:

• Description
• Assignee(s)
• Labels:
  
  
  
  • stage/{alpha,beta,stable}
  
  
  • sig/*
  
  
  • kind/feature
  
  

Please note that the Features Freeze is July 31st, after which any incomplete Feature issues will require an Exception request to be accepted into the milestone.

In addition, please be aware of the following relevant deadlines:

• Docs deadline (open placeholder PRs): 8/21
• Test case freeze: 8/28

Please make sure all PRs for features have relevant release notes included as well.

Happy shipping!

/cc @justaugustus @kacole2 @robertsandoval @rajendar38

[gnufied]

This is still on target for 1.12. We are working on various aspects of code and specs to meet that goal.

[justaugustus]

Thanks for the update! This has been added to the 1.12 Tracking sheet.

[zparnold]

Hey there! @gnufied I'm the wrangler for the Docs this release. Is there any chance I could have you open up a docs PR against the release-1.12 branch as a placeholder? That gives us more confidence in the feature shipping in this release and gives me something to work with when we start doing reviews/edits. Thanks! If this feature does not require docs, could you please update the features tracking spreadsheet to reflect it?

[justaugustus]

@gnufied --
Any update on docs status for this feature? Are we still planning to land it for 1.12?
At this point, code freeze is upon us, and docs are overdue.
If we don't here anything back regarding this feature ASAP, we'll need to remove it from the milestone.

cc: @zparnold @jimangel @tfogo

[gnufied]

We will have to move this to next milestone.

[justaugustus]

Got it. Thanks for the update!

[kacole2]

Hi @gnufied
This enhancement has been tracked before, so we'd like to check in and see if there are any plans for this to graduate stages in Kubernetes 1.13. This release is targeted to be more ‘stable’ and will have an aggressive timeline. Please only include this enhancement if there is a high level of confidence it will meet the following deadlines:
Docs (open placeholder PRs): 11/8
Code Slush: 11/9
Code Freeze Begins: 11/15
Docs Complete and Reviewed: 11/27

Please take a moment to update the milestones on your original post for future tracking and ping @kacole2 if it needs to be included in the 1.13 Enhancements Tracking Sheet

We are also now encouraging that every new enhancement aligns with a KEP. If a KEP has been created, please link to it in the original post. Please take the opportunity to develop a KEP.

Thanks!

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[msau42]

/remove-lifecycle stale

[claurence]

@gnufied Hello - I’m the enhancement’s lead for 1.14 and I’m checking in on this issue to see what work (if any) is being planned for the 1.14 release. Enhancements freeze is Jan 29th and I want to remind that all enhancements must have a KEP

[gnufied]

@claurence this feature is on track for 1.14 yes!

[claurence]

Thanks @gnufied based on the label is it still alpha or is it graduating in 1.14. Also are there any associated open PRs for this issue or have they all been merged?

[claurence]

@gnufied checking in on this feature? Is this planning to graduate or is it planning to be alpha in 1.14? The label on it indicates alpha. Additionally is there a KEP for this issue?

[gnufied]

This feature will release as an alpha feature in 1.14. As such we weren't planning for a KEP because it does not require a major redesign in existing internals. It builds on feature that already exists in k8s.

[claurence]

@gnufied I think we'd still want a KEP - is there a testing plan for this enhancement? graduation criteria?

[gnufied]

@claurence added a KEP for csi volume resizing.

[claurence]

@gnufied Thanks - since the KEP for this issue isn't merged yet we will be removing it from the 1.14 milestone. To have it added back in please file an exception - information on the exception process can be found here: https://github.com/kubernetes/sig-release/blob/master/releases/EXCEPTIONS.md

[claurence]

Adding back to 1.14 milestone. Thanks for getting the KEP merged

[cody-clark]

Hi @gnufied! I'm one of the v1.14 docs release shadows.

Does this enhancement require any new docs (or modifications)?

Just a friendly reminder we're looking for a PR against k/website (branch dev-1.14) due by Friday, March 1. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions!

[lachie83]

Hello @gnufied, 1.14 enhancement shadow here. Code Freeze is March 7th and all PRs must be merged by then to your issue to make the 1.14 release. What open K/K PRs do you still have that need to merge? Thanks

[gnufied]

@lachie83 @cody-clark The feature is on track. Most of work is externally done in https://github.com/kubernetes-csi/external-resizer/ , however I will have a PR for main k/k repo as well.

I will open docs PR by docs window.

[gnufied]

Docs PR - https://github.com/kubernetes/website/pull/12928

[gnufied]

Code PR for main k/k repo - https://github.com/kubernetes/kubernetes/pull/74863

[jimangel]

Hey @gnufied, thanks for the docs ref. Would you mind rebasing it off of the dev-1.14 branch instead of master? Thanks!

[kacole2]

@gnufied did this go to stable in 1.14? If so, let's close out this issue. If not, any work planned for 1.15?

/milestone clear

[msau42]

This is alpha in 1.14, and is planned to move to beta in 1.15

[kacole2]

/milestone v1.15
/stage beta

[simplytunde]

Hey @gnufied . We need a placeholder PR checked in against dev-1.15 branch. This is due by Thursday, May 30. Thanks!

[simplytunde]

@gnufied The placeholder PR is due Thursday May 30th.

[kacole2]

Hi @gnufied @msau42 . Code Freeze is Thursday, May 30th 2019 @ EOD PST. All enhancements going into the release must be code-complete, including tests, and have docs PRs open.

Please list all current k/k PRs so they can be tracked going into freeze. If the PRs aren't merged by freeze, this feature will slip for the 1.15 release cycle. Only release-blocking issues and PRs will be allowed in the milestone.

For this issues I'm seeing https://github.com/kubernetes/kubernetes/pull/74863 is merged, https://github.com/kubernetes-sigs/azurefile-csi-driver/issues/43 is open and https://github.com/kubernetes/kubernetes/pull/67608 is open. If there are some missing please let me know what needs to be merged by Thursday.

If you know this will slip, please reply back and let us know. Thanks!

[kacole2]

Hi @gnufied @msau42, today is code freeze for the 1.15 release cycle. The k/k PR https://github.com/kubernetes/kubernetes/pull/67608 has not yet been merged. It's now being marked as At Risk in the 1.15 Enhancement Tracking Sheet. Is there a high confidence this will be merged by EOD PST today? After this point, only release-blocking issues and PRs will be allowed in the milestone with an exception.

[gnufied]

This feature is not moving to beta in 1.15. It remains in alpha. We are making some additional changes but features themselves won't change.

[gnufied]

@kacole2 also https://github.com/kubernetes/kubernetes/pull/77755 is replacement PR for https://github.com/kubernetes/kubernetes/pull/67608

[kacole2]

/milestone clear
/stage alpha

[gnufied]

We are targeting this feature to beta in 1.16.

[kacole2]

/milestone v1.16
/stage beta

[simplytunde]

Hey, @gnufied I'm the v1.16 docs release lead.

Does this enhancement (or the work planned for v1.16) require any new docs (or modifications)?

Just a friendly reminder we're looking for a PR against k/website (branch dev-1.16) due by Friday,August 23rd. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions!

[gnufied]

I will have docs PR by eod today. thank you.

[simplytunde]

@gnufied Please at me once the Doc is out and I will be tracking also.

[gnufied]

placeholder PR is here - https://github.com/kubernetes/website/pull/16043

[simplytunde]

Thanks @gnufied

[kacole2]

@gnufied friendly reminder that code freeze for 1.16 is on Thursday 8/29. Are there any outstanding k/k PRs besides https://github.com/kubernetes/kubernetes/pull/81877 that still need to be merged for this to go Beta?

[gnufied]

yes that is the main PR. Although we are also tracking https://github.com/kubernetes/kubernetes/pull/81467 for 1.16 so as we could run the e2e tests against more CSI drivers

[gnufied]

Correction - we are trying to get https://github.com/kubernetes/kubernetes/pull/81467 as the main PR because it will improve e2e coverage, in addition to enabling the CSI volume expansion feature gate.

[mrbobbytables]

Hey there @gnufied -- 1.17 Enhancements lead here. I wanted to check in and see if you think this Enhancement will be graduating to alpha/beta/stable in 1.17?

The current release schedule is:

• Monday, September 23 - Release Cycle Begins
• Tuesday, October 15, EOD PST - Enhancements Freeze
• Thursday, November 14, EOD PST - Code Freeze
• Tuesday, November 19 - Docs must be completed and reviewed
• Monday, December 9 - Kubernetes 1.17.0 Released

If you do, please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

/milestone clear

[gnufied]

We will most likely keep this feature in beta in 1.17 and focus on making it more stable.

[mrbobbytables]

Great! Thanks for the quick response! 👍

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[Bessonov]

/remove-lifecycle stale

[palnabarun]

Hey there @gnufied -- 1.18 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating to stable in 1.18 or having a major change in its current level?

The current release schedule is:

• Monday, January 6th - Release Cycle Begins
• Tuesday, January 28th EOD PST - Enhancements Freeze
• Thursday, March 5th, EOD PST - Code Freeze
• Monday, March 16th - Docs must be completed and reviewed
• Tuesday, March 24th - Kubernetes 1.18.0 Released

If you would like to include this enhancement, once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

We'll be tracking enhancements here: http://bit.ly/k8s-1-18-enhancements

Thanks! :)

[palnabarun]

@gnufied Just a friendly reminder, we are just 7 days away from the Enhancement Freeze (Tuesday, January 28th).

[palnabarun]

@gnufied Just a friendly reminder, we are just 2 days away from the Enhancement Freeze (3 PM Pacific Time, Tuesday, January 28th).

[palnabarun]

Unfortunately, the deadline for the 1.18 Enhancement freeze has passed. For now, this is being removed from the milestone. If there is a need to get this in, please file an enhancement exception.

[bratao]

@palnabarun any chance of this making to the next release? This is an inevitable step in many workflows.

[msau42]

@bratao this is available in beta since 1.16. Are you asking about GA? The current plan for 1.19 is to keep the feature in beta and continue fixing bugs and corner cases.

[bratao]

@msau42 oh I somehow missed it. Thanks!!!

[msedzins]

Hey there @gnufied -- 1.19 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating in 1.19?

In order to have this part of the release:

1. The KEP PR must be merged in an implementable state
2. The KEP must have test plans
3. The KEP must have graduation criteria.

The current release schedule is:

• Monday, April 13: Week 1 - Release cycle begins
• Tuesday, May 19: Week 6 - Enhancements Freeze
• Thursday, June 25: Week 11 - Code Freeze
• Thursday, July 9: Week 14 - Docs must be completed and reviewed
• Tuesday, August 4: Week 17 - Kubernetes v1.19.0 released

If you do, I'll add it to the 1.19 tracking sheet (http://bit.ly/k8s-1-19-enhancements). Once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!

[msedzins]

Hi @gnufied , kind reminder about my question above.

Thx!

[msedzins]

Hi @gnufied , kind reminder about my question above.

Thx!

[gnufied]

We are not graduating this feature to GA. Having said that, we are working to transition this feature to GA while fixing open issues and addressing pending concerns.

[msedzins]

Thank you @gnufied for letting me know.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[gnufied]

/remove-lifecycle stale

[kikisdeliveryservice]

Hi @gnufied

Enhancements Lead here. Any plans to graduate this in 1.20?

Thanks,
Kirsten

[gnufied]

This will remain in beta in 1.20 we are working on issues such as recovery from resize failure etc before this can be moved to GA,