Enhancements: Topology Aware Volume Scheduling

Created on 20 Oct 2017  Â·  28Comments  Â·  Source: kubernetes/enhancements

Feature Description

  • One-line feature description (can be used as a release note): Make the scheduler aware of a Pod's volume's topology constraints, such as zone or node.
  • Primary contact (assignee): @msau42
  • Responsible SIGs: @kubernetes/sig-storage-feature-requests @kubernetes/sig-scheduling-feature-requests
  • Design proposal link (community repo):kubernetes/community#1054, kubernetes/community#1168
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:

    • @jsafrane

    • @bsalamat

  • Approver (likely from SIG/area to which feature belongs):

    • @thockin

  • Feature target (which target equals to which milestone):

    • Alpha release target (x.y): 1.9

    • Beta release target (x.y): 1.10

    • Stable release target (x.y): 1.13

/assign

kinfeature sischeduling sistorage stagstable trackeno

Most helpful comment

/remove-lifecycle-stale
/lifecycle frozen

I'm hoping to target beta in 1.10

All 28 comments

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

/remove-lifecycle-stale
/lifecycle frozen

I'm hoping to target beta in 1.10

@msau42 1.10 - beta, right?

Yes, at least I will try to.

1.10 Beta PR has been merged: kubernetes/kubernetes#59391

1.11 design for dynamic provisioning is here: kubernetes/community#1857

@msau42 In my use case, the statefulset does not automatically schedule pods on the same node as the pv(local storage). To overcome this I have written a custom scheduler that schedules the pod on the node which has it's pv. This also works in the case where the pod goes down and needs to be brought up on the exact node that has it's pv.
Will the changes planned for 1.11 eliminate the need for a custom scheduler or is there a better way to do this?

@mightwork the current feature should already be scheduling your pod to the correct node. Can you open an issue with the details of your PV and ping me?

@msau42
Any plans for this in 1.11?

If so, can you please ensure the feature is up-to-date with the appropriate:

  • Description
  • Milestone
  • Assignee(s)
  • Labels:

    • stage/{alpha,beta,stable}

    • sig/*

    • kind/feature

cc @idvoretskyi

Plan is to remain beta in 1.11.

https://github.com/kubernetes/features/issues/561 is tracking the dynamic provisioning work

Thanks for the update, @msau42!

This feature current has no milestone, so we'd like to check in and see if there are any plans for this in Kubernetes 1.12.

If so, please ensure that this issue is up-to-date with ALL of the following information:

  • One-line feature description (can be used as a release note):
  • Primary contact (assignee):
  • Responsible SIGs:
  • Design proposal link (community repo):
  • Link to e2e and/or unit tests:
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
  • Approver (likely from SIG/area to which feature belongs):
  • Feature target (which target equals to which milestone):

    • Alpha release target (x.y)

    • Beta release target (x.y)

    • Stable release target (x.y)

Set the following:

  • Description
  • Assignee(s)
  • Labels:

    • stage/{alpha,beta,stable}

    • sig/*

    • kind/feature

Once this feature is appropriately updated, please explicitly ping @justaugustus, @kacole2, @robertsandoval, @rajendar38 to note that it is ready to be included in the Features Tracking Spreadsheet for Kubernetes 1.12.


Please note that Features Freeze is tomorrow, July 31st, after which any incomplete Feature issues will require an Exception request to be accepted into the milestone.

In addition, please be aware of the following relevant deadlines:

  • Docs deadline (open placeholder PRs): 8/21
  • Test case freeze: 8/28

Please make sure all PRs for features have relevant release notes included as well.

Happy shipping!

P.S. This was sent via automation

Plan for 1.12 is to remain in beta. There are some bugs that need to be fixed before going GA

Hi @msau42
This enhancement has been tracked before, so we'd like to check in and see if there are any plans for this to graduate stages in Kubernetes 1.13. This release is targeted to be more ‘stable’ and will have an aggressive timeline. Please only include this enhancement if there is a high level of confidence it will meet the following deadlines:
Docs (open placeholder PRs): 11/8
Code Slush: 11/9
Code Freeze Begins: 11/15
Docs Complete and Reviewed: 11/27

Please take a moment to update the milestones on your original post for future tracking and ping @kacole2 if it needs to be included in the 1.13 Enhancements Tracking Sheet

Thanks!

Plan for 1.13 is to go GA

/milestone v1.13

@msau what work if left in k/k for this feature to go to GA in 1.13? Is there a list of pending PRs (code, tests and docs) that we can track on our end?

/stage stable

@kacole2 I updated the stage to be stable as per Michelle's comment here

Remaining tasks:

Hi @msau42, I'm Naomi and working on docs for the 1.13 release. Could you open up a docs PR against the dev-1.13 branch as a placeholder for the needed docs updates?

Hi @msau42 - I'm Enhancements Shadow for 1.13. Could you please update the release team with the likelihood of this enhancement making the 1.13 release? When we don't see any updates in a few days, we would appreciate an update.

Code slush begins on 11/9 and code freeze is 11/15.

Thank you!

Yes, this is on track to meet code freeze.

e2e PR is close to being merged:
https://github.com/kubernetes/kubernetes/pull/70362

I will open up the feature gate PR this week.

@msau42 is the e2e test PR the only pending PR for this enhancement? I added milestone and priority to the PR so it can merge in Slush.

Is there a feature gate PR open?

I updated the checklist above. Just docs are remaining

@msau42 Hi I'm the enhancements lead for 1.14 - It looks like this enhancement graduated to stable - is this issue still open? Is there work needed for the 1.14 release?

I think we are done with feature tracking. There are some cleanup items that I have already opened issues for.
/close

@msau42: Closing this issue.

In response to this:

I think we are done with feature tracking. There are some cleanup items that I have already opened issues for.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Actually, this is also a pain with statefulsets running on top of Amazon EKS Cluster.
Hopefully, the fix comes from kubernetes

Was this page helpful?
0 / 5 - 0 ratings

Related issues

justinsb picture justinsb  Â·  11Comments

justaugustus picture justaugustus  Â·  3Comments

saschagrunert picture saschagrunert  Â·  6Comments

euank picture euank  Â·  13Comments

prameshj picture prameshj  Â·  9Comments