Enderio: Advanced item filter still bugged in Refined Storage conduits

[calloatti]

Issue Description:

When using an advanced item filter in a Refined Storage conduit, the "Ignore NBT", "Ignore Metadata" and "Ignore Damage" flags are not used. Only the exact item set in the filter gets exported.

What happens:

The Advanced Item Filter does not work properly.

What you expected to happen:

The Advanced Item Filter to work properly.

Steps to reproduce:

Refined Storage test setup:

RESULT:

Chests and Item Conduits with the exact same filter and the exact same items:

RESULT:

---

Affected Versions (Do not use "latest"):

• EnderIO: EnderIO-1.12.2-5.0.40
• EnderCore: EnderCore-1.12.2-0.5.45
• Minecraft: 1.12.2
• Forge: 14.23.5.2808
• SpongeForge? no
• Optifine? no
• Single Player and/or Server? : Single Player

Java: Eclipse OpenJ9 VM, version 1.8.0_202, running on Windows 10:amd64:10.0

Your most recent log file where the issue was present:

https://pastebin.pl/view/8da4f348

[HenryLoenwind]

RS still doesn't support those.

[calloatti]

If I use a Refined Storage Exporter instead of an Ender IO RS conduit/filter combo, the Refined Storage exporter can ignore NBT data and ignore damage, so I think Refined Storage does support those.

The thing is, having to use a Refined Storage Exporter at the end of an Ender IO RS conduit line kind of defeats the purpose of having RS conduits in the first place...

This works fine, but it looks ugly and cannot be covered with a facade:

[calloatti]

Related:

https://github.com/SleepyTrousers/EnderIO/issues/4904

https://github.com/SleepyTrousers/EnderIO/issues/4887

This has not been fixed despite what @EpicSquid says here: https://github.com/SleepyTrousers/EnderIO/issues/4887#issuecomment-426650022

[HenryLoenwind]

@EpicSquid your code, I can only relay potentially outdated infos

[calloatti]

Maybe reopen? Thank you for taking the time to review this. Any other testing needed/required I am available to help, as I have done in the past.

[HenryLoenwind]

Oops, I thought I re-opened it when I assigned Epic...

[HenryLoenwind]

Please note that export filtering is severely limited by RS's filtering capabilities. It will not export a wrong item, but it may get stuck when RS wants to export a wrong item and our filter stops it. As long as RS doesn't decide to export another item, nothing will happen.