Ember-power-select: Ember 3.17 : error in animateOut

[oliverlj]

Hello,
When I update to 3.17. i got a parentElement undefined in

    animateOut(dropdownElement) {
      if (!this.animationEnabled) return;
      let parentElement = this.renderInPlace ? dropdownElement.parentElement.parentElement : dropdownElement.parentElement;
      let clone = dropdownElement.cloneNode(true);
      clone.id = `${clone.id}--clone`;
      clone.classList.remove(...this.transitioningInClass.split(' '));
      clone.classList.add(...this.transitioningOutClass.split(' '));
      parentElement.appendChild(clone);
      this.set('animationClass', this.transitioningInClass);
      waitForAnimations(clone, function () {
        parentElement.removeChild(clone);
      });
    }

I use ember-bootstrap-power-select so i don't know yet which one is responsible

[oliverlj]

settings animationEnabled to false does nothing as

    // CPs
    get animationEnabled() {
      if (this._animationEnabled) {
        return this._animationEnabled;
      }

      let config = Ember.getOwner(this).resolveRegistration('config:environment');
      return config.environment !== 'test';
    }

this return true

[it-delta]

Hello!
Yes, I see the problem too... Ember 3.16.0

[oliverlj]

no error in the test because animationEnabled is false for test environment

[sinankeskin]

Same here with v3.17

[aonawale]

Same here ember v3.17

[rwwagner90]

Same here with 3.17 as well

[williamweckl]

Same here with 3.17.

[williamweckl]

no error in the test because animationEnabled is false for test environment

shouldn't be enabled in tests too? This error was silently deployed in production even with a high test coverage :cry:

[markusm7]

Same here with Ember 3.17 and EPS 3.0.6
I see it got tackled in some way in EBD 3.

Any plans to fix this in EPS 3.x.x (or EBD 2.x.x)?

[leondmello]

I got rid of these errors by updating to https://github.com/cibernox/ember-power-select/releases/tag/v4.0.0-beta.6

[markusm7]

@leondmello yeah as i said it got tackled in ember basic dropdown 3, which is the one EPS 4-beta is using. The problem is im using different addons which rely on EBD 2.

[leondmello]

@leondmello yeah as i said it got tackled in ember basic dropdown 3, which is the one EPS 4-beta is using. The problem is im using different addons which rely on EBD 2.

Yes, I wrote the suggestion for all the other people for whom it might get fixed by updating to the BETA.

[cibernox]

I plan to make the beta final today, after I merge a couple PRs. Hopefully that will invite people using ember octane to update

[markusm7]

updated all the dependencies today already to ebd 3 and eps 4-beta. glad i moved partially already to octane, seems to continue working like before!

[cibernox]

I released 4.0.0 final, so everyone having problems in the very latest version of Ember should be able to update and have them fixed. There is barely any breaking changes, the component uses octane idioms, glimmer components, typescript, @tracked and all that jazz.

[cibernox]

I think this can be closed now, this is fixed in 4.0.0