Ember.js: [3.20] Deprecation warnings when using @glimmer/component

Created on 16 Jul 2020 · 5Comments · Source: emberjs/ember.js

The current version of @glimmer/component (1.0.0) in EmberGlimmerComponentManager.destroyComponent calls setSourceDestroying which has been deprecated since Ember 3.20. So using Glimmer components in Ember 3.20 leads to a deprecation warning.

cc @rwjblue, @pzuraq

Bug

Source

boris-petrov

👍2

Most helpful comment

Thanks for reporting this (will help others to find it). The fix will be over in @glimmer/component (in glimmerjs/glimmer.js monorepo). I'm hoping to have a PR and release out in a couple hours.

rwjblue on 16 Jul 2020

🎉5

All 5 comments

Thanks for reporting this (will help others to find it). The fix will be over in @glimmer/component (in glimmerjs/glimmer.js monorepo). I'm hoping to have a PR and release out in a couple hours.

rwjblue on 16 Jul 2020

🎉5

@rwjblue I wanted to make an attempt at the PR. I have no idea if anything else is needed and I did the ternary expression to support ember versions that don't have the new meta API.

https://github.com/glimmerjs/glimmer.js/pull/292

jordpo on 24 Jul 2020

Sorry for the delays here y'all, finally got https://github.com/glimmerjs/glimmer.js/pull/293 pushed up with the changes that I think are needed.

rwjblue on 27 Jul 2020

👍4

Sorry for the delays here y'all, finally got glimmerjs/glimmer.js#293 pushed up with the changes that I think are needed.

Looks like that PR is still awaiting merge. Is there a way this be used/tested right now or should I be waiting for another release (or perhaps the closure of this issue)?