Ember.js: [CLEANUP] remove enabled feature flags on release

Created on 29 May 2019  路  9Comments  路  Source: emberjs/ember.js

Cleanup Good for New Contributors Help Wanted

Most helpful comment

@chancancode seems it could be closed?

All 9 comments

@chancancode can i have a crack at this?

Hey, can i help to fix this issue. I want to contribute in this project. @chancancode

@mul53 @rajankumar549 you don't need permission, just go ahead and open PR. Preferably one feature flag at a time and maybe add a note here on what you are working on so others can pick something else.

@chancancode seems it could be closed?

I am a beginner, and id like to work on a new issue here

@kanavpruthi the specific set of enabled features to remove has changed since this was opened, but there are now new ones that needed to be cleaned up https://github.com/emberjs/ember.js/blob/master/packages/@ember/canary-features/index.ts

Should all of the features in /packages/@ember/canary-features/index.ts have their respective feature flags removed?

@Alpine-lines any flag that has been set to true, and has been released in a minor version of Ember, should be removed. Currently, these ones: https://github.com/emberjs/ember.js/blob/master/packages/@ember/canary-features/index.ts#L19-L23

The best way to approach this is with one PR per feature flag, to make it easier to review quickly

Was this page helpful?
0 / 5 - 0 ratings