Ember.js: [Pls send halp!] Cleaning up the test output

[chancancode]

♻️ ♻️ ♻️ Please consider the environment before printing this Github issue. ♻️ ♻️ ♻️

Currently, the test output is very noisy – even for green builds. This makes it very difficult find any _actual_ failures, especially on small screens and on phones.

Let's try to clean it up!

Here are the useless output I have found based on this test run. Leave a comment about what you are looking into (🔒) so others won't duplicate the effort.

A lot of these probably have the same root cause (for example, because of how the default Ember.onError works) and probably require some refactoring in the test infrastructure.

• Build phase
  
  
  
  • [ ] 'container' is imported by tmp/rollup-cache_path-I6PjJI6s.tmp/run_loop.js, but could not be resolved – treating it as an external dependency
  
  
  • [ ] 'ember-debug' is imported by tmp/rollup-cache_path-l0Z4sygU.tmp/index.js, but could not be resolved – treating it as an external dependency
  
  
  • [x] 'assert' is imported from external module '@glimmer/util' but never used
  
  
  • [x] 'assert' and 'SERIALIZATION_FIRST_NODE_STRING' are imported from external module '@glimmer/util' but never used (🔒 @James-Byrne)
  
  
• Test phase
  
  
  
  • [x] WARNING: Library "magic" is already registered with Ember.
  
  
  • [ ] console.trace
  
  
  • [x] DEPRECATION: Should not throw [deprecation id: test] (🔒 @Draggha )
  
  
  • [x] (node:6689) Warning: Possible EventEmitter memory leak detected. * listeners added. Use emitter.setMaxListeners() to increase limit (🔒 @lukecoy )
  
  
  • [x] (node:6689) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: *): Error: Navigation Timeout Exceeded: 900ms exceeded
  
  
  • [x] Error: Element .does-not-exist not found. (🔒 @KamiKillertO )
  
  
  • [x] Error: Catch me (🔒 @KamiKillertO )
  
  
  • [x] Error: the error (🔒 @KamiKillertO )
  
  
  • [x] Testing paused. UseresumeTest()to continue.
  
  
  • [x] The library version banner on app boot (🔒 @Draggha )
    
    DEBUG: ------------------------------- DEBUG: Ember : * DEBUG: jQuery : * DEBUG: -------------------------------
  
  
  • [ ] Error while processing route: * (🔒 @allthesignals )
  
  
  • [ ] More context objects were passed than there are dynamic segments for the route: stink-bomb
    
    `
  
  
  • [x] WARNING: Binding style attributes may introduce cross-site scripting vulnerabilities; please ensure that values being bound are properly escaped. For more information, including how to disable this warning, see https://emberjs.com/deprecations/v1.x/#toc_binding-style-attributes. Style affected: * (🔒 @KamiKillertO )
  
  

[James-Byrne]

I can have a look at

Build Phase

'assert' and 'SERIALIZATION_FIRST_NODE_STRING' are imported from external module '@glimmer/util' but never used

[Draggha]

I'll take a stab at

Test Phase

Testing paused. Use resumeTest() to continue.

[Draggha]

I'd like to take a stab at

Test Phase

WARNING: Library "magic" is already registered with Ember.

The console.trace message beneath it should be resolved with the same fix if I saw correctly.

[KamiKillertO]

I Can have a look at Error: Element .does-not-exist not found.

[acorncom]

Thanks folks, I’ve updated the issue accordingly

[KamiKillertO]

I'll also take Error: Catch me and Error: the error. They are related to Error: Element .does-not-exist not found.

[Draggha]

I think I have an idea how to handle the library version banner on app boot:

DEBUG: -------------------------------
DEBUG: Ember  : *
DEBUG: jQuery : *
DEBUG: -------------------------------

[Draggha]

I can have a look at:

DEPRECATION: Should not throw [deprecation id: test]

:)

[acorncom]

Thanks @Draggha, noted 👍

[KamiKillertO]

I take

WARNING: Binding style attributes may introduce cross-site scripting vulnerabilities; ...

[allthesignals]

I'll take a stab at Error while processing route: *

Edit: No dice, not sure how to suppress the error message. Since it's throwing an error on an instance of another object (a Route), it may not be getting caught by the error callback... open to suggestions!

this.add(
  'route:c',
  Route.extend({
    afterModel() {
      throw new Error('transition failure');
    }
  })
);

Edit2: Got a PR for an attempt but want to make sure it's ok approach before I apply everywhere.

[acorncom]

Thanks @allthesignals, noted

[acorncom]

Ok folks, we've got 8 items left here. Any takers? @James-Byrne looks like there isn't a PR yet for your task, did we miss linking the PR over? Do you still want to take the one with your name on it or should we unlock that and let someone else take a stab?

[KamiKillertO]

I can take :

node:6689) UnhandledPromiseRejectionWarning: and More context objects were passed than there are dynamic segments for the route: stink-bomb 😄

[allthesignals]

@acorncom this test actually checks the window console for error messages: https://github.com/emberjs/ember.js/blob/master/packages/ember/tests/routing/decoupled_basic_test.js#L3471. Should it be rewritten to check these messages differently? Or skipped? Not sure how conservative I should try to be. Thx.

Edit: Ah, @KamiKillertO, I think this is overlap of what you've taken on.

[lukecoy]

I wouldn't mind taking a look at this one:

Test Phase
(node:6689) Warning: Possible EventEmitter memory leak detected. * listeners added. Use emitter.setMaxListeners() to increase limit

[rwjblue]

@lukecoy - you got it!

[KamiKillertO]

It's seems that (node:6689) UnhandledPromiseRejectionWarning: Unhandled promise rejection is already fixed. I cannot find this error in the logs

[KamiKillertO]

I will have a look to 'container' is imported by tmp/rollup-cache_path-I6PjJI6s.tmp/run_loop.js, but could not be resolved – treating it as an external dependency but i'm not sure where to look 😞

[acorncom]

Hey folks, we're getting close here. Anyone blocked on things and need help in a given area?

[KamiKillertO]

🙋I'm stuck with 'container' is imported by tmp/rollup-cache_path-I6PjJI6s.tmp/run_loop.js, but could not be resolved – treating it as an external dependency

[edit] I've just check on masterand this message no longer appear 😄

[acorncom]

@rwjblue @chancancode any guidance here? I've got even less context on the snag than @KamiKillertO does 😉

[pixelhandler]

@Draggha @James-Byrne @KamiKillertO @acorncom @allthesignals @chancancode @lukecoy @rwjblue is this still an issue, perhaps we should close, what do you think?

@chancancode Is there anything that remains TODO?

[chancancode]

Looks like a lot of these are addressed, I am okay closing the tracking issue and filing new ones as needed. I opened #17016 and #17017. Looks like a few of these still have outstanding PRs waiting for reviews also.